projects
/
synfig.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Add operator != too.
[synfig.git]
/
synfig-core
/
trunk
/
src
/
modules
/
mptr_mplayer
/
mptr_mplayer.cpp
diff --git
a/synfig-core/trunk/src/modules/mptr_mplayer/mptr_mplayer.cpp
b/synfig-core/trunk/src/modules/mptr_mplayer/mptr_mplayer.cpp
index
f6a621a
..
9e3d547
100644
(file)
--- a/
synfig-core/trunk/src/modules/mptr_mplayer/mptr_mplayer.cpp
+++ b/
synfig-core/trunk/src/modules/mptr_mplayer/mptr_mplayer.cpp
@@
-72,6
+72,9
@@
mplayer_mptr::~mplayer_mptr()
bool
mplayer_mptr::GetFrame(Time time, synfig::Surface &surface, synfig::ProgressCallback *)
{
bool
mplayer_mptr::GetFrame(Time time, synfig::Surface &surface, synfig::ProgressCallback *)
{
+
+#error This code has vulnerabilites: arbitrary shell command execution and tmpfile issues
+
int ret;
ret=system(
strprintf("/usr/local/bin/mencoder \"%s\" -ovc rawrgb -ss %f -endpos 0 -nosound -o /tmp/tmp.synfig.rgbdata | grep \"VIDEO\" > /tmp/tmp.synfig.size",
int ret;
ret=system(
strprintf("/usr/local/bin/mencoder \"%s\" -ovc rawrgb -ss %f -endpos 0 -nosound -o /tmp/tmp.synfig.rgbdata | grep \"VIDEO\" > /tmp/tmp.synfig.size",