package net.pterodactylus.sone.web.pages
-import net.pterodactylus.sone.data.SoneOptions.DefaultSoneOptions
-import net.pterodactylus.sone.data.SoneOptions.LoadExternalContent.FOLLOWED
-import net.pterodactylus.sone.data.SoneOptions.LoadExternalContent.TRUSTED
-import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired
+import net.pterodactylus.sone.data.SoneOptions.*
+import net.pterodactylus.sone.data.SoneOptions.LoadExternalContent.*
+import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired.*
import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired.ALWAYS
-import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired.NO
-import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired.WRITING
-import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.sone.web.pages.OptionsPage
-import net.pterodactylus.util.web.Method.POST
-import org.hamcrest.MatcherAssert.assertThat
-import org.hamcrest.Matchers.equalTo
-import org.hamcrest.Matchers.hasItem
-import org.hamcrest.Matchers.nullValue
-import org.junit.Before
-import org.junit.Test
+import net.pterodactylus.sone.test.*
+import net.pterodactylus.sone.web.*
+import net.pterodactylus.sone.web.page.*
+import net.pterodactylus.util.web.Method.*
+import org.hamcrest.MatcherAssert.*
+import org.hamcrest.Matchers.*
+import org.junit.*
/**
* Unit test for [OptionsPage].
*/
-class OptionsPageTest : WebPageTest() {
-
- private val page = OptionsPage(template, webInterface)
-
- override fun getPage() = page
+class OptionsPageTest : WebPageTest(::OptionsPage) {
@Before
fun setupPreferences() {
- core.preferences.insertionDelay = 1
- core.preferences.charactersPerPost = 50
- core.preferences.fcpFullAccessRequired = WRITING
- core.preferences.imagesPerPage = 4
- core.preferences.isFcpInterfaceActive = true
- core.preferences.isRequireFullAccess = true
- core.preferences.negativeTrust = 7
- core.preferences.positiveTrust = 8
- core.preferences.postCutOffLength = 51
- core.preferences.postsPerPage = 10
- core.preferences.trustComment = "11"
+ core.preferences.newInsertionDelay = 1
+ core.preferences.newCharactersPerPost = 50
+ core.preferences.newFcpFullAccessRequired = WRITING
+ core.preferences.newImagesPerPage = 4
+ core.preferences.newFcpInterfaceActive = true
+ core.preferences.newRequireFullAccess = true
+ core.preferences.newPostCutOffLength = 51
+ core.preferences.newPostsPerPage = 10
}
@Before
}
@Test
+ fun `page returns correct path`() {
+ assertThat(page.path, equalTo("options.html"))
+ }
+
+ @Test
+ fun `page does not require login`() {
+ assertThat(page.requiresLogin(), equalTo(false))
+ }
+
+ @Test
+ fun `page returns correct title`() {
+ addTranslation("Page.Options.Title", "options page title")
+ assertThat(page.getPageTitle(soneRequest), equalTo("options page title"))
+ }
+
+ @Test
fun `get request stores all preferences in the template context`() {
- page.handleRequest(freenetRequest, templateContext)
- assertThat(templateContext["auto-follow"], equalTo<Any>(true))
- assertThat(templateContext["show-notification-new-sones"], equalTo<Any>(true))
- assertThat(templateContext["show-notification-new-posts"], equalTo<Any>(true))
- assertThat(templateContext["show-notification-new-replies"], equalTo<Any>(true))
- assertThat(templateContext["enable-sone-insert-notifications"], equalTo<Any>(true))
- assertThat(templateContext["load-linked-images"], equalTo<Any>("FOLLOWED"))
- assertThat(templateContext["show-custom-avatars"], equalTo<Any>("FOLLOWED"))
- assertThat(templateContext["insertion-delay"], equalTo<Any>(1))
- assertThat(templateContext["characters-per-post"], equalTo<Any>(50))
- assertThat(templateContext["fcp-full-access-required"], equalTo<Any>(1))
- assertThat(templateContext["images-per-page"], equalTo<Any>(4))
- assertThat(templateContext["fcp-interface-active"], equalTo<Any>(true))
- assertThat(templateContext["require-full-access"], equalTo<Any>(true))
- assertThat(templateContext["negative-trust"], equalTo<Any>(7))
- assertThat(templateContext["positive-trust"], equalTo<Any>(8))
- assertThat(templateContext["post-cut-off-length"], equalTo<Any>(51))
- assertThat(templateContext["posts-per-page"], equalTo<Any>(10))
- assertThat(templateContext["trust-comment"], equalTo<Any>("11"))
+ verifyNoRedirect {
+ assertThat(templateContext["auto-follow"], equalTo<Any>(true))
+ assertThat(templateContext["show-notification-new-sones"], equalTo<Any>(true))
+ assertThat(templateContext["show-notification-new-posts"], equalTo<Any>(true))
+ assertThat(templateContext["show-notification-new-replies"], equalTo<Any>(true))
+ assertThat(templateContext["enable-sone-insert-notifications"], equalTo<Any>(true))
+ assertThat(templateContext["load-linked-images"], equalTo<Any>("FOLLOWED"))
+ assertThat(templateContext["show-custom-avatars"], equalTo<Any>("FOLLOWED"))
+ assertThat(templateContext["insertion-delay"], equalTo<Any>(1))
+ assertThat(templateContext["characters-per-post"], equalTo<Any>(50))
+ assertThat(templateContext["fcp-full-access-required"], equalTo<Any>(1))
+ assertThat(templateContext["images-per-page"], equalTo<Any>(4))
+ assertThat(templateContext["fcp-interface-active"], equalTo<Any>(true))
+ assertThat(templateContext["require-full-access"], equalTo<Any>(true))
+ assertThat(templateContext["post-cut-off-length"], equalTo<Any>(51))
+ assertThat(templateContext["posts-per-page"], equalTo<Any>(10))
+ }
}
@Test
fun `get request without sone does not store sone-specific preferences in the template context`() {
unsetCurrentSone()
- page.handleRequest(freenetRequest, templateContext)
- assertThat(templateContext["auto-follow"], nullValue())
- assertThat(templateContext["show-notification-new-sones"], nullValue())
- assertThat(templateContext["show-notification-new-posts"], nullValue())
- assertThat(templateContext["show-notification-new-replies"], nullValue())
- assertThat(templateContext["enable-sone-insert-notifications"], nullValue())
- assertThat(templateContext["load-linked-images"], nullValue())
- assertThat(templateContext["show-custom-avatars"], nullValue())
+ verifyNoRedirect {
+ assertThat(templateContext["auto-follow"], nullValue())
+ assertThat(templateContext["show-notification-new-sones"], nullValue())
+ assertThat(templateContext["show-notification-new-posts"], nullValue())
+ assertThat(templateContext["show-notification-new-replies"], nullValue())
+ assertThat(templateContext["enable-sone-insert-notifications"], nullValue())
+ assertThat(templateContext["load-linked-images"], nullValue())
+ assertThat(templateContext["show-custom-avatars"], nullValue())
+ }
}
private fun <T> verifyThatOptionCanBeSet(option: String, setValue: Any?, expectedValue: T, getter: () -> T) {
setMethod(POST)
addHttpRequestPart("show-custom-avatars", "ALWAYS")
addHttpRequestPart("load-linked-images", "ALWAYS")
- addHttpRequestPart(option, setValue.toString())
+ setValue?.also { addHttpRequestPart(option, it.toString()) }
verifyRedirect("options.html") {
assertThat(getter(), equalTo(expectedValue))
}
}
@Test
+ fun `auto-follow option can be unset`() {
+ verifyThatOptionCanBeSet("auto-follow", null, false) { currentSone.options.isAutoFollow }
+ }
+
+ @Test
fun `show new sone notification option can be set`() {
verifyThatOptionCanBeSet("show-notification-new-sones", "checked", true) { currentSone.options.isShowNewSoneNotifications }
}
@Test
+ fun `show new sone notification option can be unset`() {
+ verifyThatOptionCanBeSet("" +
+ "", null, false) { currentSone.options.isShowNewSoneNotifications }
+ }
+
+ @Test
fun `show new post notification option can be set`() {
verifyThatOptionCanBeSet("show-notification-new-posts", "checked", true) { currentSone.options.isShowNewPostNotifications }
}
@Test
+ fun `show new post notification option can be unset`() {
+ verifyThatOptionCanBeSet("show-notification-new-posts", null, false) { currentSone.options.isShowNewPostNotifications }
+ }
+
+ @Test
fun `show new reply notification option can be set`() {
verifyThatOptionCanBeSet("show-notification-new-replies", "checked", true) { currentSone.options.isShowNewReplyNotifications }
}
@Test
+ fun `show new reply notification option can be unset`() {
+ verifyThatOptionCanBeSet("show-notification-new-replies", null, false) { currentSone.options.isShowNewReplyNotifications }
+ }
+
+ @Test
fun `enable sone insert notifications option can be set`() {
verifyThatOptionCanBeSet("enable-sone-insert-notifications", "checked", true) { currentSone.options.isSoneInsertNotificationEnabled }
}
@Test
+ fun `enable sone insert notifications option can be unset`() {
+ verifyThatOptionCanBeSet("enable-sone-insert-notifications", null, false) { currentSone.options.isSoneInsertNotificationEnabled }
+ }
+
+ @Test
fun `load linked images option can be set`() {
verifyThatOptionCanBeSet("load-linked-images", "TRUSTED", TRUSTED) { currentSone.options.loadLinkedImages }
}
unsetCurrentSone()
setMethod(POST)
addHttpRequestPart(name, value)
- page.handleRequest(freenetRequest, templateContext)
- assertThat(templateContext["fieldErrors"] as Iterable<*>, hasItem(name))
+ verifyNoRedirect {
+ assertThat(templateContext["fieldErrors"] as Iterable<*>, hasItem(name))
+ }
}
private fun <T> verifyThatPreferencesCanBeSet(name: String, setValue: String?, expectedValue: T, getter: () -> T) {
unsetCurrentSone()
setMethod(POST)
- addHttpRequestPart(name, setValue)
+ setValue?.also { addHttpRequestPart(name, it) }
verifyRedirect("options.html") {
assertThat(getter(), equalTo(expectedValue))
}
@Test
fun `fcp interface can be set to true`() {
- verifyThatPreferencesCanBeSet("fcp-interface-active", "checked", true) { core.preferences.isFcpInterfaceActive }
+ verifyThatPreferencesCanBeSet("fcp-interface-active", "checked", true) { core.preferences.fcpInterfaceActive }
}
@Test
fun `fcp interface can be set to false`() {
- verifyThatPreferencesCanBeSet("fcp-interface-active", null, false) { core.preferences.isFcpInterfaceActive }
+ verifyThatPreferencesCanBeSet("fcp-interface-active", null, false) { core.preferences.fcpInterfaceActive }
}
@Test
fun `require full access can be set to true`() {
- verifyThatPreferencesCanBeSet("require-full-access", "checked", true) { core.preferences.isRequireFullAccess }
+ verifyThatPreferencesCanBeSet("require-full-access", "checked", true) { core.preferences.requireFullAccess }
}
@Test
fun `require full access can be set to false`() {
- verifyThatPreferencesCanBeSet("require-full-access", null, false) { core.preferences.isRequireFullAccess }
- }
-
- @Test
- fun `negative trust can not be set to -101`() {
- verifyThatWrongValueForPreferenceIsDetected("negative-trust", "-101")
- }
-
- @Test
- fun `negative trust can be set to -100`() {
- verifyThatPreferencesCanBeSet("negative-trust", "-100", -100) { core.preferences.negativeTrust }
- }
-
- @Test
- fun `negative trust can be set to 100`() {
- verifyThatPreferencesCanBeSet("negative-trust", "100", 100) { core.preferences.negativeTrust }
- }
-
- @Test
- fun `negative trust can not be set to 101`() {
- verifyThatWrongValueForPreferenceIsDetected("negative-trust", "101")
- }
-
- @Test
- fun `negative trust is set to default on invalid value`() {
- verifyThatPreferencesCanBeSet("negative-trust", "invalid", -25) { core.preferences.negativeTrust }
- }
-
- @Test
- fun `positive trust can not be set to -1`() {
- verifyThatWrongValueForPreferenceIsDetected("positive-trust", "-1")
- }
-
- @Test
- fun `positive trust can be set to 0`() {
- verifyThatPreferencesCanBeSet("positive-trust", "0", 0) { core.preferences.positiveTrust }
- }
-
- @Test
- fun `positive trust can be set to 100`() {
- verifyThatPreferencesCanBeSet("positive-trust", "100", 100) { core.preferences.positiveTrust }
- }
-
- @Test
- fun `positive trust can not be set to 101`() {
- verifyThatWrongValueForPreferenceIsDetected("positive-trust", "101")
- }
-
- @Test
- fun `positive trust is set to default on invalid value`() {
- verifyThatPreferencesCanBeSet("positive-trust", "invalid", 75) { core.preferences.positiveTrust }
+ verifyThatPreferencesCanBeSet("require-full-access", null, false) { core.preferences.requireFullAccess }
}
@Test
}
@Test
- fun `trust comment can be set`() {
- verifyThatPreferencesCanBeSet("trust-comment", "trust", "trust") { core.preferences.trustComment }
+ fun `page can be created by dependency injection`() {
+ assertThat(baseInjector.getInstance<OptionsPage>(), notNullValue())
+ }
+
+ @Test
+ fun `page is annotated with correct menuname`() {
+ assertThat(page.menuName, equalTo("Options"))
}
@Test
- fun `trust comment is set to default when set to empty value`() {
- verifyThatPreferencesCanBeSet("trust-comment", "", "Set from Sone Web Interface") { core.preferences.trustComment }
+ fun `page is annotated with correct template path`() {
+ assertThat(page.templatePath, equalTo("/templates/options.html"))
}
}