Minor security fix: the unused mod_ffmpeg importer used popen to run convert, change...

[synfig.git] / synfig-core / trunk / src / modules / mod_ffmpeg / trgt_ffmpeg.cpp

diff --git a/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp b/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp
index db21ea3..d2e8525 100644 (file)
--- a/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp
+++ b/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp
@@ -2,6 +2,8 @@
 /*!    \file trgt_ffmpeg.cpp
 **     \brief ppm Target Module
 **
+**     $Id$
+**
 **     \legal
 **     Copyright (c) 2002-2005 Robert B. Quattlebaum Jr., Adrian Bentley
 **
@@ -34,6 +36,9 @@
 #include <ETL/stringf>
 #include "trgt_ffmpeg.h"
 #include <stdio.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <unistd.h>
 #include <algorithm>
 #include <functional>
 #include <ETL/clock>
@@ -52,12 +57,13 @@ SYNFIG_TARGET_INIT(ffmpeg_trgt);
 SYNFIG_TARGET_SET_NAME(ffmpeg_trgt,"ffmpeg");
 SYNFIG_TARGET_SET_EXT(ffmpeg_trgt,"mpg");
 SYNFIG_TARGET_SET_VERSION(ffmpeg_trgt,"0.1");
-SYNFIG_TARGET_SET_CVS_ID(ffmpeg_trgt,"$Id: trgt_ffmpeg.cpp,v 1.1.1.1 2005/01/04 01:23:10 darco Exp $");
+SYNFIG_TARGET_SET_CVS_ID(ffmpeg_trgt,"$Id$");
 
 /* === M E T H O D S ======================================================= */
 
 ffmpeg_trgt::ffmpeg_trgt(const char *Filename)
 {
+       pid=-1;
        file=NULL;
        filename=Filename;
        multi_image=false;
@@ -72,7 +78,9 @@ ffmpeg_trgt::~ffmpeg_trgt()
        {
                etl::yield();
                sleep(1);
-               pclose(file);
+               fclose(file);
+               int status;
+               waitpid(pid,&status,0);
        }
        file=NULL;
        delete [] buffer;
@@ -122,11 +130,43 @@ ffmpeg_trgt::init()
        imagecount=desc.get_frame_start();
        if(desc.get_frame_end()-desc.get_frame_start()>0)
                multi_image=true;
-       string command;
-
-       command=strprintf("ffmpeg -f image2pipe -vcodec ppm -an -r %f -i pipe: -loop -hq -title \"%s\" -vcodec mpeg1video -y \"%s\"\n",desc.get_frame_rate(),get_canvas()->get_name().c_str(),filename.c_str());
 
-       file=popen(command.c_str(),"w");
+       int p[2];
+  
+       if (pipe(p)) {
+               synfig::error(_("Unable to open pipe to ffmpeg"));
+               return false;
+       };
+  
+       pid = fork();
+  
+       if (pid == -1) {
+               synfig::error(_("Unable to open pipe to ffmpeg"));
+               return false;
+       }
+  
+       if (pid == 0){
+               // Child process
+               // Close pipeout, not needed
+               close(p[1]);
+               // Dup pipeout to stdin
+               if( dup2( p[0], STDIN_FILENO ) == -1 ){
+                       synfig::error(_("Unable to open pipe to ffmpeg"));
+                       return false;
+               }
+               // Close the unneeded pipeout
+               close(p[0]);
+               execlp("ffmpeg", "ffmpeg", "-f", "image2pipe", "-vcodec", "ppm", "-an", "-r", strprintf("%f", desc.get_frame_rate()).c_str(), "-i", "pipe:", "-loop", "-hq", "-title", get_canvas()->get_name().c_str(), "-vcodec", "mpeg1video", "-y", "--", filename.c_str(), (const char *)NULL);
+               // We should never reach here unless the exec failed
+               synfig::error(_("Unable to open pipe to ffmpeg"));
+               return false;
+       } else {
+               // Parent process
+               // Close pipein, not needed
+               close(p[0]);
+               // Save pipeout to file handle, will write to it later
+               file = fdopen(p[1], "wb");
+       }
 
        // etl::yield();
 
@@ -148,7 +188,7 @@ ffmpeg_trgt::end_frame()
 }
 
 bool
-ffmpeg_trgt::start_frame(synfig::ProgressCallback *callback)
+ffmpeg_trgt::start_frame(synfig::ProgressCallback */*callback*/)
 {
        int w=desc.get_w(),h=desc.get_h();
 
@@ -168,7 +208,7 @@ ffmpeg_trgt::start_frame(synfig::ProgressCallback *callback)
 }
 
 Color *
-ffmpeg_trgt::start_scanline(int scanline)
+ffmpeg_trgt::start_scanline(int /*scanline*/)
 {
        return color_buffer;
 }