X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=ETL%2Ftrunk%2FETL%2F_angle.h;h=1abf9303b9d392e66ef3ce914164119eb8c32503;hb=4dd6c6c11c69d048bd14cddf9c4336017dcd6ea7;hp=1be01bbfcfec00741a63c0518fd34ee78f5067ad;hpb=36d01e1527fda602a9aed07d209eb34e6770bca8;p=synfig.git

diff --git a/ETL/trunk/ETL/_angle.h b/ETL/trunk/ETL/_angle.h
index 1be01bb..1abf930 100644
--- a/ETL/trunk/ETL/_angle.h
+++ b/ETL/trunk/ETL/_angle.h
@@ -1,3 +1,4 @@
+#include <stdio.h>
 /* ========================================================================
 ** Extended Template and Library
 ** Angle Abstraction Class Implementation
@@ -59,7 +60,7 @@ public:
 protected:
 	typedef value_type unit;
 
-	unit v;	//! Stored in rotations
+	unit v;	//! Stored in radians; positive values indicate counter-clockwise.
 
 public:
 
@@ -69,41 +70,41 @@ public:
 
 	const angle	&
 	operator+=(const angle &rhs)
-		{ v+=rhs.v; return *this; }
+	{ v+=rhs.v; return *this; }
 
 	const angle	&
 	operator-=(const angle &rhs)
-		{ v-=rhs.v; return *this; }
+	{ v-=rhs.v; return *this; }
 
 	const angle	&
 	operator*=(const unit &rhs)
-		{ v*=rhs; return *this; }
+	{ v*=rhs; return *this; }
 
 	const angle	&
 	operator/=(const unit &rhs)
-		{ v/=rhs; return *this; }
+	{ v/=rhs; return *this; }
 
 	//! Angle Addition Operator
 	angle
 	operator+(const angle &rhs)const
-		{ return angle(*this)+=rhs; }
+	{ return angle(*this)+=rhs; }
 
 	//! Angle Subtraction Operator
 	/*! \sa angle dist(const angle &) */
 	angle
 	operator-(const angle &rhs)const
-		{ return angle(*this)-=rhs; }
+	{ return angle(*this)-=rhs; }
 
 	//! Angle Scalar Multiplication Operator
 	/*! This operator will multiply the given
 		angle by the given scalar value. */
 	angle
 	operator*(const unit &rhs)const
-		{ return angle(*this)*=rhs; }
+	{ return angle(*this)*=rhs; }
 
 	angle
 	operator/(const unit &rhs)const
-		{ return angle(*this)/=rhs; }
+	{ return angle(*this)/=rhs; }
 
 	//! Angle Negation
 	angle
@@ -122,61 +123,55 @@ public:
 	operator~()const
 	{
 		angle ret;
-		ret.v=(value_type)std::floor(v+0.5f);
-		return ret;
+		ret.v = v+PI;
+		return ret.mod();
 	}
 
 	/*! Returns true if the shortest
-		angle between the left-hand and
-		right-hand side is clockwise */
+		angle from the left-hand to the
+		right-hand side is counter-clockwise */
 	bool
 	operator<(const angle &rhs)const
-	{ return v<rhs.v; }
-//	{ return dist(rhs).v<(value_type)0.0; }
+	{ return dist(rhs).v<(value_type)0.0; }
 
 	/*! Returns true if the shortest
-		angle between the left-hand and
-		right-hand side is counter-clockwise */
+		angle from the left-hand to the
+		right-hand side is clockwise */
 	bool
 	operator>(const angle &rhs)const
-	{ return v>rhs.v; }
-//	{ return dist(rhs).v>(value_type)0.0; }
+	{ return dist(rhs).v>(value_type)0.0; }
 
 	/*! Returns true if the shortest
-		angle between the left-hand and
-		right-hand side is clockwise,
+		angle from the left-hand to the
+		right-hand side is counter-clockwise,
 		or if the angles are refer to the same
 		point on the unit circle. */
 	bool
 	operator<=(const angle &rhs)const
-	{ return v<=rhs.v; }
-//	{ return dist(rhs).v<=(value_type)0.0; }
+	{ return dist(rhs).v<=(value_type)0.0; }
 
 	/*! Returns true if the shortest
-		angle between the left-hand and
-		right-hand side is counter-clockwise,
+		angle from the left-hand to the
+		right-hand side is clockwise,
 		or if the angles are refer to the same
 		point on the unit circle. */
 	bool
 	operator>=(const angle &rhs)const
-	{ return v>=rhs.v; }
-//	{ return dist(rhs).v>=(value_type)0.0; }
+	{ return dist(rhs).v>=(value_type)0.0; }
 
 	/*! Returns true if the angles
 		are refer to the same point
 		on the unit circle. */
 	bool
 	operator==(const angle &rhs)const
-	{ return v==rhs.v; }
-//	{ return dist(rhs).v==(value_type)0.0; }
+	{ return std::abs(dist(rhs).v)<epsilon; }
 
 	/*! Returns false if the angles
 		are refer to the same point
 		on the unit circle. */
 	bool
 	operator!=(const angle &rhs)const
-	{ return v!=rhs.v; }
-//	{ return dist(rhs).v!=(value_type)0.0; }
+	{ return std::abs(dist(rhs).v)>epsilon; }
 
 	//! Angle Difference Function
 	/*! This function will return the
@@ -187,11 +182,8 @@ public:
 	dist(const angle &rhs)const
 	{
 		angle ret;
-
 		ret.v=v-rhs.v;
-
 		ret.v-=rot_floor(ret.v+PI);
-
 		return ret;
 	}
 
@@ -206,6 +198,7 @@ public:
 		return ret;
 	}
 
+	//! Zero Rotation (0 degrees)
 	static angle
 	zero()
 	{
@@ -214,32 +207,36 @@ public:
 		return ret;
 	}
 
+	//! One Complete Rotation (360 degrees)
 	static angle
 	one()
 	{
 		angle ret;
-		ret.v=PI;
+		ret.v=PI*2;
 		return ret;
 	}
 
+	//! One Half Rotation (180 degrees)
 	static angle
 	half()
 	{
 		angle ret;
-		ret.v=PI*0.5;
+		ret.v=PI;
 		return ret;
 	}
 
-	bool operator!()const { return v==0; }
+	bool operator!()const { return std::abs(mod().v) < epsilon; }
 
 private:
 
 	static value_type rot_floor(value_type x)
 	{ return static_cast<value_type>(std::floor(x/(PI*2))*PI*2); }
 
+	static const value_type epsilon = 1.0e-6;
+
 public:
 	/*
-	** Converstion Classes
+	** Conversion Classes
 	*/
 
 	class rad;
@@ -247,7 +244,7 @@ public:
 	class rot;
 
 	/*
-	** Trigometric Classes
+	** Trigonometric Classes
 	*/
 
 	class sin;
@@ -289,12 +286,12 @@ public:
 	rad(const angle &a):angle(a) { }
 	rad	mod()const { return angle::mod(); }
 	rad dist(const angle &rhs)const { return angle::dist(rhs); }
+	value_type get()const { return v; }
 #ifndef ETL_NO_DEPRECATED
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
-	value_type get()const { return v; }
 }; // END of class angle::radians
-inline angle::rad::operator angle::value_type()const { return get(); }
+// inline angle::rad::operator angle::value_type()const { return get(); }
 
 // ========================================================================
 /*!	\class	angle::deg	_angle.h	ETL/angle
@@ -311,10 +308,10 @@ public:
 	deg dist(const angle &rhs)const { return angle::dist(rhs); }
 	value_type get()const { return v*360/(PI*2); }
 #ifndef ETL_NO_DEPRECATED
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
 }; // END of class angle::degrees
-inline angle::deg::operator angle::value_type()const { return get(); }
+// inline angle::deg::operator angle::value_type()const { return get(); }
 
 // ========================================================================
 /*!	\class	angle::rot	_angle.h	ETL/angle
@@ -331,10 +328,10 @@ public:
 	rot dist(const angle &rhs)const { return angle::dist(rhs); }
 	value_type get()const { return v/(PI*2); }
 #ifndef ETL_NO_DEPRECATED
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
 }; // END of class angle::rotations
-inline angle::rot::operator angle::value_type()const { return get(); }
+// inline angle::rot::operator angle::value_type()const { return get(); }
 
 // ========================================================================
 /*!	\class	angle::sin	_angle.h	ETL/angle
@@ -351,10 +348,10 @@ public:
 	sin dist(const angle &rhs)const { return angle::dist(rhs); }
 	value_type get()const { return static_cast<value_type>(std::sin(v)); }
 #ifndef ETL_NO_DEPRECATED
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
 }; // END of class angle::sin
-inline angle::sin::operator angle::value_type()const { return get(); }
+// inline angle::sin::operator angle::value_type()const { return get(); }
 
 // ========================================================================
 /*!	\class	angle::cos	_angle.h	ETL/angle
@@ -369,12 +366,12 @@ public:
 	cos(const angle &a):angle(a) { }
 	cos	mod()const { return angle::mod(); }
 	cos dist(const angle &rhs)const { return angle::dist(rhs); }
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
-#ifndef ETL_NO_DEPRECATED
 	value_type get()const { return (value_type)std::cos(v); }
+#ifndef ETL_NO_DEPRECATED
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
 }; // END of class angle::cos
-inline angle::cos::operator angle::value_type()const { return get(); }
+// inline angle::cos::operator angle::value_type()const { return get(); }
 
 // ========================================================================
 /*!	\class	angle::tan	_angle.h	ETL/angle
@@ -390,12 +387,12 @@ public:
 	tan(const angle &a):angle(a) { }
 	tan	mod()const { return angle::mod(); }
 	tan dist(const angle &rhs)const { return angle::dist(rhs); }
+	value_type get()const { return (value_type)std::tan(v); }
 #ifndef ETL_NO_DEPRECATED
-	operator value_type()const ETL_DEPRECATED_FUNCTION;
+	// operator value_type()const ETL_DEPRECATED_FUNCTION;
 #endif
-	value_type get()const { return (value_type)std::tan(v); }
 }; // END of class angle::tan
-inline angle::tan::operator angle::value_type()const { return get(); }
+// inline angle::tan::operator angle::value_type()const { return get(); }
 
 _ETL_END_NAMESPACE
 
@@ -435,7 +432,6 @@ struct distance_func<etl::angle> : public std::binary_function<etl::angle, etl::
 	etl::angle uncook(const etl::angle &x)const { return x; }
 };
 
-
 /* === E N D =============================================================== */
 
 #endif