X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Freactor%2Fengine%2FEngine.java;h=f14d3d7c2560e1c7751e9138bbf15ac4cb4be7a3;hb=44e9921d5af6f500180238b297d8b6b2bb069205;hp=60bc91dc116d449a2b7b642800ea68f5d613c7c8;hpb=9111850302534fa585ab2c418b36fe036aa9b404;p=rhynodge.git diff --git a/src/main/java/net/pterodactylus/reactor/engine/Engine.java b/src/main/java/net/pterodactylus/reactor/engine/Engine.java index 60bc91d..f14d3d7 100644 --- a/src/main/java/net/pterodactylus/reactor/engine/Engine.java +++ b/src/main/java/net/pterodactylus/reactor/engine/Engine.java @@ -64,15 +64,9 @@ public class Engine extends AbstractExecutionThreadService { * The name of the reaction * @param reaction * The reaction to add to this engine - * @throws IllegalStateException - * if the engine already contains a {@link Reaction} with the - * given name */ public void addReaction(String name, Reaction reaction) { synchronized (reactions) { - if (reactions.containsKey(name)) { - throw new IllegalStateException(String.format("Engine already contains a Reaction named “%s!”", name)); - } reactions.put(name, reaction); reactions.notifyAll(); } @@ -124,24 +118,25 @@ public class Engine extends AbstractExecutionThreadService { Reaction nextReaction; synchronized (reactions) { for (Entry reactionEntry : reactions.entrySet()) { - net.pterodactylus.reactor.State state = stateManager.loadState(reactionEntry.getKey()); + net.pterodactylus.reactor.State state = stateManager.loadLastState(reactionEntry.getKey()); long stateTime = (state != null) ? state.time() : 0; nextReactions.put(stateTime + reactionEntry.getValue().updateInterval(), Pair.of(reactionEntry.getKey(), reactionEntry.getValue())); } reactionName = nextReactions.get(nextReactions.firstKey()).getLeft(); nextReaction = nextReactions.get(nextReactions.firstKey()).getRight(); } - logger.debug(String.format("Next Reaction: %s.", nextReaction)); + logger.debug(String.format("Next Reaction: %s.", reactionName)); /* wait until the next reaction has to run. */ - net.pterodactylus.reactor.State lastState = stateManager.loadState(reactionName); + net.pterodactylus.reactor.State lastState = stateManager.loadLastState(reactionName); long lastStateTime = (lastState != null) ? lastState.time() : 0; + int lastStateFailCount = (lastState != null) ? lastState.failCount() : 0; long waitTime = (lastStateTime + nextReaction.updateInterval()) - System.currentTimeMillis(); logger.debug(String.format("Time to wait for next Reaction: %d millseconds.", waitTime)); if (waitTime > 0) { synchronized (reactions) { try { - logger.debug(String.format("Waiting for %d milliseconds.", waitTime)); + logger.info(String.format("Waiting until %tc.", lastStateTime + nextReaction.updateInterval())); reactions.wait(waitTime); } catch (InterruptedException ie1) { /* we’re looping! */ @@ -179,23 +174,25 @@ public class Engine extends AbstractExecutionThreadService { state = newState; } } - if (state.success()) { - stateManager.saveState(reactionName, state); + if (!state.success()) { + state.setFailCount(lastStateFailCount + 1); } + net.pterodactylus.reactor.State lastSuccessfulState = stateManager.loadLastSuccessfulState(reactionName); + stateManager.saveState(reactionName, state); - /* only run trigger if we have collected two states. */ + /* only run trigger if we have collected two successful states. */ Trigger trigger = nextReaction.trigger(); boolean triggerHit = false; - if ((lastState != null) && state.success()) { + if ((lastSuccessfulState != null) && lastSuccessfulState.success() && state.success()) { logger.debug("Checking Trigger for changes..."); - triggerHit = trigger.triggers(state, lastState); + triggerHit = trigger.triggers(state, lastSuccessfulState); } /* run action if trigger was hit. */ logger.debug(String.format("Trigger was hit: %s.", triggerHit)); if (triggerHit) { logger.info("Executing Action..."); - nextReaction.action().execute(trigger.output()); + nextReaction.action().execute(trigger.output(nextReaction)); } }