X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Frhynodge%2Fengine%2FReactionRunner.java;h=f4ae72e7b47989f8ba9870f8e61df0476c118549;hb=8c0ce9a01d3443c85cb0a05f8e3fd43ec8225197;hp=63711b9bbb459d980a8bd8f5dc669d9debe73f2c;hpb=52d4e876f2f9012712820a6d55db822421b79a97;p=rhynodge.git diff --git a/src/main/java/net/pterodactylus/rhynodge/engine/ReactionRunner.java b/src/main/java/net/pterodactylus/rhynodge/engine/ReactionRunner.java index 63711b9..f4ae72e 100644 --- a/src/main/java/net/pterodactylus/rhynodge/engine/ReactionRunner.java +++ b/src/main/java/net/pterodactylus/rhynodge/engine/ReactionRunner.java @@ -48,7 +48,7 @@ public class ReactionRunner implements Runnable { State state = runQuery(); state = runStateThroughFilters(state); if (!state.success()) { - logger.info(format("Reaction %s failed.", reaction.name())); + logger.info(format("Reaction %s failed in %s.", reaction.name(), state)); saveStateWithIncreasedFailCount(state); errorEmailAction.execute(createErrorOutput(reaction, state)); return; @@ -84,7 +84,7 @@ public class ReactionRunner implements Runnable { private String createErrorEmailText(Reaction reaction, State state) { StringBuilder emailText = new StringBuilder(); - emailText.append(String.format("An error occured while processing “.”\n\n", reaction.name())); + emailText.append(String.format("An error occured while processing “%s.”\n\n", reaction.name())); appendExceptionToEmailText(state.exception(), emailText); return emailText.toString(); } @@ -119,9 +119,6 @@ public class ReactionRunner implements Runnable { logger.debug(format("Filtering state through %s...", filter.getClass().getSimpleName())); try { currentState = filter.filter(currentState); - if (currentState.success() && currentState.isEmpty()) { - errorEmailAction.execute(createEmptyStateOutput(reaction, state)); - } } catch (Throwable t1) { logger.warn(format("Error during filter %s for %s.", filter.getClass().getSimpleName(), reaction.name()), t1); return new FailedState(t1); @@ -131,10 +128,4 @@ public class ReactionRunner implements Runnable { return currentState; } - private Output createEmptyStateOutput(Reaction reaction, State state) { - DefaultOutput defaultOutput = new DefaultOutput(String.format("Reached Empty State for “%s!”", reaction.name())); - defaultOutput.addText("text/plain", String.format("The %s for %s was empty.", state.getClass().getSimpleName(), reaction.name())); - return defaultOutput; - } - }