X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Frhynodge%2Fstates%2FStateManager.java;h=3e08c296638782846946d4c3b1859e81c0b66e4c;hb=c3d1babcce7f077c2b57376fa7f9712b921950d8;hp=19eccba3a4c92e230a16bb219f7395ae2a627b71;hpb=6ec36ef950c23c135bf0e112d932c5b7068189b8;p=rhynodge.git

diff --git a/src/main/java/net/pterodactylus/rhynodge/states/StateManager.java b/src/main/java/net/pterodactylus/rhynodge/states/StateManager.java
index 19eccba..3e08c29 100644
--- a/src/main/java/net/pterodactylus/rhynodge/states/StateManager.java
+++ b/src/main/java/net/pterodactylus/rhynodge/states/StateManager.java
@@ -17,8 +17,12 @@
 
 package net.pterodactylus.rhynodge.states;
 
+import static java.util.Optional.empty;
+import static java.util.Optional.ofNullable;
+
 import java.io.File;
 import java.io.IOException;
+import java.util.Optional;
 
 import net.pterodactylus.rhynodge.State;
 
@@ -64,10 +68,10 @@ public class StateManager {
 	 *
 	 * @param reactionName
 	 *            The name of the reaction
-	 * @return The loaded state, or {@code null} if the state could not be
+	 * @return The loaded state, or {@link Optional#empty()} if the state could not be
 	 *         loaded
 	 */
-	public State loadLastState(String reactionName) {
+	public Optional<State> loadLastState(String reactionName) {
 		return loadLastState(reactionName, false);
 	}
 
@@ -76,10 +80,10 @@ public class StateManager {
 	 *
 	 * @param reactionName
 	 *            The name of the reaction
-	 * @return The loaded state, or {@code null} if the state could not be
+	 * @return The loaded state, or {@link Optional#empty()} if the state could not be
 	 *         loaded
 	 */
-	public State loadLastSuccessfulState(String reactionName) {
+	public Optional<State> loadLastSuccessfulState(String reactionName) {
 		return loadLastState(reactionName, true);
 	}
 
@@ -92,8 +96,9 @@ public class StateManager {
 	 *            The state to save
 	 */
 	public void saveState(String reactionName, State state) {
+		File stateFile = null;
 		try {
-			File stateFile = stateFile(reactionName, "last");
+			stateFile = stateFile(reactionName, "last");
 			objectMapper.writeValue(stateFile, state);
 			if (state.success()) {
 				stateFile = stateFile(reactionName, "success");
@@ -101,10 +106,13 @@ public class StateManager {
 			}
 		} catch (JsonGenerationException jge1) {
 			logger.warn(String.format("State for Reaction “%s” could not be generated.", reactionName), jge1);
+			stateFile.delete();
 		} catch (JsonMappingException jme1) {
 			logger.warn(String.format("State for Reaction “%s” could not be generated.", reactionName), jme1);
+			stateFile.delete();
 		} catch (IOException ioe1) {
 			logger.warn(String.format("State for Reaction “%s” could not be written.", reactionName));
+			stateFile.delete();
 		}
 	}
 
@@ -133,14 +141,14 @@ public class StateManager {
 	 * @param successful
 	 *            {@code true} to load the last successful state, {@code false}
 	 *            to load the last state
-	 * @return The loaded state, or {@code null} if the state could not be
+	 * @return The loaded state, or {@link Optional#empty()} if the state could not be
 	 *         loaded
 	 */
-	private State loadLastState(String reactionName, boolean successful) {
+	private Optional<State> loadLastState(String reactionName, boolean successful) {
 		File stateFile = stateFile(reactionName, successful ? "success" : "last");
 		try {
 			State state = objectMapper.readValue(stateFile, AbstractState.class);
-			return state;
+			return ofNullable(state);
 		} catch (JsonParseException jpe1) {
 			logger.warn(String.format("State for Reaction “%s” could not be parsed.", reactionName), jpe1);
 		} catch (JsonMappingException jme1) {
@@ -148,7 +156,7 @@ public class StateManager {
 		} catch (IOException ioe1) {
 			logger.info(String.format("State for Reaction “%s” could not be found.", reactionName));
 		}
-		return null;
+		return empty();
 	}
 
 }