X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fajax%2FGetLikesAjaxPage.java;h=1a5286f27f9df48ac306c79715340becfff1a401;hb=7bf3f34153d68c6c74245e24d0957aa11e93b056;hp=7b55faa403c63679d1ff63a01ba71623fe6e298a;hpb=dc3d0d58fd47e520c723aa7d258c2f7ae09e1ee7;p=Sone.git

diff --git a/src/main/java/net/pterodactylus/sone/web/ajax/GetLikesAjaxPage.java b/src/main/java/net/pterodactylus/sone/web/ajax/GetLikesAjaxPage.java
index 7b55faa..1a5286f 100644
--- a/src/main/java/net/pterodactylus/sone/web/ajax/GetLikesAjaxPage.java
+++ b/src/main/java/net/pterodactylus/sone/web/ajax/GetLikesAjaxPage.java
@@ -1,5 +1,5 @@
 /*
- * Sone - GetLikesAjaxPage.java - Copyright © 2010 David Roden
+ * Sone - GetLikesAjaxPage.java - Copyright © 2010–2013 David Roden
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -23,13 +23,16 @@ import java.util.List;
 import java.util.Set;
 
 import net.pterodactylus.sone.data.Post;
-import net.pterodactylus.sone.data.Reply;
+import net.pterodactylus.sone.data.PostReply;
 import net.pterodactylus.sone.data.Sone;
 import net.pterodactylus.sone.template.SoneAccessor;
 import net.pterodactylus.sone.web.WebInterface;
+import net.pterodactylus.sone.web.page.FreenetRequest;
 import net.pterodactylus.util.json.JsonArray;
 import net.pterodactylus.util.json.JsonObject;
 
+import com.google.common.base.Optional;
+
 /**
  * AJAX page that retrieves the number of “likes” a {@link Post} has.
  *
@@ -44,7 +47,7 @@ public class GetLikesAjaxPage extends JsonPage {
 	 *            The Sone web interface
 	 */
 	public GetLikesAjaxPage(WebInterface webInterface) {
-		super("ajax/getLikes.ajax", webInterface);
+		super("getLikes.ajax", webInterface);
 	}
 
 	//
@@ -55,20 +58,26 @@ public class GetLikesAjaxPage extends JsonPage {
 	 * {@inheritDoc}
 	 */
 	@Override
-	protected JsonObject createJsonObject(Request request) {
+	protected JsonObject createJsonObject(FreenetRequest request) {
 		String type = request.getHttpRequest().getParam("type", null);
 		String id = request.getHttpRequest().getParam(type, null);
 		if ((id == null) || (id.length() == 0)) {
 			return createErrorJsonObject("invalid-" + type + "-id");
 		}
 		if ("post".equals(type)) {
-			Post post = webInterface.getCore().getPost(id);
-			Set<Sone> sones = webInterface.getCore().getLikes(post);
-			return new JsonObject().put("success", true).put("likes", sones.size()).put("sones", getSones(sones));
+			Optional<Post> post = webInterface.getCore().getPost(id);
+			if (!post.isPresent()) {
+				return createErrorJsonObject("invalid-post-id");
+			}
+			Set<Sone> sones = webInterface.getCore().getLikes(post.get());
+			return createSuccessJsonObject().put("likes", sones.size()).put("sones", getSones(sones));
 		} else if ("reply".equals(type)) {
-			Reply reply = webInterface.getCore().getReply(id);
-			Set<Sone> sones = webInterface.getCore().getLikes(reply);
-			return new JsonObject().put("success", true).put("likes", sones.size()).put("sones", getSones(sones));
+			Optional<PostReply> reply = webInterface.getCore().getPostReply(id);
+			if (!reply.isPresent()) {
+				return createErrorJsonObject("invalid-reply-id");
+			}
+			Set<Sone> sones = webInterface.getCore().getLikes(reply.get());
+			return createSuccessJsonObject().put("likes", sones.size()).put("sones", getSones(sones));
 		}
 		return createErrorJsonObject("invalid-type");
 	}
@@ -93,7 +102,7 @@ public class GetLikesAjaxPage extends JsonPage {
 	 *            The Sones to convert to an array
 	 * @return The Sones, sorted by name
 	 */
-	private JsonArray getSones(Set<Sone> sones) {
+	private static JsonArray getSones(Set<Sone> sones) {
 		JsonArray soneArray = new JsonArray();
 		List<Sone> sortedSones = new ArrayList<Sone>(sones);
 		Collections.sort(sortedSones, Sone.NICE_NAME_COMPARATOR);