X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Ftest%2Fjava%2Fnet%2Fpterodactylus%2Fsone%2Fcore%2FSoneParserTest.java;h=19e5ae2fd4899584ffe161fcce9f4c677b4c7663;hb=a803c59dc90720f736f2c582f74b3616212c49db;hp=3d6fc27cbf1652f8b9117f4b060c6f4d8fe78e1e;hpb=f1f889940cf7353132fbe068da12c911886b5fed;p=Sone.git diff --git a/src/test/java/net/pterodactylus/sone/core/SoneParserTest.java b/src/test/java/net/pterodactylus/sone/core/SoneParserTest.java index 3d6fc27..19e5ae2 100644 --- a/src/test/java/net/pterodactylus/sone/core/SoneParserTest.java +++ b/src/test/java/net/pterodactylus/sone/core/SoneParserTest.java @@ -3,19 +3,29 @@ package net.pterodactylus.sone.core; import static com.google.common.base.Objects.equal; import static java.lang.String.format; import static java.util.logging.Level.OFF; -import static org.hamcrest.CoreMatchers.is; -import static org.hamcrest.CoreMatchers.notNullValue; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.containsInAnyOrder; +import static org.hamcrest.Matchers.empty; +import static org.hamcrest.Matchers.is; +import static org.hamcrest.Matchers.notNullValue; +import static org.hamcrest.Matchers.nullValue; import static org.hamcrest.collection.IsIterableContainingInOrder.contains; import static org.mockito.Matchers.anyString; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import java.io.InputStream; -import java.io.UnsupportedEncodingException; import java.util.logging.Logger; +import net.pterodactylus.sone.core.SoneParser.DuplicateField; +import net.pterodactylus.sone.core.SoneParser.InvalidAvatarId; +import net.pterodactylus.sone.core.SoneParser.InvalidParentAlbum; +import net.pterodactylus.sone.core.SoneParser.InvalidProtocolVersion; +import net.pterodactylus.sone.core.SoneParser.InvalidXml; +import net.pterodactylus.sone.core.SoneParser.MalformedDimension; +import net.pterodactylus.sone.core.SoneParser.MalformedTime; +import net.pterodactylus.sone.core.SoneParser.MalformedXml; +import net.pterodactylus.sone.core.SoneParser.SoneTooNew; import net.pterodactylus.sone.data.Client; import net.pterodactylus.sone.data.Image; import net.pterodactylus.sone.data.Post; @@ -53,90 +63,186 @@ public class SoneParserTest { when(core.getImage(anyString())).thenReturn(image); } - @Test - public void verifyThatAnInvalidXmlDocumentIsNotParsed() throws UnsupportedEncodingException { - Optional sone = soneParser.parseSone(database, originalSone, getXml("invalid-xml")); - assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(false)); + @Test(expected = InvalidXml.class) + public void verifyThatAnInvalidXmlDocumentIsNotParsed() { + soneParser.parseSone(database, originalSone, getXml("invalid-xml")); } @Test + public void verifyThatAMissingProtocolVersionDoesNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-protocol-version")); + } + + @Test(expected = InvalidProtocolVersion.class) public void verifyThatANegativeProtocolVersionCausesAnError() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("negative-protocol-version")); - assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(false)); + soneParser.parseSone(database, originalSone, getXml("negative-protocol-version")); } - @Test + @Test(expected = SoneTooNew.class) public void verifyThatATooLargeProtocolVersionCausesAnError() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("too-large-protocol-version")); - assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(false)); + soneParser.parseSone(database, originalSone, getXml("too-large-protocol-version")); } - @Test + @Test(expected = MalformedXml.class) public void verifyThatAMissingTimeCausesAnError() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("missing-time")); - assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(false)); + soneParser.parseSone(database, originalSone, getXml("missing-time")); + } + + @Test(expected = MalformedTime.class) + public void verifyThatAnInvalidTimeCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-time")); } @Test public void verifyThatAMissingClientCausesTheOriginalClientToBeUsed() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("missing-client")); + Sone sone = soneParser.parseSone(database, originalSone, getXml("missing-client")); assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(true)); - assertThat(sone.get().getClient(), notNullValue()); - assertThat(sone.get().getClient(), is(originalSone.getClient())); + assertThat(sone.getClient(), notNullValue()); + assertThat(sone.getClient(), is(originalSone.getClient())); } @Test public void verifyThatAnInvalidClientCausesTheOriginalClientToBeUsed() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("invalid-client")); + Sone sone = soneParser.parseSone(database, originalSone, getXml("invalid-client")); assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(true)); - assertThat(sone.get().getClient(), notNullValue()); - assertThat(sone.get().getClient(), is(originalSone.getClient())); + assertThat(sone.getClient(), notNullValue()); + assertThat(sone.getClient(), is(originalSone.getClient())); + } + + @Test(expected = MalformedXml.class) + public void verifyThatAMissingProfileCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-profile")); + } + + @Test(expected = MalformedXml.class) + public void verifyThatInvalidFieldsCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-field")); + } + + @Test(expected = DuplicateField.class) + public void verifyThatDuplicateFieldsCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("duplicate-field")); + } + + @Test(expected = InvalidAvatarId.class) + public void verifyThatAnInvalidAvatarIdCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-avatar")); + } + + @Test + public void verifyThatMissingPostsDoNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-posts")); + } + + @Test(expected = MalformedXml.class) + public void verifyThatInvalidPostsCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-posts")); + } + + @Test(expected = MalformedTime.class) + public void verifyThatAMalformedTimeCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-post-time")); + } + + @Test + public void verifyThatMissingRepliesDoNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-replies")); + } + + @Test(expected = MalformedXml.class) + public void verifyThatInvalidRepliesCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-replies")); + } + + @Test(expected = MalformedTime.class) + public void verifyThatAMalformedReplyTimeCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-reply-time")); + } + + @Test + public void verifyThatAMissingPostLikesSectionDoesNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-post-likes")); + } + + @Test + public void verifyThatAMissingReplyLikesSectionDoesNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-reply-likes")); + } + + @Test + public void verifyThatMissingAlbumsSectionDoNotCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("missing-albums")); + } + + @Test(expected = MalformedXml.class) + public void verifyThatAnInvalidAlbumCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-album")); + } + + @Test(expected = InvalidParentAlbum.class) + public void verifyThatAnInvalidParentAlbumCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-parent-album")); + } + + @Test(expected = MalformedXml.class) + public void verifyThatAnInvalidImageCausesAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-image")); + } + + @Test(expected = MalformedDimension.class) + public void verifyThatInvalidImageDimensionsCauseAnError() { + soneParser.parseSone(database, originalSone, getXml("invalid-image-dimensions")); + } + + @Test + public void verifyThatAnEmptyProfileIsParsedWithoutError() { + Sone sone = soneParser.parseSone(database, originalSone, getXml("empty-profile")); + assertThat(sone.getProfile().getFirstName(), nullValue()); + assertThat(sone.getProfile().getMiddleName(), nullValue()); + assertThat(sone.getProfile().getLastName(), nullValue()); + assertThat(sone.getProfile().getBirthYear(), nullValue()); + assertThat(sone.getProfile().getBirthMonth(), nullValue()); + assertThat(sone.getProfile().getBirthDay(), nullValue()); + assertThat(sone.getProfile().getAvatar(), nullValue()); + assertThat(sone.getProfile().getFields(), empty()); } @Test public void verifyThatTheCreatedSoneMeetsAllExpectations() { - Optional sone = soneParser.parseSone(database, originalSone, getXml("complete")); + Sone sone = soneParser.parseSone(database, originalSone, getXml("complete")); assertThat(sone, notNullValue()); - assertThat(sone.isPresent(), is(true)); - assertThat(sone.get().getTime(), is(1382419919000L)); - assertThat(sone.get().getClient(), notNullValue()); - assertThat(sone.get().getClient().getName(), is("Sone")); - assertThat(sone.get().getClient().getVersion(), is("0.8.7")); - assertThat(sone.get().getProfile(), notNullValue()); - assertThat(sone.get().getProfile().getFirstName(), is("First")); - assertThat(sone.get().getProfile().getMiddleName(), is("M.")); - assertThat(sone.get().getProfile().getLastName(), is("Last")); - assertThat(sone.get().getProfile().getBirthYear(), is(2013)); - assertThat(sone.get().getProfile().getBirthMonth(), is(10)); - assertThat(sone.get().getProfile().getBirthDay(), is(22)); - assertThat(sone.get().getProfile().getAvatar(), is("96431abe-3add-11e3-8a46-67047503bf6d")); - assertThat(sone.get().getProfile().getFields(), contains( + assertThat(sone.getTime(), is(1382419919000L)); + assertThat(sone.getClient(), notNullValue()); + assertThat(sone.getClient().getName(), is("Sone")); + assertThat(sone.getClient().getVersion(), is("0.8.7")); + assertThat(sone.getProfile(), notNullValue()); + assertThat(sone.getProfile().getFirstName(), is("First")); + assertThat(sone.getProfile().getMiddleName(), is("M.")); + assertThat(sone.getProfile().getLastName(), is("Last")); + assertThat(sone.getProfile().getBirthYear(), is(2013)); + assertThat(sone.getProfile().getBirthMonth(), is(10)); + assertThat(sone.getProfile().getBirthDay(), is(22)); + assertThat(sone.getProfile().getAvatar(), is("96431abe-3add-11e3-8a46-67047503bf6d")); + assertThat(sone.getProfile().getFields(), contains( fieldMatcher("Field1", "Value1"), fieldMatcher("Field2", "Value2") )); - assertThat(sone.get().getPosts(), contains( + assertThat(sone.getPosts(), contains( postMatcher("d8c9586e-3adb-11e3-bb31-171fc040e645", "0rpD4gL8mszav2trndhIdKIxvKUCNAe2kjA3dLV8CVU", 1382420181000L, "Hello, User!"), postMatcher("bbb7ebf0-3adb-11e3-8a0b-630cd8f21cf3", null, 1382420140000L, "Hello, World!") )); - assertThat(sone.get().getReplies(), containsInAnyOrder( + assertThat(sone.getReplies(), containsInAnyOrder( postReplyMatcher("f09fa448-3adb-11e3-a783-ab54a11aacc4", "bbb7ebf0-3adb-11e3-8a0b-630cd8f21cf3", 1382420224000L, "Talking to myself."), postReplyMatcher("0a376440-3adc-11e3-8f45-c7cc157436a5", "11ebe86e-3adc-11e3-b7b9-7f2c88018a33", 1382420271000L, "Talking to somebody I can't see.") )); - assertThat(sone.get().getLikedPostIds(), containsInAnyOrder( + assertThat(sone.getLikedPostIds(), containsInAnyOrder( "bbb7ebf0-3adb-11e3-8a0b-630cd8f21cf3", "305d85e6-3adc-11e3-be45-8b53dd91f0af" )); - assertThat(sone.get().getLikedReplyIds(), containsInAnyOrder( + assertThat(sone.getLikedReplyIds(), containsInAnyOrder( "f09fa448-3adb-11e3-a783-ab54a11aacc4", "3ba28960-3adc-11e3-93c7-6713d170f44c" )); - } private Matcher postReplyMatcher(final String id, final String postId, final long time, final String text) {