X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2FDeleteAlbumPageTest.kt;h=f2e7cc5c4956e5e41506921b13b3ade8ce9b1366;hb=a9c1c1770651720ec3b271464a4b490ea4a1334f;hp=fc6979794eb7cd360bb663be4aee818f2c1cea0f;hpb=5c8ad31fa8d083ca1c87f292e00bc7b21fbd85a5;p=Sone.git diff --git a/src/test/kotlin/net/pterodactylus/sone/web/DeleteAlbumPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/DeleteAlbumPageTest.kt index fc69797..f2e7cc5 100644 --- a/src/test/kotlin/net/pterodactylus/sone/web/DeleteAlbumPageTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/web/DeleteAlbumPageTest.kt @@ -4,7 +4,6 @@ import net.pterodactylus.sone.data.Album import net.pterodactylus.sone.data.Sone import net.pterodactylus.sone.test.mock import net.pterodactylus.sone.test.whenever -import net.pterodactylus.sone.web.WebTestUtils.redirectsTo import net.pterodactylus.util.web.Method.GET import net.pterodactylus.util.web.Method.POST import org.hamcrest.MatcherAssert.assertThat @@ -12,6 +11,7 @@ import org.hamcrest.Matchers.equalTo import org.junit.Before import org.junit.Test import org.mockito.ArgumentMatchers.anyString +import org.mockito.Mockito.verify /** * Unit test for [DeleteAlbumPage]. @@ -24,6 +24,8 @@ class DeleteAlbumPageTest : WebPageTest() { private val album = mock() private val parentAlbum = mock() + override fun getPage() = page + @Before fun setupAlbums() { whenever(sone.id).thenReturn("sone-id") @@ -39,8 +41,7 @@ class DeleteAlbumPageTest : WebPageTest() { fun `get request with invalid album ID results in redirect to invalid page`() { request("", GET) whenever(core.getAlbum(anyString())).thenReturn(null) - expectedException.expect(redirectsTo("invalid.html")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("invalid.html") } @Test @@ -56,8 +57,7 @@ class DeleteAlbumPageTest : WebPageTest() { @Test fun `post request redirects to invalid page if album is invalid`() { request("", POST) - expectedException.expect(redirectsTo("invalid.html")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("invalid.html") } @Test @@ -66,8 +66,7 @@ class DeleteAlbumPageTest : WebPageTest() { whenever(sone.isLocal).thenReturn(false) addAlbum("album-id", album) addHttpRequestParameter("album", "album-id") - expectedException.expect(redirectsTo("noPermission.html")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("noPermission.html") } @Test @@ -76,8 +75,7 @@ class DeleteAlbumPageTest : WebPageTest() { addAlbum("album-id", album) addHttpRequestParameter("album", "album-id") addHttpRequestParameter("abortDelete", "true") - expectedException.expect(redirectsTo("imageBrowser.html?album=album-id")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("imageBrowser.html?album=album-id") } @Test @@ -85,8 +83,9 @@ class DeleteAlbumPageTest : WebPageTest() { request("", POST) addAlbum("album-id", album) addHttpRequestParameter("album", "album-id") - expectedException.expect(redirectsTo("imageBrowser.html?sone=sone-id")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("imageBrowser.html?sone=sone-id") { + verify(core).deleteAlbum(album) + } } @Test @@ -95,8 +94,9 @@ class DeleteAlbumPageTest : WebPageTest() { whenever(sone.rootAlbum).thenReturn(mock()) addAlbum("album-id", album) addHttpRequestParameter("album", "album-id") - expectedException.expect(redirectsTo("imageBrowser.html?album=parent-id")) - page.handleRequest(freenetRequest, templateContext) + verifyRedirect("imageBrowser.html?album=parent-id") { + verify(core).deleteAlbum(album) + } } }