X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FEditImagePageTest.kt;h=ac710d58bda9b362b1912c13cf33ccb922d61d50;hb=2d2f89a8dc40e68ee4ce747074c4c518ac2b246f;hp=d36dec571d3c7cafdf32733d40c24f574c03f108;hpb=de7568a82eb4150bf6d2b0553841b7b69f84c968;p=Sone.git

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt
index d36dec5..ac710d5 100644
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt
@@ -3,14 +3,16 @@ package net.pterodactylus.sone.web.pages
 import net.pterodactylus.sone.data.Album
 import net.pterodactylus.sone.data.Image
 import net.pterodactylus.sone.data.Image.Modifier
+import net.pterodactylus.sone.data.Image.Modifier.ImageTitleMustNotBeEmpty
 import net.pterodactylus.sone.data.Sone
+import net.pterodactylus.sone.test.doThrow
 import net.pterodactylus.sone.test.mock
 import net.pterodactylus.sone.test.mockBuilder
 import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.sone.web.pages.EditImagePage
-import net.pterodactylus.sone.web.pages.WebPageTest
 import net.pterodactylus.util.web.Method.GET
 import net.pterodactylus.util.web.Method.POST
+import org.hamcrest.MatcherAssert.assertThat
+import org.hamcrest.Matchers.equalTo
 import org.junit.Before
 import org.junit.Test
 import org.mockito.Mockito.never
@@ -41,9 +43,25 @@ class EditImagePageTest : WebPageTest() {
 	}
 
 	@Test
+	fun `page returns correct path`() {
+		assertThat(page.path, equalTo("editImage.html"))
+	}
+
+	@Test
+	fun `page requires login`() {
+	    assertThat(page.requiresLogin(), equalTo(true))
+	}
+
+	@Test
+	fun `page returns correct title`() {
+		whenever(l10n.getString("Page.EditImage.Title")).thenReturn("edit image page title")
+	    assertThat(page.getPageTitle(freenetRequest), equalTo("edit image page title"))
+	}
+
+	@Test
 	fun `get request does not redirect`() {
 		request("", GET)
-		page.handleRequest(freenetRequest, templateContext)
+		page.processTemplate(freenetRequest, templateContext)
 	}
 
 	@Test
@@ -57,7 +75,7 @@ class EditImagePageTest : WebPageTest() {
 		request("", POST)
 		whenever(sone.isLocal).thenReturn(false)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
+		addHttpRequestPart("image", "image-id")
 		verifyRedirect("noPermission.html")
 	}
 
@@ -65,9 +83,9 @@ class EditImagePageTest : WebPageTest() {
 	fun `post request with valid image and move left requested moves image left and redirects to return page`() {
 		request("", POST)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
-		addHttpRequestParameter("returnPage", "return.html")
-		addHttpRequestParameter("moveLeft", "true")
+		addHttpRequestPart("image", "image-id")
+		addHttpRequestPart("returnPage", "return.html")
+		addHttpRequestPart("moveLeft", "true")
 		verifyRedirect("return.html") {
 			verify(album).moveImageUp(image)
 			verify(core).touchConfiguration()
@@ -78,9 +96,9 @@ class EditImagePageTest : WebPageTest() {
 	fun `post request with valid image and move right requested moves image right and redirects to return page`() {
 		request("", POST)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
-		addHttpRequestParameter("returnPage", "return.html")
-		addHttpRequestParameter("moveRight", "true")
+		addHttpRequestPart("image", "image-id")
+		addHttpRequestPart("returnPage", "return.html")
+		addHttpRequestPart("moveRight", "true")
 		verifyRedirect("return.html") {
 			verify(album).moveImageDown(image)
 			verify(core).touchConfiguration()
@@ -91,9 +109,10 @@ class EditImagePageTest : WebPageTest() {
 	fun `post request with valid image but only whitespace in the title redirects to empty image title page`() {
 		request("", POST)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
-		addHttpRequestParameter("returnPage", "return.html")
-		addHttpRequestParameter("title", "   ")
+		addHttpRequestPart("image", "image-id")
+		addHttpRequestPart("returnPage", "return.html")
+		addHttpRequestPart("title", "   ")
+		whenever(modifier.update()).doThrow<ImageTitleMustNotBeEmpty>()
 		verifyRedirect("emptyImageTitle.html") {
 			verify(core, never()).touchConfiguration()
 		}
@@ -103,10 +122,10 @@ class EditImagePageTest : WebPageTest() {
 	fun `post request with valid image title and description modifies image and redirects to reutrn page`() {
 		request("", POST)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
-		addHttpRequestParameter("returnPage", "return.html")
-		addHttpRequestParameter("title", "Title")
-		addHttpRequestParameter("description", "Description")
+		addHttpRequestPart("image", "image-id")
+		addHttpRequestPart("returnPage", "return.html")
+		addHttpRequestPart("title", "Title")
+		addHttpRequestPart("description", "Description")
 		verifyRedirect("return.html") {
 			verify(modifier).setTitle("Title")
 			verify(modifier).setDescription("Description")
@@ -116,14 +135,14 @@ class EditImagePageTest : WebPageTest() {
 	}
 
 	@Test
-	fun `post request with image title and description modifies image with filtered description and redirects to reutrn page`() {
+	fun `post request with image title and description modifies image with filtered description and redirects to return page`() {
 		request("", POST)
 		addImage("image-id", image)
-		addHttpRequestParameter("image", "image-id")
-		addHttpRequestParameter("returnPage", "return.html")
-		addHttpRequestParameter("title", "Title")
+		addHttpRequestPart("image", "image-id")
+		addHttpRequestPart("returnPage", "return.html")
+		addHttpRequestPart("title", "Title")
 		addHttpRequestHeader("Host", "www.te.st")
-		addHttpRequestParameter("description", "Get http://www.te.st/KSK@GPL.txt")
+		addHttpRequestPart("description", "Get http://www.te.st/KSK@GPL.txt")
 		verifyRedirect("return.html") {
 			verify(modifier).setTitle("Title")
 			verify(modifier).setDescription("Get KSK@GPL.txt")