X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fmodules%2Fmod_ffmpeg%2Ftrgt_ffmpeg.cpp;h=d2e85256811d75fc0719c9075cb945e81145e7e2;hb=4b886acca3929def466b0fb6a948bb5c37029190;hp=f663efb7e7863556bd35ba143fcdd04114262ed1;hpb=bb3d7752024191d641932add1df2add4c34fc83c;p=synfig.git diff --git a/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp b/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp index f663efb..d2e8525 100644 --- a/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp +++ b/synfig-core/trunk/src/modules/mod_ffmpeg/trgt_ffmpeg.cpp @@ -37,6 +37,7 @@ #include "trgt_ffmpeg.h" #include #include +#include #include #include #include @@ -62,6 +63,7 @@ SYNFIG_TARGET_SET_CVS_ID(ffmpeg_trgt,"$Id$"); ffmpeg_trgt::ffmpeg_trgt(const char *Filename) { + pid=-1; file=NULL; filename=Filename; multi_image=false; @@ -76,7 +78,9 @@ ffmpeg_trgt::~ffmpeg_trgt() { etl::yield(); sleep(1); - pclose(file); + fclose(file); + int status; + waitpid(pid,&status,0); } file=NULL; delete [] buffer; @@ -134,7 +138,7 @@ ffmpeg_trgt::init() return false; }; - pid_t pid = fork(); + pid = fork(); if (pid == -1) { synfig::error(_("Unable to open pipe to ffmpeg")); @@ -143,11 +147,15 @@ ffmpeg_trgt::init() if (pid == 0){ // Child process + // Close pipeout, not needed + close(p[1]); // Dup pipeout to stdin if( dup2( p[0], STDIN_FILENO ) == -1 ){ synfig::error(_("Unable to open pipe to ffmpeg")); return false; } + // Close the unneeded pipeout + close(p[0]); execlp("ffmpeg", "ffmpeg", "-f", "image2pipe", "-vcodec", "ppm", "-an", "-r", strprintf("%f", desc.get_frame_rate()).c_str(), "-i", "pipe:", "-loop", "-hq", "-title", get_canvas()->get_name().c_str(), "-vcodec", "mpeg1video", "-y", "--", filename.c_str(), (const char *)NULL); // We should never reach here unless the exec failed synfig::error(_("Unable to open pipe to ffmpeg"));