X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fmodules%2Fmod_imagemagick%2Fmptr_imagemagick.cpp;h=4bcf1f8695b021f298fad127c58ee5784ce85160;hb=63e709f66d50c124cc0ece2325f4773ac4ae7b20;hp=4d8a08cb3fd7f26549bfbef2f26d5297121891b2;hpb=aaa0275b0e9c8a981a01dad6d841c40e7d8d77c2;p=synfig.git

diff --git a/synfig-core/trunk/src/modules/mod_imagemagick/mptr_imagemagick.cpp b/synfig-core/trunk/src/modules/mod_imagemagick/mptr_imagemagick.cpp
index 4d8a08c..4bcf1f8 100644
--- a/synfig-core/trunk/src/modules/mod_imagemagick/mptr_imagemagick.cpp
+++ b/synfig-core/trunk/src/modules/mod_imagemagick/mptr_imagemagick.cpp
@@ -34,6 +34,20 @@
 #include <ETL/stringf>
 #include "mptr_imagemagick.h"
 #include <stdio.h>
+#include <sys/types.h>
+#if HAVE_SYS_WAIT_H
+ #include <sys/wait.h>
+#endif
+#if HAVE_IO_H
+ #include <io.h>
+#endif
+#if HAVE_PROCESS_H
+ #include <process.h>
+#endif
+#if HAVE_FCNTL_H
+ #include <fcntl.h>
+#endif
+#include <unistd.h>
 #include <algorithm>
 #include <functional>
 #include <ETL/stringf>
@@ -47,6 +61,12 @@ using namespace synfig;
 using namespace std;
 using namespace etl;
 
+#if defined(HAVE_FORK) && defined(HAVE_PIPE) && defined(HAVE_WAITPID)
+ #define UNIX_PIPE_TO_PROCESSES
+#elif defined(HAVE__SPAWNLP) && defined(HAVE__PIPE) && defined(HAVE_CWAIT)
+ #define WIN32_PIPE_TO_PROCESSES
+#endif
+
 /* === G L O B A L S ======================================================= */
 
 SYNFIG_IMPORTER_INIT(imagemagick_mptr);
@@ -77,11 +97,6 @@ imagemagick_mptr::get_frame(synfig::Surface &surface,Time /*time*/, synfig::Prog
 //#define HAS_LIBPNG 1
 
 #if 1
-	if(file)
-		pclose(file);
-
-	string command;
-
 	if(filename.empty())
 	{
 		if(cb)cb->error(_("No file to load"));
@@ -89,20 +104,43 @@ imagemagick_mptr::get_frame(synfig::Surface &surface,Time /*time*/, synfig::Prog
 		return false;
 	}
 	string temp_file="/tmp/deleteme.png";
+	string output="png32:"+temp_file;
+
+#if defined(WIN32_PIPE_TO_PROCESSES)
 
 	if(filename.find("psd")!=String::npos)
-		command=strprintf("convert \"%s\" -flatten \"png32:%s\"\n",filename.c_str(),temp_file.c_str());
+		_spawnlp(_P_WAIT, "convert", "convert", filename.c_str(), "-flatten", output.c_str(), (const char *)NULL);
 	else
-		command=strprintf("convert \"%s\" \"png32:%s\"\n",filename.c_str(),temp_file.c_str());
+		_spawnlp(_P_WAIT, "convert", "convert", filename.c_str(), output.c_str(), (const char *)NULL);
 
-	synfig::info("command=%s",command.c_str());
+#elif defined(UNIX_PIPE_TO_PROCESSES)
 
-	if(system(command.c_str())!=0)
+	pid_t pid = fork();
+  
+	if (pid == -1) {
 		return false;
+	}
+  
+	if (pid == 0){
+		// Child process
+		if(filename.find("psd")!=String::npos)
+			execlp("convert", "convert", filename.c_str(), "-flatten", output.c_str(), (const char *)NULL);
+		else
+			execlp("convert", "convert", filename.c_str(), output.c_str(), (const char *)NULL);
+		// We should never reach here unless the exec failed
+		return false;
+	}
 
-	Importer::Handle importer(Importer::open(temp_file));
+	int status;
+	waitpid(pid, &status, 0);
+	if( (WIFEXITED(status) && WEXITSTATUS(status) != 0) || !WIFEXITED(status) )
+		return false;
 
-	DEBUGPOINT();
+#else
+	#error There are no known APIs for creating child processes
+#endif
+
+	Importer::Handle importer(Importer::open(temp_file));
 
 	if(!importer)
 	{
@@ -111,8 +149,6 @@ imagemagick_mptr::get_frame(synfig::Surface &surface,Time /*time*/, synfig::Prog
 		return false;
 	}
 
-	DEBUGPOINT();
-
 	if(!importer->get_frame(surface,0,cb))
 	{
 		if(cb)cb->error(_("Unable to get frame from ")+temp_file);
@@ -153,12 +189,13 @@ imagemagick_mptr::get_frame(synfig::Surface &surface,Time /*time*/, synfig::Prog
 	Surface bleh(surface);
 	surface=bleh;
 
-
 	//remove(temp_file.c_str());
-	DEBUGPOINT();
 	return true;
 
 #else
+	
+#error This code contains tempfile and arbitrary shell command execution vulnerabilities
+	
 	if(file)
 		pclose(file);
 
@@ -173,7 +210,7 @@ imagemagick_mptr::get_frame(synfig::Surface &surface,Time /*time*/, synfig::Prog
 
 	command=strprintf("convert \"%s\" -flatten ppm:-\n",filename.c_str());
 
-	file=popen(command.c_str(),"rb");
+	file=popen(command.c_str(),POPEN_BINARY_READ_TYPE);
 
 	if(!file)
 	{