X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fsynfig%2Fcanvas.cpp;h=9322d79c683ea75cf12f692dec8ba76fb10fa11b;hb=dd3cfb8a9541bcd485836b75bc47ef032d0e65dc;hp=1d54730ef10acf5c93cdd545e3d29afa9777494c;hpb=37600b4b217caa5e316984ec0b035c5e8f9698af;p=synfig.git

diff --git a/synfig-core/trunk/src/synfig/canvas.cpp b/synfig-core/trunk/src/synfig/canvas.cpp
index 1d54730..9322d79 100644
--- a/synfig-core/trunk/src/synfig/canvas.cpp
+++ b/synfig-core/trunk/src/synfig/canvas.cpp
@@ -69,8 +69,9 @@ int _CanvasCounter::counter(0);
 
 /* === M E T H O D S ======================================================= */
 
-Canvas::Canvas(const string &id):
+Canvas::Canvas(const String &id):
 	id_			(id),
+	version_	(CURRENT_CANVAS_VERSION),
 	cur_time_	(0),
 	is_inline_	(false),
 	is_dirty_	(true),
@@ -734,7 +735,7 @@ Canvas::push_back_simple(etl::handle<Layer> x)
 }
 
 void
-Canvas::erase(Canvas::iterator iter)
+Canvas::erase(iterator iter)
 {
 	if(!(*iter)->get_group().empty())
 		remove_group_pair((*iter)->get_group(),(*iter));
@@ -769,7 +770,7 @@ Canvas::clone(const GUID& deriv_guid)const
 	{
 		name=get_id()+"_CLONE";
 
-		throw runtime_error("Cloning of non-inline canvases is not yet suported");
+		throw runtime_error("Cloning of non-inline canvases is not yet supported");
 	}
 
 	Handle canvas(new Canvas(name));
@@ -777,7 +778,11 @@ Canvas::clone(const GUID& deriv_guid)const
 	if(is_inline())
 	{
 		canvas->is_inline_=true;
-		canvas->parent_=0;
+		// \todo this was setting parent_=0 - is there a reason for that?
+		// this was causing bug 1838132, where cloning an inline canvas that contains an imported image fails
+		// it was failing to ascertain the absolute pathname of the imported image, since it needs the pathname
+		// of the canvas to get that, which is stored in the parent canvas
+		canvas->parent_=parent();
 		//canvas->set_inline(parent());
 	}
 
@@ -1013,6 +1018,11 @@ Canvas::get_meta_data_keys()const
 	return ret;
 }
 
+/* note - the "Motion Blur" and "Duplicate" layers need the dynamic
+		  parameters of any PasteCanvas layers they loop over to be
+		  maintained.  When the variables in the following function
+		  refer to "motion blur", they mean either of these two
+		  layers. */
 void
 synfig::optimize_layers(Context context, Canvas::Handle op_canvas, bool seen_motion_blur_in_parent)
 {
@@ -1041,7 +1051,7 @@ synfig::optimize_layers(Context context, Canvas::Handle op_canvas, bool seen_mot
 			if(value.get_type()==ValueBase::TYPE_REAL && value.get(Real())==0)
 				continue;
 
-			if(layer->get_name()=="MotionBlur")
+			if(layer->get_name()=="MotionBlur" || layer->get_name()=="duplicate")
 			{
 				float z_depth(layer->get_z_depth()*1.0001+i);
 
@@ -1254,13 +1264,13 @@ Canvas::remove_group_pair(String group, etl::handle<Layer> layer)
 }
 
 void
-Canvas::add_connection(Layer::LooseHandle layer, sigc::connection connection)
+Canvas::add_connection(etl::loose_handle<Layer> layer, sigc::connection connection)
 {
 	connections_[layer].push_back(connection);
 }
 
 void
-Canvas::disconnect_connections(Layer::LooseHandle layer)
+Canvas::disconnect_connections(etl::loose_handle<Layer> layer)
 {
 	std::vector<sigc::connection>::iterator iter;
 	for(iter=connections_[layer].begin();iter!=connections_[layer].end();++iter)