X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fsynfig%2Flayer_pastecanvas.cpp;h=572aee29f1d268f3dfbedb3fd6620b6f9985c83f;hb=337c51f149144c0844874ed20f71d780785c4127;hp=b161412a5c796ee718917ed30b42bf1e7523bee3;hpb=756c0d29ac1742f231e6615f9a577e574e35a4af;p=synfig.git

diff --git a/synfig-core/trunk/src/synfig/layer_pastecanvas.cpp b/synfig-core/trunk/src/synfig/layer_pastecanvas.cpp
index b161412..572aee2 100644
--- a/synfig-core/trunk/src/synfig/layer_pastecanvas.cpp
+++ b/synfig-core/trunk/src/synfig/layer_pastecanvas.cpp
@@ -144,6 +144,18 @@ Layer_PasteCanvas::get_param_vocab()const
 		.set_local_name(_("Children Lock"))
 	);
 
+	// optimize_layers() in canvas.cpp makes a new PasteCanvas layer
+	// and copies over the parameters of the old layer.  the
+	// 'curr_time' member wasn't being copied, so I've added it as a
+	// hidden, non critical parameter, and now it will be.  this
+	// allows a single exported subcanvas to be used more than once at
+	// a time, with different time offets in each.  see bug #1896557.
+	ret.push_back(ParamDesc("curr_time")
+		.set_local_name(_("Current Time"))
+		.not_critical()
+		.hidden()
+	);
+
 	return ret;
 }
 
@@ -159,7 +171,12 @@ Layer_PasteCanvas::set_param(const String & param, const ValueBase &value)
 		return true;
 	}
 
-	//! \todo this introduces bug 1844764 if enabled; it was introduced in r954, but I can't see if it's useful
+	//! \todo this introduces bug 1844764 if enabled; it was introduced in r954.
+	// http://synfig.org/images/3/3d/Moving-waypoints.sifz is an
+	// example of an animation that has its waypoints displayed
+	// incorrectly without this fix; select the outer layer and drag
+	// the time slider.  The linear waypoints don't take effect until
+	// 5s, but the time slider appears to pass the first one at 3s.
 #if 0
 	if (param=="time_offset" && value.same_type_as(time_offset))
 	{
@@ -178,6 +195,7 @@ Layer_PasteCanvas::set_param(const String & param, const ValueBase &value)
 
 	IMPORT(children_lock);
 	IMPORT(zoom);
+	IMPORT(curr_time);
 
 	return Layer_Composite::set_param(param,value);
 }
@@ -244,6 +262,7 @@ Layer_PasteCanvas::get_param(const String& param)const
 	EXPORT(zoom);
 	EXPORT(time_offset);
 	EXPORT(children_lock);
+	EXPORT(curr_time);
 
 	EXPORT_NAME();
 	EXPORT_VERSION();
@@ -317,9 +336,6 @@ Layer_PasteCanvas::accelerated_render(Context context,Surface *surface,int quali
 	if(!canvas || !get_amount())
 		return context.accelerated_render(surface,quality,renddesc,cb);
 
-	if(muck_with_time_ && curr_time!=Time::begin() && canvas->get_time()!=curr_time+time_offset)
-		canvas->set_time(curr_time+time_offset);
-
 	SuperCallback stageone(cb,0,4500,10000);
 	SuperCallback stagetwo(cb,4500,9000,10000);
 	SuperCallback stagethree(cb,9000,9999,10000);
@@ -339,6 +355,9 @@ Layer_PasteCanvas::accelerated_render(Context context,Surface *surface,int quali
 	else if (!context.accelerated_render(surface,quality,renddesc,&stageone))
 		return false;
 
+	if(muck_with_time_ && curr_time!=Time::begin() && canvas->get_time()!=curr_time+time_offset)
+		canvas->set_time(curr_time+time_offset);
+
 	Color::BlendMethod blend_method(get_blend_method());
 	const Rect full_bounding_rect(canvas->get_context().get_full_bounding_rect());