X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fsynfig%2Floadcanvas.cpp;h=433eeb006d520bffcea5fe581f6bd07c7e364e98;hb=4ba22fb51d97f1ecce04dcc5e40569a4354c1bae;hp=199a6096e32593d2e0be5eeb2389faf17c7b181e;hpb=63e709f66d50c124cc0ece2325f4773ac4ae7b20;p=synfig.git diff --git a/synfig-core/trunk/src/synfig/loadcanvas.cpp b/synfig-core/trunk/src/synfig/loadcanvas.cpp index 199a609..433eeb0 100644 --- a/synfig-core/trunk/src/synfig/loadcanvas.cpp +++ b/synfig-core/trunk/src/synfig/loadcanvas.cpp @@ -6,7 +6,7 @@ ** ** \legal ** Copyright (c) 2002-2005 Robert B. Quattlebaum Jr., Adrian Bentley -** Copyright (c) 2007 Chris Moore +** Copyright (c) 2007, 2008 Chris Moore ** ** This package is free software; you can redistribute it and/or ** modify it under the terms of the GNU General Public License as @@ -39,6 +39,7 @@ #include #include +#include "layer_pastecanvas.h" #include "loadcanvas.h" #include "valuenode.h" #include "valuenode_subtract.h" @@ -88,8 +89,12 @@ test_class test_class_instance; /* === M A C R O S ========================================================= */ +#define VALUENODE_COMPATIBILITY_URL "http://synfig.org/Convert#Compatibility" + inline bool is_whitespace(char x) { return ((x)=='\n' || (x)=='\t' || (x)==' '); } +std::set CanvasParser::loading_; + /* === P R O C E D U R E S ================================================= */ static std::map* open_canvas_map_(0); @@ -119,46 +124,50 @@ static void _canvas_file_name_changed(Canvas *x) } Canvas::Handle -synfig::open_canvas(const String &filename) +synfig::open_canvas(const String &filename,String &errors,String &warnings) { - CanvasParser parser; - - parser.set_allow_errors(true); - - Canvas::Handle canvas=parser.parse_from_file(filename); - - if(parser.error_count()) - return Canvas::Handle(); - - return canvas; + return open_canvas_as(filename, filename, errors, warnings); } Canvas::Handle -synfig::open_canvas_as(const String &filename,const String &as) +synfig::open_canvas_as(const String &filename,const String &as,String &errors,String &warnings) { - CanvasParser parser; - - parser.set_allow_errors(true); - - Canvas::Handle canvas=parser.parse_from_file_as(filename,as); - - if(parser.error_count()) - return Canvas::Handle(); - - return canvas; -} + if (CanvasParser::loading_.count(filename)) + { + String warning(strprintf(_("cannot load '%s' recursively"), filename.c_str())); + synfig::warning(warning); + warnings = " * " + warning + "\n"; + Canvas::Handle canvas(Canvas::create()); + canvas->set_file_name(filename); + Layer::Handle paste(Layer_PasteCanvas::create()); + canvas->push_back(paste); + paste->set_description(warning); + return canvas; + } -Canvas::Handle -synfig::string_to_canvas(const String &data) -{ + Canvas::Handle canvas; CanvasParser parser; - parser.set_allow_errors(true); - Canvas::Handle canvas=parser.parse_from_string(data); + try + { + CanvasParser::loading_.insert(filename); + canvas=parser.parse_from_file_as(filename,as,errors); + } + catch (...) + { + CanvasParser::loading_.erase(filename); + throw; + } + CanvasParser::loading_.erase(filename); + + warnings = parser.get_warnings_text(); if(parser.error_count()) + { + errors = parser.get_errors_text(); return Canvas::Handle(); + } return canvas; } @@ -180,10 +189,13 @@ CanvasParser::error_unexpected_element(xmlpp::Node *element,const String &got) void CanvasParser::warning(xmlpp::Node *element, const String &text) { - string str=strprintf("%s:<%s>:%d: warning: ",filename.c_str(),element->get_name().c_str(),element->get_line())+text; - //synfig::warning(str); - cerr<:%d: ",filename.c_str(),element->get_name().c_str(),element->get_line())+text; + + synfig::warning(str); + // cerr<=max_warnings_) fatal_error(element, _("Too many warnings")); } @@ -193,6 +205,7 @@ CanvasParser::error(xmlpp::Node *element, const String &text) { string str=strprintf("%s:<%s>:%d: error: ",filename.c_str(),element->get_name().c_str(),element->get_line())+text; total_errors_++; + errors_text += " * " + str + "\n"; if(!allow_errors_) throw runtime_error(str); cerr< // if (type==ValueBase::TYPE_CANVAS) - waypoint_value_node=ValueNode_Const::create(canvas->surefind_canvas(child->get_attribute("use")->get_value())); + { + String warnings; + waypoint_value_node=ValueNode_Const::create(canvas->surefind_canvas(child->get_attribute("use")->get_value(), warnings)); + warnings_text += warnings; + } else waypoint_value_node=canvas->surefind_value_node(child->get_attribute("use")->get_value()); } @@ -993,7 +1010,7 @@ CanvasParser::parse_animated(xmlpp::Element *element,Canvas::Handle canvas) if(child->get_attribute("temporal-tension")) { synfig::String str(child->get_attribute("temporal-tension")->get_value()); - waypoint->set_time_tension(atof(str.c_str())); + waypoint->set_temporal_tension(atof(str.c_str())); } if(child->get_attribute("continuity")) { @@ -1058,13 +1075,9 @@ CanvasParser::parse_animated(xmlpp::Element *element,Canvas::Handle canvas) // when loading a version 0.1 canvas, modify constant angle // waypoints to that they are within 180 degrees of the previous // waypoint's value - if (type == ValueBase::TYPE_ANGLE) + if (type == ValueBase::TYPE_ANGLE) { - Canvas::Handle parent = canvas; - while (!parent->is_root()) - parent = parent->parent(); - - if (parent->get_version() == "0.1") + if (canvas->get_version() == "0.1") { bool first = true; Real angle, prev = 0; @@ -1075,6 +1088,7 @@ CanvasParser::parse_animated(xmlpp::Element *element,Canvas::Handle canvas) if (first) first = false; else if (iter->get_value_node()->get_name() == "constant") + { if (angle - prev > 180) { while (angle - prev > 180) angle -= 360; @@ -1085,6 +1099,7 @@ CanvasParser::parse_animated(xmlpp::Element *element,Canvas::Handle canvas) while (prev - angle > 180) angle += 360; iter->set_value(Angle::deg(angle)); } + } prev = angle; } } @@ -1097,195 +1112,132 @@ CanvasParser::parse_animated(xmlpp::Element *element,Canvas::Handle canvas) etl::handle CanvasParser::parse_linkable_value_node(xmlpp::Element *element,Canvas::Handle canvas) { - handle value_node; - ValueBase::Type type; - // Determine the type - if(element->get_attribute("type")) + if(!element->get_attribute("type")) { - type=ValueBase::ident_type(element->get_attribute("type")->get_value()); - - if(!type) - { - error(element,"Bad type in ValueNode"); - return 0; - } + error(element, strprintf(_("Missing attribute \"type\" in <%s>"), element->get_name().c_str())); + return 0; } - else + + ValueBase::Type type=ValueBase::ident_type(element->get_attribute("type")->get_value()); + + if(!type) { - error(element,"Missing type in ValueNode"); + error(element, strprintf(_("Bad type in <%s>"), element->get_name().c_str())); return 0; } - value_node=LinkableValueNode::create(element->get_name(),type); + handle value_node=LinkableValueNode::create(element->get_name(),type); + handle c[value_node->link_count()]; if(!value_node) { - error(element,"Unknown ValueNode type "+element->get_name()); + error(element, strprintf(_("Error creating ValueNode <%s> with type '%s'. Refer to '%s'"), + element->get_name().c_str(), + ValueBase::type_local_name(type).c_str(), + VALUENODE_COMPATIBILITY_URL)); return 0; } if(value_node->get_type()!=type) { - error(element,"ValueNode did not accept type"); + error(element, strprintf(_("<%s> did not accept type '%s'"), + element->get_name().c_str(), + ValueBase::type_local_name(type).c_str())); return 0; } value_node->set_root_canvas(canvas->get_root()); - int i; - for(i=0;ilink_count();i++) + // handle exported valuenodes { - if(element->get_attribute(value_node->link_name(i))) - try { - String id(element->get_attribute(value_node->link_name(i))->get_value()); - - if(!value_node->set_link(i, - canvas->surefind_value_node( - id - ) - ) - ) error(element,strprintf(_("Unable to set link \"%s\" to ValueNode \"%s\" (link #%d in \"%s\")"),value_node->link_name(i).c_str(),id.c_str(),i,value_node->get_name().c_str())); - } - catch(Exception::IDNotFound) - { - error(element,"Unable to resolve "+element->get_attribute(value_node->link_name(i))->get_value()); - } - catch(Exception::FileNotFound) - { - error(element,"Unable to open file referenced in "+element->get_attribute(value_node->link_name(i))->get_value()); - } - catch(...) + int index; + String id, name; + xmlpp::Element::AttributeList attrib_list(element->get_attributes()); + for(xmlpp::Element::AttributeList::iterator iter = attrib_list.begin(); iter != attrib_list.end(); iter++) { - error(element,strprintf(_("Unknown Exception thrown when referencing ValueNode \"%s\""), - element->get_attribute(value_node->link_name(i))->get_value().c_str())); - throw; - } - } + name = (*iter)->get_name(); + id = (*iter)->get_value(); + if (name == "guid" || name == "id" || name == "type") + continue; + try { + index = value_node->get_link_index_from_name(name); - xmlpp::Element::NodeList list = element->get_children(); - for(xmlpp::Element::NodeList::iterator iter = list.begin(); iter != list.end(); ++iter) - { - xmlpp::Element *child(dynamic_cast(*iter)); - try - { - if(!child) - continue; - int index=value_node->get_link_index_from_name(child->get_name()); + if(c[index]) + { + error(element,strprintf(_("'%s' was already defined in <%s>"), + name.c_str(), + element->get_name().c_str())); + continue; + } - xmlpp::Element::NodeList list = child->get_children(); - xmlpp::Element::NodeList::iterator iter; + c[index] = canvas->surefind_value_node(id); - // Search for the first non-text XML element - for(iter = list.begin(); iter != list.end(); ++iter) - if(dynamic_cast(*iter)) break; + if (!c[index]) + { + error(element, strprintf(_("'%s' attribute in <%s> references unknown ID '%s'"), + name.c_str(), + element->get_name().c_str(), + id.c_str())); + continue; + } - if(iter==list.end()) + if(!value_node->set_link(index, c[index])) + { + error(element, strprintf(_("Unable to set link '\"%s\" to ValueNode \"%s\" (link #%d in \"%s\")"), + value_node->link_name(index).c_str(), + id.c_str(), + index, + element->get_name().c_str())); + continue; + } + + // printf(" <%s> set link %d (%s) using exported value\n", element->get_name().c_str(), index, name.c_str()); + } + catch (Exception::BadLinkName) { - error(child,_("element is missing its contents")); - continue; + warning(element, strprintf("Bad link name '%s'", name.c_str())); } - - ValueNode::Handle link=parse_value_node(dynamic_cast(*iter),canvas); - - if(!link) + catch(Exception::IDNotFound) { - error((*iter),"Parse of ValueNode failed"); + error(element,"Unable to resolve " + id); } - else - if(!value_node->set_link(index,link)) + catch(Exception::FileNotFound) { - //error(dynamic_cast(*iter),strprintf(_("Unable to connect value node ('%s' of type '%s') to link %d"),link->get_name().c_str(),ValueBase::type_local_name(link->get_type()).c_str(),index)); - error(element,strprintf(_("Unable to connect value node ('%s' of type '%s') to link %d"),link->get_name().c_str(),ValueBase::type_local_name(link->get_type()).c_str(),index)); + error(element,"Unable to open file referenced in " + id); } - - // \todo do a search for more elements and warn if they are found - - } - catch(Exception::BadLinkName) - { - error_unexpected_element(child,child->get_name()); - } - catch(...) - { - error(child,strprintf(_("Unknown Exception thrown when working on element \"%s\""),child->get_name().c_str())); - throw; - } - } - - return value_node; -} - -handle -CanvasParser::parse_composite(xmlpp::Element *element,Canvas::Handle canvas) -{ - assert(element->get_name()=="composite"); - - if(!element->get_attribute("type")) - { - error(element,"Missing attribute \"type\" in "); - return handle(); - } - - ValueBase::Type type=ValueBase::ident_type(element->get_attribute("type")->get_value()); - - if(!type) - { - error(element,"Bad type in "); - return handle(); - } - - handle value_node=ValueNode_Composite::create(type); - handle c[6]; - - if(!value_node) - { - error(element,strprintf(_("Unable to create "))); - return handle(); - } - - int i; - - for(i=0;ilink_count();i++) - { - string name=strprintf("c%d",i+1); - if(c[i]) - { - error(element,name+" was already defined in "); - continue; - } - if(element->get_attribute(name)) - { - c[i]=canvas->surefind_value_node(element->get_attribute(name)->get_value()); - if(c[i]) + catch(...) { - if(!value_node->set_link(i,c[i])) - { - error(element,'"'+name+"\" attribute in has bad type"); - } + error(element,strprintf(_("Unknown Exception thrown when referencing ValueNode \"%s\""), id.c_str())); + throw; } - else - error(element,'"'+name+"\" attribute in references unknown ID"); } } - xmlpp::Element::NodeList list = element->get_children(); - for(xmlpp::Element::NodeList::iterator iter = list.begin(); iter != list.end(); ++iter) + // handle inline valuenodes { - xmlpp::Element *child(dynamic_cast(*iter)); - if(!child) - continue; - else - for(i=0;ilink_count();i++) + int index; + String child_name; + xmlpp::Element::NodeList list = element->get_children(); + for(xmlpp::Element::NodeList::iterator iter = list.begin(); iter != list.end(); ++iter) { - string name=strprintf("c%d",i+1); - if(child->get_name()==name) + xmlpp::Element *child(dynamic_cast(*iter)); + try { - if(c[i]) + if(!child) + continue; + + child_name = child->get_name(); + + index = value_node->get_link_index_from_name(child_name); + + if(c[index]) { - error(child,name+" was already defined in "); + error(child, strprintf(_("'%s' was already defined in <%s>"), + child_name.c_str(), + element->get_name().c_str())); break; } @@ -1298,63 +1250,101 @@ CanvasParser::parse_composite(xmlpp::Element *element,Canvas::Handle canvas) if(iter==list.end()) { - error(child,strprintf(_("<%s> is missing its contents"),name.c_str())); - break; + error(child,strprintf(_("element <%s> is missing its contents"), + child_name.c_str())); + continue; } - c[i]=parse_value_node(dynamic_cast(*iter),canvas); + c[index]=parse_value_node(dynamic_cast(*iter),canvas); - if(!c[i]) + if(!c[index]) { - error((*iter),"Parse of "+name+" ValueNode failed"); - break; + error((*iter),strprintf(_("Parse of '%s' failed"), + child_name.c_str())); + continue; } - if(!value_node->set_link(i,c[i])) + if(!value_node->set_link(index,c[index])) { - error(child,strprintf(_("<%s> has a bad value"),name.c_str())); - break; + error(child,strprintf(_("Unable to connect value node ('%s' of type '%s') to link %d (%s)"), + c[index]->get_name().c_str(), + ValueBase::type_local_name(c[index]->get_type()).c_str(), + index, + value_node->link_name(index).c_str())); + continue; } // \todo do a search for more elements and warn if they are found - break; + + // printf(" <%s> set link %d (%s) using inline value\n", element->get_name().c_str(), index, child_name.c_str()); + } + catch(Exception::BadLinkName) + { + warning(child, strprintf("Bad link name for <%s>", element->get_name().c_str())); + } + catch(...) + { + error(child, strprintf(_("Unknown Exception thrown when working on element \"%s\""),child_name.c_str())); + throw; } } - // somewhat of a hack, but it works - if(i==value_node->link_count()) error_unexpected_element(child,child->get_name()); } - switch(value_node->link_count()) + String version(canvas->get_version()); + for (int i = 0; i < value_node->link_count(); i++) { - case 1: - if(!value_node->get_link(0)) - { - error(element," is missing parameters"); - return handle(); - } - break; - case 2: - if(!value_node->get_link(0) ||!value_node->get_link(1)) + if (!c[i]) { - error(element," is missing parameters"); - return handle(); - } - break; - case 3: - if(!value_node->get_link(0) ||!value_node->get_link(1) ||!value_node->get_link(2)) - { - error(element," is missing parameters"); - return handle(); + // the 'width' parameter of wasn't always present in version 0.1 canvases + if (version == "0.1" && element->get_name() == "stripes" && value_node->link_name(i) == "width") + continue; + + // these 3 blinecalctangent parameters didn't appear until canvas version 0.5 + if ((version == "0.1" || version == "0.2" || version == "0.3" || version == "0.4") && + element->get_name() == "blinecalctangent" && + (value_node->link_name(i) == "offset" || + value_node->link_name(i) == "scale" || + value_node->link_name(i) == "fixed_length")) + continue; + + // 'scale' was added while canvas version 0.5 was in use + if ((version == "0.3" || version == "0.4" || version == "0.5") && + element->get_name() == "blinecalcwidth" && + value_node->link_name(i) == "scale") + continue; + + // 'loop' was added while canvas version 0.5 was in use, as was the 'gradientcolor' node type + if (version == "0.5" && + element->get_name() == "gradientcolor" && + value_node->link_name(i) == "loop") + continue; + + // 'loop' was added while canvas version 0.6 was in use; the 'random' node was added back when 0.1 was in use + if ((version == "0.1" || version == "0.2" || version == "0.3" || version == "0.4" || version == "0.5" || version == "0.6") && + element->get_name() == "random" && + value_node->link_name(i) == "loop") + continue; + + error(element, strprintf(_("<%s> is missing link %d (%s)"), + element->get_name().c_str(), + i, + value_node->link_name(i).c_str())); + return 0; } - break; - case 4: - if(!value_node->get_link(0) ||!value_node->get_link(1) ||!value_node->get_link(2) ||!value_node->get_link(3)) + } + + // pre 0.4 canvases had *calctangent outputs scaled down by 0.5 for some reason + if (element->get_name() == "blinecalctangent" || element->get_name() == "segcalctangent") + { + if (version == "0.1" || version == "0.2" || version == "0.3") { - error(element," is missing parameters"); - return handle(); + handle scale_value_node=LinkableValueNode::create("scale",type); + scale_value_node->set_link(scale_value_node->get_link_index_from_name("link"), value_node); + scale_value_node->set_link(scale_value_node->get_link_index_from_name("scalar"), ValueNode_Const::create(Real(0.5))); + value_node = scale_value_node; } - break; - } + } + return value_node; } @@ -1611,9 +1601,6 @@ CanvasParser::parse_value_node(xmlpp::Element *element,Canvas::Handle canvas) if(element->get_name()=="hermite" || element->get_name()=="animated") value_node=parse_animated(element,canvas); else - if(element->get_name()=="composite") - value_node=parse_composite(element,canvas); - else if(element->get_name()=="dynamic_list") value_node=parse_dynamic_list(element,canvas); else @@ -1621,21 +1608,23 @@ CanvasParser::parse_value_node(xmlpp::Element *element,Canvas::Handle canvas) value_node=parse_dynamic_list(element,canvas); else if(LinkableValueNode::book().count(element->get_name())) + { value_node=parse_linkable_value_node(element,canvas); + if (!value_node) value_node = PlaceholderValueNode::create(); + } else if(element->get_name()=="canvas") value_node=ValueNode_Const::create(parse_canvas(element,canvas,true)); else { error_unexpected_element(element,element->get_name()); - error(element, "Expected a ValueNode"); + error(element, strprintf(_("Expected a ValueNode. Refer to '%s'"), + VALUENODE_COMPATIBILITY_URL)); value_node=PlaceholderValueNode::create(); } - value_node->set_root_canvas(canvas->get_root()); - // If we were successful, and our element has // an ID attribute, go ahead and add it to the // value_node list @@ -1751,6 +1740,11 @@ CanvasParser::parse_layer(xmlpp::Element *element,Canvas::Handle canvas) String param_name=child->get_attribute("name")->get_value(); + // SVN r2013 and r2014 renamed all 'pos' and 'offset' parameters to 'origin' + // 'pos' and 'offset' will appear in old .sif files; handle them correctly + if (param_name == "pos" || param_name == "offset") + param_name = "origin"; + if(child->get_attribute("use")) { // If the "use" attribute is used, then the @@ -1761,9 +1755,15 @@ CanvasParser::parse_layer(xmlpp::Element *element,Canvas::Handle canvas) String str= child->get_attribute("use")->get_value(); - if(layer->get_param(param_name).get_type()==ValueBase::TYPE_CANVAS) + if (str.empty()) + error(child,_("Empty use=\"\" value in ")); + else if(layer->get_param(param_name).get_type()==ValueBase::TYPE_CANVAS) { - if(!layer->set_param(param_name,canvas->surefind_canvas(str))) + String warnings; + Canvas::Handle c(canvas->surefind_canvas(str, warnings)); + warnings_text += warnings; + if(!c) error((*iter),strprintf(_("Failed to load subcanvas '%s'"), str.c_str())); + if(!layer->set_param(param_name,c)) error((*iter),_("Layer rejected canvas link")); } else @@ -1772,6 +1772,12 @@ CanvasParser::parse_layer(xmlpp::Element *element,Canvas::Handle canvas) handle value_node=canvas->surefind_value_node(str); // Assign the value_node to the dynamic parameter list + if (param_name == "segment_list" && (layer->get_name() == "region" || layer->get_name() == "outline")) + { + synfig::warning("%s: Updated valuenode connection to use the \"bline\" parameter instead of \"segment_list\".", + layer->get_name().c_str()); + param_name = "bline"; + } layer->connect_dynamic_param(param_name,value_node); } catch(Exception::IDNotFound) @@ -1812,7 +1818,9 @@ CanvasParser::parse_layer(xmlpp::Element *element,Canvas::Handle canvas) // the layer liked it if(!layer->set_param(param_name,data)) { - warning((*iter),_("Layer rejected value for ")); + warning((*iter),strprintf(_("Layer '%s' rejected value for parameter '%s'"), + element->get_attribute("type")->get_value().c_str(), + param_name.c_str())); continue; } } @@ -1867,7 +1875,9 @@ CanvasParser::parse_canvas(xmlpp::Element *element,Canvas::Handle parent,bool in { try { - canvas=parent->find_canvas(element->get_attribute("id")->get_value()); + String warnings; + canvas=parent->find_canvas(element->get_attribute("id")->get_value(), warnings); + warnings_text += warnings; } catch(...) { @@ -1897,12 +1907,24 @@ CanvasParser::parse_canvas(xmlpp::Element *element,Canvas::Handle parent,bool in if(element->get_attribute("version")) canvas->set_version(element->get_attribute("version")->get_value()); + else if(parent) + canvas->set_version(parent->get_version()); if(element->get_attribute("width")) - canvas->rend_desc().set_w(atoi(element->get_attribute("width")->get_value().c_str())); + { + int width = atoi(element->get_attribute("width")->get_value().c_str()); + if (width < 1) + fatal_error(element, _("Canvas with width or height less than one is not allowed")); + canvas->rend_desc().set_w(width); + } if(element->get_attribute("height")) - canvas->rend_desc().set_h(atoi(element->get_attribute("height")->get_value().c_str())); + { + int height = atoi(element->get_attribute("height")->get_value().c_str()); + if (height < 1) + fatal_error(element, _("Canvas with width or height less than one is not allowed")); + canvas->rend_desc().set_h(height); + } if(element->get_attribute("xres")) canvas->rend_desc().set_x_res(atof(element->get_attribute("xres")->get_value().c_str())); @@ -2104,21 +2126,41 @@ CanvasParser::parse_canvas(xmlpp::Element *element,Canvas::Handle parent,bool in return canvas; } -Canvas::Handle -CanvasParser::parse_from_file(const String &file) +void +CanvasParser::register_canvas_in_map(Canvas::Handle canvas, String as) +{ + get_open_canvas_map()[etl::absolute_path(as)]=canvas; + canvas->signal_deleted().connect(sigc::bind(sigc::ptr_fun(_remove_from_open_canvas_map),canvas.get())); + canvas->signal_file_name_changed().connect(sigc::bind(sigc::ptr_fun(_canvas_file_name_changed),canvas.get())); +} + +#ifdef _DEBUG +void +CanvasParser::show_canvas_map(String file, int line, String text) { - return parse_from_file_as(file,file); + return; + printf(" .-----\n | %s:%d %s\n", file.c_str(), line, text.c_str()); + std::map > canvas_map(synfig::get_open_canvas_map()); + std::map >::iterator iter; + for (iter = canvas_map.begin(); iter != canvas_map.end(); iter++) + { + synfig::String first(iter->first); + etl::loose_handle second(iter->second); + printf(" | %40s : %lx (%d)\n", first.c_str(), ulong(&*second), second->count()); + } + printf(" `-----\n\n"); } +#endif // _DEBUG Canvas::Handle -CanvasParser::parse_from_file_as(const String &file_,const String &as_) +CanvasParser::parse_from_file_as(const String &file_,const String &as_,String &errors) { + ChangeLocale change_locale(LC_NUMERIC, "C"); + String file(unix_to_local_path(file_)); + String as(unix_to_local_path(as_)); + try { - ChangeLocale change_locale(LC_NUMERIC, "C"); - String file(unix_to_local_path(file_)); - String as(unix_to_local_path(as_)); - if(get_open_canvas_map().count(etl::absolute_path(as))) return get_open_canvas_map()[etl::absolute_path(as)]; @@ -2128,11 +2170,8 @@ CanvasParser::parse_from_file_as(const String &file_,const String &as_) if(parser) { Canvas::Handle canvas(parse_canvas(parser.get_document()->get_root_node(),0,false,as)); - get_open_canvas_map()[etl::absolute_path(as)]=canvas; - canvas->signal_deleted().connect(sigc::bind(sigc::ptr_fun(_remove_from_open_canvas_map),canvas.get())); - canvas->signal_file_name_changed().connect(sigc::bind(sigc::ptr_fun(_canvas_file_name_changed),canvas.get())); - - + if (!canvas) return canvas; + register_canvas_in_map(canvas, as); const ValueNodeList& value_node_list(canvas->value_node_list()); @@ -2156,67 +2195,23 @@ CanvasParser::parse_from_file_as(const String &file_,const String &as_) catch(Exception::FileNotFound) { synfig::error("FileNotFound Thrown"); } catch(Exception::IDNotFound) { synfig::error("IDNotFound Thrown"); } catch(Exception::IDAlreadyExists) { synfig::error("IDAlreadyExists Thrown"); } - catch(const std::exception& ex) + catch(xmlpp::internal_error x) { - synfig::error("Standard Exception: "+String(ex.what())); - return Canvas::Handle(); + if (!strcmp(x.what(), "Couldn't create parsing context")) + throw runtime_error(String(" * ") + _("Can't open file") + " \"" + file + "\""); + throw; } - catch(const String& str) - { - cerr<"); - total_warnings_=0; - xmlpp::DomParser parser; - parser.parse_memory(data); - xmlpp::Element *root=parser.get_document()->get_root_node(); - if(parser) - { - Canvas::Handle canvas(parse_canvas(root)); - canvas->signal_deleted().connect(sigc::bind(sigc::ptr_fun(_remove_from_open_canvas_map),canvas.get())); - canvas->signal_file_name_changed().connect(sigc::bind(sigc::ptr_fun(_canvas_file_name_changed),canvas.get())); - - const ValueNodeList& value_node_list(canvas->value_node_list()); - again: - ValueNodeList::const_iterator iter; - for(iter=value_node_list.begin();iter!=value_node_list.end();++iter) - { - ValueNode::Handle value_node(*iter); - if(value_node->is_exported() && value_node->get_id().find("Unnamed")==0) - { - canvas->remove_value_node(value_node); - goto again; - } - } - - return canvas; - } - } - catch(Exception::BadLinkName) { synfig::error("BadLinkName Thrown"); } - catch(Exception::BadType) { synfig::error("BadType Thrown"); } - catch(Exception::FileNotFound) { synfig::error("FileNotFound Thrown"); } - catch(Exception::IDNotFound) { synfig::error("IDNotFound Thrown"); } - catch(Exception::IDAlreadyExists) { synfig::error("IDAlreadyExists Thrown"); } catch(const std::exception& ex) { synfig::error("Standard Exception: "+String(ex.what())); + errors = ex.what(); return Canvas::Handle(); } catch(const String& str) { cerr<