X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-core%2Ftrunk%2Fsrc%2Fsynfig%2Fvaluenode_composite.cpp;h=e5c6e7120d1c6c9ac439a6c6a1e66b61f93b0b2d;hb=933391e568dac0fa4409875800a331d219fe9b59;hp=e29b37875560bee47e192251341af7157919b9c4;hpb=e8a065f2385c219c511b57dac52786120bfa097d;p=synfig.git

diff --git a/synfig-core/trunk/src/synfig/valuenode_composite.cpp b/synfig-core/trunk/src/synfig/valuenode_composite.cpp
index e29b378..e5c6e71 100644
--- a/synfig-core/trunk/src/synfig/valuenode_composite.cpp
+++ b/synfig-core/trunk/src/synfig/valuenode_composite.cpp
@@ -1,8 +1,8 @@
 /* === S Y N F I G ========================================================= */
 /*!	\file valuenode_composite.cpp
-**	\brief Template File
+**	\brief Implementation of the "Composite" valuenode conversion.
 **
-**	$Id: valuenode_composite.cpp,v 1.1.1.1 2005/01/04 01:23:15 darco Exp $
+**	$Id$
 **
 **	\legal
 **	Copyright (c) 2002-2005 Robert B. Quattlebaum Jr., Adrian Bentley
@@ -37,6 +37,7 @@
 #include "vector.h"
 #include "color.h"
 #include "segment.h"
+#include "savecanvas.h"
 
 #endif
 
@@ -88,7 +89,7 @@ synfig::ValueNode_Composite::ValueNode_Composite(const ValueBase &value):
 		}
 		default:
 			assert(0);
-			throw Exception::BadType(ValueBase::type_name(get_type()));			
+			throw Exception::BadType(ValueBase::type_local_name(get_type()));
 	}
 }
 
@@ -102,7 +103,7 @@ ValueNode_Composite::create(const ValueBase &value)
 {
 	return new ValueNode_Composite(value);
 }
-	
+
 LinkableValueNode*
 ValueNode_Composite::create_new()const
 {
@@ -184,9 +185,8 @@ ValueNode_Composite::link_count()const
 bool
 ValueNode_Composite::set_link_vfunc(int i,ValueNode::Handle x)
 {
-	assert(i>=0);
-	assert(i<6);
-	
+	assert(i>=0 && i<link_count());
+
 	if(PlaceholderValueNode::Handle::cast_dynamic(x))
 	{
 		components[i]=x;
@@ -196,7 +196,6 @@ ValueNode_Composite::set_link_vfunc(int i,ValueNode::Handle x)
 	switch(get_type())
 	{
 		case ValueBase::TYPE_VECTOR:
-			assert(i<2);
 			if(x->get_type()==ValueBase(Real()).get_type() || PlaceholderValueNode::Handle::cast_dynamic(x))
 			{
 				components[i]=x;
@@ -205,16 +204,14 @@ ValueNode_Composite::set_link_vfunc(int i,ValueNode::Handle x)
 			break;
 
 		case ValueBase::TYPE_COLOR:
-			assert(i<4);
 			if(x->get_type()==ValueBase(Real()).get_type() || PlaceholderValueNode::Handle::cast_dynamic(x))
 			{
 				components[i]=x;
 				return true;
 			}
 			break;
-			
+
 		case ValueBase::TYPE_SEGMENT:
-			assert(i<4);
 			if(x->get_type()==ValueBase(Point()).get_type() || PlaceholderValueNode::Handle::cast_dynamic(x))
 			{
 				components[i]=x;
@@ -223,7 +220,6 @@ ValueNode_Composite::set_link_vfunc(int i,ValueNode::Handle x)
 			break;
 
 		case ValueBase::TYPE_BLINEPOINT:
-			assert(i<6);
 			if((i==0 || i==4 || i==5) && x->get_type()==ValueBase(Point()).get_type())
 			{
 				components[i]=x;
@@ -240,24 +236,26 @@ ValueNode_Composite::set_link_vfunc(int i,ValueNode::Handle x)
 				return true;
 			}
 			break;
-			
+
 		default:
 			break;
 	}
-	return false;	
+	return false;
 }
 
 ValueNode::LooseHandle
 ValueNode_Composite::get_link_vfunc(int i)const
 {
-	assert(i>=0 && i<6);
+	assert(i>=0 && i<link_count());
+
 	return components[i];
 }
 
 String
 ValueNode_Composite::link_local_name(int i)const
 {
-	assert(i>=0 && i<6);
+	assert(i>=0 && i<link_count());
+
 	switch(get_type())
 	{
 		case ValueBase::TYPE_VECTOR:
@@ -272,7 +270,7 @@ ValueNode_Composite::link_local_name(int i)const
 				return _("Blue");
 			else if(i==3)
 				return _("Alpha");
-			
+
 		case ValueBase::TYPE_SEGMENT:
 			if(i==0)
 				return _("Vertex 1");
@@ -298,18 +296,71 @@ ValueNode_Composite::link_local_name(int i)const
 				return _("Tangent 2");
 
 		default:
-			break;
+			assert(0);
+			// notice that Composite counts from 1 and Radial Composite counts
+			// from 0!  we need to keep it like that to correctly load old
+			// animations, but let's not save "c%d" format link names in future
+			return etl::strprintf(_("C%d"),i+1);
 	}
-	return etl::strprintf(_("C%d"),i+1);	
-}	
+}
 
 
 String
 ValueNode_Composite::link_name(int i)const
 {
-	assert(i>=0 && i<5);
-	return strprintf("c%d",i);
-}	
+	assert(i>=0 && i<link_count());
+
+	if (get_file_version() < RELEASE_VERSION_0_61_08)
+		return strprintf("c%d",i+1);
+
+	switch(get_type())
+	{
+	case ValueBase::TYPE_COLOR:
+		switch(i)
+		{
+		case 0: return "red";
+		case 1: return "green";
+		case 2: return "blue";
+		case 3: return "alpha";
+		}
+		break;
+	case ValueBase::TYPE_SEGMENT:
+		switch(i)
+		{
+		case 0: return "p1";
+		case 1: return "t1";
+		case 2: return "p2";
+		case 3: return "t2";
+		}
+		break;
+	case ValueBase::TYPE_VECTOR:
+		switch(i)
+		{
+		case 0: return "x";
+		case 1: return "y";
+		}
+		break;
+	case ValueBase::TYPE_BLINEPOINT:
+		switch(i)
+		{
+		case 0: return "point";
+		case 1: return "width";
+		case 2: return "origin";
+		case 3: return "split";
+		case 4: return "t1";
+		case 5: return "t2";
+		}
+		break;
+	default:
+		break;
+	}
+
+	assert(0);
+	// notice that Composite counts from 1 and Radial Composite counts
+	// from 0!  we need to keep it like that to correctly load old
+	// animations, but let's not save "c%d" format link names in future
+	return strprintf("c%d",i+1);
+}
 
 int
 ValueNode_Composite::get_link_index_from_name(const String &name)const
@@ -317,8 +368,8 @@ ValueNode_Composite::get_link_index_from_name(const String &name)const
 	if(name.empty())
 		throw Exception::BadLinkName(name);
 
-	if(name[0]=='c')
-		return name[1]-'0';
+	if(name[0]=='c' && name.size() == 2 && name[1]-'1' >= 0 && name[1]-'1' < link_count())
+		return name[1]-'1';
 
 	switch(get_type())
 	{
@@ -345,7 +396,7 @@ ValueNode_Composite::get_link_index_from_name(const String &name)const
 			return 0;
 		if(name[0]=='y')
 			return 1;
-		if(name[0]=='z')
+		if(name[0]=='z')		// \todo "z"?  really?
 			return 2;
 	case ValueBase::TYPE_BLINEPOINT:
 		if(name[0]=='p' || name=="v1" || name=="p1")
@@ -360,7 +411,7 @@ ValueNode_Composite::get_link_index_from_name(const String &name)const
 			return 4;
 		if(name=="t2")
 			return 5;
-	default:			
+	default:
 		break;
 	}