X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-studio%2Ftrunk%2Fsrc%2Fgtkmm%2Fdockdialog.cpp;h=1a9a6e47a9a17ea935bafcbfb88eb2fc3d290622;hb=37600b4b217caa5e316984ec0b035c5e8f9698af;hp=6a6e3ebde00459c5c4a1a6c2c210cf28b743b192;hpb=ce408de81ca266b1f334ee9bc6c8fb7ba1492ed4;p=synfig.git diff --git a/synfig-studio/trunk/src/gtkmm/dockdialog.cpp b/synfig-studio/trunk/src/gtkmm/dockdialog.cpp index 6a6e3eb..1a9a6e4 100644 --- a/synfig-studio/trunk/src/gtkmm/dockdialog.cpp +++ b/synfig-studio/trunk/src/gtkmm/dockdialog.cpp @@ -2,10 +2,11 @@ /*! \file dockdialog.cpp ** \brief Template File ** -** $Id: dockdialog.cpp,v 1.1.1.1 2005/01/07 03:34:36 darco Exp $ +** $Id$ ** ** \legal ** Copyright (c) 2002-2005 Robert B. Quattlebaum Jr., Adrian Bentley +** Copyright (c) 2007 Chris Moore ** ** This package is free software; you can redistribute it and/or ** modify it under the terms of the GNU General Public License as @@ -35,6 +36,7 @@ #include "dockdialog.h" #include "dockbook.h" #include "dockmanager.h" +#include "toolbox.h" #include "widget_compselect.h" #include #include @@ -83,12 +85,12 @@ DockDialog::DockDialog(): is_horizontal=false; last_dock_book=0; box=0; - + widget_comp_select=new Widget_CompSelect(); - + // Give ourselves an ID that is most likely unique - set_id(synfig::UniqueID().get_uid()^reinterpret_cast(this)); - + set_id(synfig::UniqueID().get_uid()^reinterpret_cast(this)); + set_role(strprintf("dock_dialog_%d",get_id())); GRAB_HINT_DATA( "dock_dialog", @@ -98,24 +100,29 @@ DockDialog::DockDialog(): Gdk::WINDOW_TYPE_HINT_UTILITY #endif ); - set_keep_below(true); set_keep_above(false); - + + //! \todo can we set dialog windows transient for all normal windows, not just the toolbox? + //! paragraph 3 of http://standards.freedesktop.org/wm-spec/1.3/ar01s07.html suggests we can + // this seems to have bad effects on KDE, so leave it disabled by default + if(getenv("SYNFIG_TRANSIENT_DIALOGS")) + set_transient_for(*App::toolbox); + // Set up the window //set_type_hint(Gdk::WINDOW_TYPE_HINT_UTILITY); set_title("Dock Dialog"); - + // Register with the dock manager App::dock_manager->dock_dialog_list_.push_back(this); - - // connect our signals + + // connect our signals signal_delete_event().connect( sigc::hide( sigc::mem_fun(*this,&DockDialog::close) ) ); - + /* App::signal_canvas_view_focus().connect( sigc::hide( @@ -128,7 +135,7 @@ DockDialog::DockDialog(): */ add_accel_group(App::ui_manager()->get_accel_group()); - App::signal_present_all().connect(sigc::mem_fun(*this,&DockDialog::present)); + App::signal_present_all().connect(sigc::mem_fun0(*this,&DockDialog::present)); } @@ -138,24 +145,28 @@ DockDialog::~DockDialog() is_deleting=true; - DEBUGPOINT(); - // Remove all of the dock books for(;!dock_book_list.empty();dock_book_list.pop_front()) { dock_book_list.front()->clear(); - // UGLY HACK + //! \fixme: UGLY HACK // The following line really should be uncommented, // but it causes crashes. Without it, a small // memory hole is created--but at least it doesn't crash // delete dock_book_list.front(); - + // Oddly enough, the following line should // theoreticly do the same thing after this // class is destroyed, but it doesn't seem to - // caues a crash. - manage(dock_book_list.front()); + // cause a crash. It does, however, trigger this warning: + // + // A floating object was finalized. This means that someone + // called g_object_unref() on an object that had only a + // floating reference; the initial floating reference is not + // owned by anyone and must be removed with g_object_ref_sink(). + // + // manage(dock_book_list.front()); } // Remove us from the dock manager @@ -174,8 +185,6 @@ DockDialog::~DockDialog() } delete widget_comp_select; - - DEBUGPOINT(); } void @@ -188,7 +197,7 @@ DockDialog::drop_on_prepend(const Glib::RefPtr& context, int, context->drag_finish(true, false, time); return; } - + context->drag_finish(false, false, time); } @@ -202,7 +211,7 @@ DockDialog::drop_on_append(const Glib::RefPtr& context, int, i context->drag_finish(true, false, time); return; } - + context->drag_finish(false, false, time); } @@ -218,7 +227,7 @@ DockBook* DockDialog::prepend_dock_book() { if(is_deleting)return 0; - + dock_book_list.push_front(new DockBook); last_dock_book=dock_book_list.front(); @@ -239,7 +248,7 @@ DockBook* DockDialog::append_dock_book() { if(is_deleting)return 0; - + dock_book_list.push_back(new DockBook); last_dock_book=dock_book_list.back(); last_dock_book->signal_empty().connect( @@ -283,9 +292,9 @@ DockDialog::erase_dock_book(DockBook* dock_book) if(last_dock_book==dock_book) last_dock_book=dock_book_list.front(); } - + refresh(); - + return; } } @@ -293,21 +302,21 @@ DockDialog::erase_dock_book(DockBook* dock_book) void DockDialog::refresh() { - synfig::info("dock_book_list.size()=%d",dock_book_list.size()); + // synfig::info("dock_book_list.size()=%d",dock_book_list.size()); //remove(); if(dock_book_list.empty()) return; - + if(box)delete box; box=(manage(is_horizontal?(Gtk::Box*)new Gtk::HBox:(Gtk::Box*)new Gtk::VBox)); add(*box); - + box->pack_start(*widget_comp_select,false,true); Gtk::Button* append_button(manage(new Gtk::Button)); Gtk::Button* prepend_button(manage(new Gtk::Button)); - + std::list listTargets; listTargets.push_back( Gtk::TargetEntry("DOCK") ); @@ -321,14 +330,14 @@ DockDialog::refresh() prepend_button->signal_drag_data_received().connect( sigc::mem_fun(*this,&DockDialog::drop_on_prepend) ); - + box->pack_start(*prepend_button,false,true); box->pack_end(*append_button,false,true); //prepend_button->show(); //append_button->show(); pannels_.clear(); - + if(dock_book_list.size()==1) { box->pack_start(get_dock_book(),true,true); @@ -336,9 +345,9 @@ DockDialog::refresh() else { Gtk::Paned* parent(manage(is_horizontal?(Gtk::Paned*)new Gtk::HPaned:(Gtk::Paned*)new Gtk::VPaned)); - + pannels_.push_back(parent); - + if(pannels_.size()<=dock_book_sizes_.size()) pannels_.back()->set_position(dock_book_sizes_[pannels_.size()-1]); pannels_.back()->property_position().signal_changed().connect( @@ -347,15 +356,15 @@ DockDialog::refresh() //parent->show(); parent->add1(*dock_book_list.front()); //dock_book_list.front()->show(); - + box->pack_start(*parent,true,true); - + std::list::iterator iter,next; for(next=dock_book_list.begin(),next++,iter=next++;next!=dock_book_list.end();iter=next++) { Gtk::Paned* current(manage(is_horizontal?(Gtk::Paned*)new Gtk::HPaned:(Gtk::Paned*)new Gtk::VPaned)); pannels_.push_back(current); - + if(pannels_.size()<=dock_book_sizes_.size()) pannels_.back()->set_position(dock_book_sizes_[pannels_.size()-1]); pannels_.back()->property_position().signal_changed().connect( @@ -368,13 +377,13 @@ DockDialog::refresh() current->add1(**iter); //(*iter)->show(); //current->show(); - + parent=current; } parent->add2(**iter); //(*iter)->show(); } - + box->show_all(); if(!composition_selector_) widget_comp_select->hide(); @@ -414,7 +423,7 @@ DockDialog::refresh_accel_group() remove_accel_group(last_accel_group_); last_accel_group_=Glib::RefPtr(); } - + etl::loose_handle canvas_view(App::get_selected_canvas_view()); if(canvas_view) { @@ -436,7 +445,7 @@ DockDialog::close() synfig::info("DockDialog::close(): DELETED!"); empty_sig.disconnect(); //get_dock_book().clear(); - delete this; + delete this; return true; } @@ -467,8 +476,8 @@ DockDialog::get_contents()const ret+=is_horizontal?" | ":" - "; ret+=(*iter)->get_contents(); } - - + + return ret; } @@ -481,9 +490,9 @@ DockDialog::set_contents(const synfig::String& z) synfig::String str(z); while(!str.empty()) { - unsigned int separator=str.find_first_of('-'); + synfig::String::size_type separator=str.find_first_of('-'); { - unsigned int sep2=str.find_first_of('|'); + synfig::String::size_type sep2=str.find_first_of('|'); if(separator!=synfig::String::npos || sep2!=synfig::String::npos) { if((separator==synfig::String::npos || sep2set_contents(book_contents);