X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-studio%2Ftrunk%2Fsrc%2Fgtkmm%2Fwidget_timeslider.cpp;h=ba57435b73e90be3afd0f84cd2fbc1752c8d9d7a;hb=4ba22fb51d97f1ecce04dcc5e40569a4354c1bae;hp=7352bd21691df582f95b433ebaeebbab937426d8;hpb=051b4cc4caa46c84dedd7a5d7aa80259f225ae6e;p=synfig.git

diff --git a/synfig-studio/trunk/src/gtkmm/widget_timeslider.cpp b/synfig-studio/trunk/src/gtkmm/widget_timeslider.cpp
index 7352bd2..ba57435 100644
--- a/synfig-studio/trunk/src/gtkmm/widget_timeslider.cpp
+++ b/synfig-studio/trunk/src/gtkmm/widget_timeslider.cpp
@@ -6,7 +6,7 @@
 **
 **	\legal
 **	Copyright (c) 2004 Adrian Bentley
-**	Copyright (c) 2007 Chris Moore
+**	Copyright (c) 2007, 2008 Chris Moore
 **
 **	This package is free software; you can redistribute it and/or
 **	modify it under the terms of the GNU General Public License as
@@ -505,12 +505,30 @@ bool Widget_Timeslider::redraw(bool /*doublebuffer*/)
 		iter = next;
 
 	scale = *iter;
-	if (iter != ranges.begin()) iter--;
-	if (iter != ranges.begin()) iter--;
-	if (iter != ranges.begin()) iter--;
 
 	// subdivide into this many tick marks (8 or less)
-	const int subdiv = round_to_int(scale / *iter);
+	int subdiv = round_to_int(scale * ifps);
+
+	if (subdiv > 8)
+	{
+		const int ideal = subdiv;
+
+		// find a number of tick marks that nicely divides the scale
+		// (5 minutes divided by 6 is 50s, but that's not 'nice' -
+		//  5 ticks of 1m each is much simpler than 6 ticks of 50s)
+		for (subdiv = 8; subdiv > 0; subdiv--)
+			if ((ideal <= ifps*2       && (ideal % (subdiv           )) == 0) ||
+				(ideal <= ifps*2*60    && (ideal % (subdiv*ifps      )) == 0) ||
+				(ideal <= ifps*2*60*60 && (ideal % (subdiv*ifps*60   )) == 0) ||
+				(true                  && (ideal % (subdiv*ifps*60*60)) == 0))
+				break;
+
+		// if we didn't find anything, use 4 ticks
+		if (!subdiv)
+			subdiv = 4;
+	}
+
+	time_per_tickmark = scale / subdiv;
 
 	//get first valid line and its position in pixel space
 	double time = 0;
@@ -531,6 +549,7 @@ bool Widget_Timeslider::redraw(bool /*doublebuffer*/)
 		double t = (time/scale - floor(time/scale))*subdiv; // the difference from the big mark in 0:1
 		//sdindex = (int)floor(t + 0.5); //get how far through the range it is...
 		sdindex = round_to_int(t); //get how far through the range it is...
+		if (sdindex == subdiv) sdindex = 0;
 
 		//synfig::info("Extracted fr %.2lf -> %d", t, sdindex);
 	}
@@ -703,50 +722,80 @@ bool Widget_Timeslider::on_scroll_event(GdkEventScroll* event) //for zooming
 
 	//we want to zoom in on the time value if control is held down
 	if(Gdk::ModifierType(event->state) & Gdk::CONTROL_MASK)
-	{
 		center = true;
-	}
 
 	switch(event->direction)
 	{
 		case GDK_SCROLL_UP: //zoom in
-		{
 			zoom_in(center);
-
 			return true;
-		}
+
 		case GDK_SCROLL_DOWN: //zoom out
-		{
 			zoom_out(center);
-
 			return true;
-		}
-		
+
 		case GDK_SCROLL_RIGHT:
 		case GDK_SCROLL_LEFT:
-		{	
+		{
 			double t = adj_timescale->get_value();
+			double orig_t = t;
 			double start = adj_timescale->get_lower();
 			double end = adj_timescale->get_upper();
-			/*
-			FIXME: be more intelligent about how far to scroll
-			Perhaps it should be based on the tickmarks?
-			for e.g. 1/4 of a tick mark per scroll event
-			Obviously this  would need post-rounding to 1/fps
-			*/
-			double adj = 1.0/fps;
+			double lower = adj_bounds->get_lower();
+			double upper = adj_bounds->get_upper();
+			double adj = time_per_tickmark;
 
 			if( event->direction == GDK_SCROLL_RIGHT )
+			{
+				// step forward one tick
 				t += adj;
+
+				// don't go past the end of time
+				if (t > upper)
+					t = upper;
+
+				// if we are already in the right half of the slider
+				if ((t-start)*2 > (end-start))
+				{
+					// if we can't scroll the background left one whole tick, scroll it to the end
+					if (end > upper - (t-orig_t))
+					{
+						adj_timescale->set_lower(upper - (end-start));
+						adj_timescale->set_upper(upper);
+					}
+					// else scroll the background left
+					else
+					{
+						adj_timescale->set_lower(start + (t-orig_t));
+						adj_timescale->set_upper(start + (t-orig_t) + (end-start));
+					}
+				}
+			}
 			else
+			{
+				// step backwards one tick
 				t -= adj;
 
-			if( t < start ){
-				adj_timescale->set_lower(t);
-				adj_timescale->set_upper(t+end-start);
-			} else if( t > end ){ 
-				adj_timescale->set_upper(t);
-				adj_timescale->set_lower(t-end+start);
+				// don't go past the start of time
+				if (t < lower)
+					t = lower;
+
+				// if we are already in the left half of the slider
+				if ((t-start)*2 < (end-start))
+				{
+					// if we can't scroll the background right one whole tick, scroll it to the beginning
+					if (start < lower + (orig_t-t))
+					{
+						adj_timescale->set_lower(lower);
+						adj_timescale->set_upper(lower + (end-start));
+					}
+					// else scroll the background right
+					else
+					{
+						adj_timescale->set_lower(start - (orig_t-t));
+						adj_timescale->set_upper(start - (orig_t-t) + (end-start));
+					}
+				}
 			}
 
 			if(adj_timescale)
@@ -756,11 +805,8 @@ bool Widget_Timeslider::on_scroll_event(GdkEventScroll* event) //for zooming
 			}
 			return true;
 		}
-		
 		default:
-		{
 			return false;
-		}
 	}
 }