X-Git-Url: https://git.pterodactylus.net/?a=blobdiff_plain;f=synfig-studio%2Ftrunk%2Fsrc%2Fsynfigapp%2Factions%2Fvaluedescdisconnect.cpp;h=c703b6d4ff76777f207b66d727e5b023fc3e31f5;hb=38fa994c9fad50c17527608839d08643b663832b;hp=bb94e8fa46a3972c634d9a478cabbc18b2111938;hpb=8ef042c40521681cea99944097c4f90a5ac6cf74;p=synfig.git

diff --git a/synfig-studio/trunk/src/synfigapp/actions/valuedescdisconnect.cpp b/synfig-studio/trunk/src/synfigapp/actions/valuedescdisconnect.cpp
index bb94e8f..c703b6d 100644
--- a/synfig-studio/trunk/src/synfigapp/actions/valuedescdisconnect.cpp
+++ b/synfig-studio/trunk/src/synfigapp/actions/valuedescdisconnect.cpp
@@ -36,6 +36,7 @@
 #include "valuedescdisconnect.h"
 #include <synfigapp/canvasinterface.h>
 #include <synfig/valuenode_const.h>
+#include <synfig/valuenode_duplicate.h>
 
 #include <synfigapp/general.h>
 
@@ -49,7 +50,7 @@ using namespace Action;
 
 /* === M A C R O S ========================================================= */
 
-ACTION_INIT(Action::ValueDescDisconnect);
+ACTION_INIT_NO_GET_LOCAL_NAME(Action::ValueDescDisconnect);
 ACTION_SET_NAME(Action::ValueDescDisconnect,"value_desc_disconnect");
 ACTION_SET_LOCAL_NAME(Action::ValueDescDisconnect,N_("Disconnect"));
 ACTION_SET_TASK(Action::ValueDescDisconnect,"disconnect");
@@ -69,6 +70,16 @@ Action::ValueDescDisconnect::ValueDescDisconnect():
 {
 }
 
+synfig::String
+Action::ValueDescDisconnect::get_local_name()const
+{
+  // TRANSLATORS: This is used in the History dialog when a ValueNode is disconnected.
+  return strprintf(_("Disconnect %s"),
+                   value_desc
+                   ? value_desc.get_description().c_str()
+                   : _("ValueDesc"));
+}
+
 Action::ParamVocab
 Action::ValueDescDisconnect::get_param_vocab()
 {
@@ -92,12 +103,22 @@ Action::ValueDescDisconnect::is_candidate(const ParamList &x)
 	if(candidate_check(get_param_vocab(),x))
 	{
 		ValueDesc value_desc(x.find("value_desc")->second.get_value_desc());
+
+		// don't allow the Index parameter of the Duplicate layer to be disconnected
+		if(value_desc.parent_is_layer_param() && value_desc.get_layer()->get_name() == "duplicate" && value_desc.get_param_name() == "index")
+			return false;
 		if(!value_desc.parent_is_canvas() && value_desc.is_value_node() && value_desc.get_value_node()->rcount()>1)
 			return true;
 		if(value_desc.is_const())
 			return false;
 		if(value_desc.is_value_node() && ValueNode_Const::Handle::cast_dynamic(value_desc.get_value_node()))
 			return false;
+		// don't allow Duplicate ValueNodes in the Children dialog to be disconnected
+		if(value_desc.is_value_node() &&
+		   ValueNode_Duplicate::Handle::cast_dynamic(value_desc.get_value_node()) &&
+		   !value_desc.parent_is_layer_param() &&
+		   !value_desc.parent_is_value_node())
+			return false;
 		return true;
 	}
 	return false;