Add method to include short description in config data
authorDavid ‘Bombe’ Roden <bombe@freenetproject.org>
Tue, 14 Jul 2015 20:12:13 +0000 (22:12 +0200)
committerDavid ‘Bombe’ Roden <bombe@freenetproject.org>
Tue, 14 Jul 2015 20:12:13 +0000 (22:12 +0200)
src/main/java/net/pterodactylus/fcp/quelaton/GetConfigCommand.java
src/main/java/net/pterodactylus/fcp/quelaton/GetConfigCommandImpl.java
src/test/java/net/pterodactylus/fcp/quelaton/DefaultFcpClientTest.java

index 89afb67..a886cdc 100644 (file)
@@ -14,5 +14,6 @@ public interface GetConfigCommand extends Executable<ConfigData> {
        GetConfigCommand withSortOrder();
        GetConfigCommand withExpertFlag();
        GetConfigCommand withForceWriteFlag();
+       GetConfigCommand withShortDescription();
 
 }
index e35fdec..1a8ffd8 100644 (file)
@@ -27,6 +27,7 @@ public class GetConfigCommandImpl implements GetConfigCommand {
        private final AtomicBoolean withSortOrder = new AtomicBoolean();
        private final AtomicBoolean withExpertFlag = new AtomicBoolean();
        private final AtomicBoolean withForceWriteFlag = new AtomicBoolean();
+       private final AtomicBoolean withShortDescription = new AtomicBoolean();
 
        public GetConfigCommandImpl(ExecutorService threadPool, ConnectionSupplier connectionSupplier) {
                this.threadPool = MoreExecutors.listeningDecorator(threadPool);
@@ -64,6 +65,12 @@ public class GetConfigCommandImpl implements GetConfigCommand {
        }
 
        @Override
+       public GetConfigCommand withShortDescription() {
+               withShortDescription.set(true);
+               return this;
+       }
+
+       @Override
        public ListenableFuture<ConfigData> execute() {
                return threadPool.submit(this::executeDialog);
        }
@@ -75,6 +82,7 @@ public class GetConfigCommandImpl implements GetConfigCommand {
                getConfig.setWithSortOrder(withSortOrder.get());
                getConfig.setWithExpertFlag(withExpertFlag.get());
                getConfig.setWithForceWriteFlag(withForceWriteFlag.get());
+               getConfig.setWithShortDescription(withShortDescription.get());
                try (GetConfigDialog getConfigDialog = new GetConfigDialog()) {
                        return getConfigDialog.send(getConfig).get();
                }
index 6604bb1..e181fca 100644 (file)
@@ -1898,4 +1898,26 @@ public class DefaultFcpClientTest {
                assertThat(configData.get().getForceWriteFlag("foo"), is(true));
        }
 
+       @Test
+       public void defaultFcpClientCanGetConfigWithShortDescription()
+       throws InterruptedException, ExecutionException, IOException {
+               Future<ConfigData> configData = fcpClient.getConfig().withShortDescription().execute();
+               connectNode();
+               List<String> lines = fcpServer.collectUntil(is("EndMessage"));
+               String identifier = extractIdentifier(lines);
+               assertThat(lines, matchesFcpMessage(
+                       "GetConfig",
+                       "Identifier=" + identifier,
+                       "WithShortDescription=true",
+                       "EndMessage"
+               ));
+               fcpServer.writeLine(
+                       "ConfigData",
+                       "Identifier=" + identifier,
+                       "shortDescription.foo=bar",
+                       "EndMessage"
+               );
+               assertThat(configData.get().getShortDescription("foo"), is("bar"));
+       }
+
 }