From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Sun, 6 Apr 2025 06:15:12 +0000 (+0200)
Subject: 🔥 Remove event that was never used
X-Git-Url: https://git.pterodactylus.net/?a=commitdiff_plain;h=34fbc64ae1330cfce8e4dbfbba1bc6742421dd0d;p=Sone.git

🔥 Remove event that was never used
---

diff --git a/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt b/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt
deleted file mode 100644
index 2ebb62d..0000000
--- a/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt
+++ /dev/null
@@ -1,3 +0,0 @@
-package net.pterodactylus.sone.core
-
-data class PreferenceChangedEvent(val preferenceName: String, val newValue: Any)
diff --git a/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt b/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt
index e573185..314d66a 100644
--- a/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt
+++ b/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt
@@ -44,7 +44,6 @@ class DefaultPreferences(private val eventBus: EventBus) {
 		set(value) {
 			_insertionDelay.set(value)
 			eventBus.post(InsertionDelayChangedEvent(insertionDelay))
-			eventBus.post(PreferenceChangedEvent("InsertionDelay", insertionDelay))
 		}
 
 	private val _postsPerPage = DefaultOption(10) { it in 1..MAX_VALUE }
@@ -53,7 +52,6 @@ class DefaultPreferences(private val eventBus: EventBus) {
 		get() = unsupported
 		set(value) {
 			_postsPerPage.set(value)
-			eventBus.post(PreferenceChangedEvent("PostsPerPage", postsPerPage))
 		}
 
 	private val _imagesPerPage = DefaultOption(9) { it in 1..MAX_VALUE }
diff --git a/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt b/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt
index 62c5990..37a845a 100644
--- a/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt
@@ -285,16 +285,6 @@ class DefaultPreferencesTest {
 	}
 
 	@Test
-	fun `setting insertion delay to valid value sends change event`() {
-		testPreferencesChangedEvent("InsertionDelay", { preferences.newInsertionDelay = it }, 30)
-	}
-
-	@Test
-	fun `setting posts per page to valid value sends change event`() {
-		testPreferencesChangedEvent("PostsPerPage", { preferences.newPostsPerPage = it }, 31)
-	}
-
-	@Test
 	fun `default strict filtering is false`() {
 		assertThat(preferences.strictFiltering, equalTo(false))
 	}
@@ -357,15 +347,4 @@ class DefaultPreferencesTest {
 		assertThat(getter(configuration), matcher)
 	}
 
-	private fun <T : Any> testPreferencesChangedEvent(name: String, setter: (T) -> Unit, value: T) {
-		val events = mutableListOf<PreferenceChangedEvent>()
-		eventBus.register(object {
-			@Subscribe
-			fun preferenceChanged(event: PreferenceChangedEvent) =
-					events.add(event)
-		})
-		setter(value)
-		assertThat(events, hasItem(PreferenceChangedEvent(name, value)))
-	}
-
 }