From: David ‘Bombe’ Roden <bombe@freenetproject.org>
Date: Mon, 19 Jan 2026 20:49:00 +0000 (+0100)
Subject: ✅ Add test for getProperty()
X-Git-Url: https://git.pterodactylus.net/?a=commitdiff_plain;h=5d5fd89dba407f06760f64193991a4bebd7a76e1;p=jFCPlib.git

✅ Add test for getProperty()
---

diff --git a/src/test/java/net/pterodactylus/fcp/plugin/WebOfTrustPluginTest.java b/src/test/java/net/pterodactylus/fcp/plugin/WebOfTrustPluginTest.java
index fe92b48..5e73b73 100644
--- a/src/test/java/net/pterodactylus/fcp/plugin/WebOfTrustPluginTest.java
+++ b/src/test/java/net/pterodactylus/fcp/plugin/WebOfTrustPluginTest.java
@@ -701,6 +701,46 @@ public class WebOfTrustPluginTest {
 
 	}
 
+	public static class GetPropertyTests extends Common {
+
+		@Test
+		public void getPropertySendsTheCorrectCommand() throws Exception {
+			TestFcpConnection fcpConnection = createConnectionThatSendsPropertyValue();
+			WebOfTrustPlugin webOfTrustPlugin = createWebOfTrustPlugin(fcpConnection);
+			webOfTrustPlugin.getProperty(ownIdentity, "SomeProperty");
+			assertThat(fcpConnection.sentMessages.get(0), allOf(
+					isNamed(equalTo("FCPPluginMessage")),
+					hasField("Identifier", notNullValue()),
+					hasField("PluginName", equalTo("plugins.WebOfTrust.WebOfTrust")),
+					hasField("Param.Message", equalTo("GetProperty")),
+					hasField("Param.Identity", equalTo("own-id")),
+					hasField("Param.Property", equalTo("SomeProperty"))
+			));
+		}
+
+		@Test
+		public void getPropertyReturnsTheCorrectValue() throws Exception {
+			TestFcpConnection fcpConnection = createConnectionThatSendsPropertyValue();
+			WebOfTrustPlugin webOfTrustPlugin = createWebOfTrustPlugin(fcpConnection);
+			String value = webOfTrustPlugin.getProperty(ownIdentity, "SomeProperty");
+			assertThat(value, equalTo("SomeValue"));
+		}
+
+		@Test
+		public void getPropertyThrowsExceptionWhenDifferentReplyIsSentByPlugin() {
+			FcpConnection fcpConnection = createConnectionThatSendsOtherMessage();
+			WebOfTrustPlugin webOfTrustPlugin = createWebOfTrustPlugin(fcpConnection);
+			assertThrows(FcpException.class, () -> webOfTrustPlugin.getProperty(ownIdentity, "SomeProperty"));
+		}
+
+		private TestFcpConnection createConnectionThatSendsPropertyValue() {
+			return createConnection("PropertyValue", entries("Property", "SomeValue"));
+		}
+
+		private final OwnIdentity ownIdentity = new OwnIdentity("own-id", "Own ID", "or", "ir", emptyList(), emptyMap());
+
+	}
+
 	private static class Common {
 
 		@SafeVarargs