From: David ‘Bombe’ Roden <bombe@freenetproject.org>
Date: Sat, 23 Nov 2024 00:12:01 +0000 (+0100)
Subject: ✅ Add test for GetFailed being used in getRequests()
X-Git-Url: https://git.pterodactylus.net/?a=commitdiff_plain;h=6806381cc322d3668ddb6c465b3c1f11b7fd1639;p=jFCPlib.git

✅ Add test for GetFailed being used in getRequests()
---

diff --git a/src/test/java/net/pterodactylus/fcp/highlevel/FcpClientTest.java b/src/test/java/net/pterodactylus/fcp/highlevel/FcpClientTest.java
index d71fc3c..75c540b 100644
--- a/src/test/java/net/pterodactylus/fcp/highlevel/FcpClientTest.java
+++ b/src/test/java/net/pterodactylus/fcp/highlevel/FcpClientTest.java
@@ -712,6 +712,49 @@ public class FcpClientTest {
 		);
 	}
 
+	@Test
+	public void getGetRequestIsCompleteAndFailedWhenGetFailedMessageIsReceived() throws Exception {
+		FcpConnection fcpConnection = createFcpConnectionReactingToSingleMessage(named("ListPersistentRequests"), sendRequests(this::sendRequests, this::sendGetFailed));
+		try (FcpClient fcpClient = new FcpClient(fcpConnection)) {
+			Collection<Request> requests = fcpClient.getGetRequests(false);
+			assertThat(requests, contains(isGetRequest(
+					equalTo("get1"),
+					matches("complete", Request::isComplete),
+					matches("failed", Request::hasFailed),
+					matches("fatal", Request::isFatal),
+					matches("error code", m -> m.getErrorCode() == 123)
+			)));
+		}
+	}
+
+	@Test
+	public void getRequestIgnoresGetFailedForUnknownIdentifier() throws Exception {
+		FcpConnection fcpConnection = createFcpConnectionReactingToSingleMessage(named("ListPersistentRequests"), sendRequests(this::sendRequests, this::sendGetFailedForUnknownIdentifier));
+		try (FcpClient fcpClient = new FcpClient(fcpConnection)) {
+			Collection<Request> requests = fcpClient.getRequests(true);
+			assertThat(requests, containsInAnyOrder(
+					isRequest(equalTo("get1"), matches("complete", m -> !m.isComplete())),
+					isRequest(equalTo("get1-global"), matches("complete", m -> !m.isComplete())),
+					isRequest(equalTo("put1"), matches("complete", m -> !m.isComplete())),
+					isRequest(equalTo("put1-global"), matches("complete", m -> !m.isComplete())),
+					isRequest(equalTo("put2"), matches("complete", m -> !m.isComplete())),
+					isRequest(equalTo("put2-global"), matches("complete", m -> !m.isComplete()))
+			));
+		}
+	}
+
+	private void sendGetFailed(FcpListener listener, FcpConnection connection) {
+		listener.receivedGetFailed(connection, new GetFailed(
+				new FcpMessage("GetFailed").put("Identifier", "get1").put("Fatal", "true").put("Code", "123"))
+		);
+	}
+
+	private void sendGetFailedForUnknownIdentifier(FcpListener listener, FcpConnection connection) {
+		listener.receivedGetFailed(connection, new GetFailed(
+				new FcpMessage("GetFailed").put("Identifier", "unknown"))
+		);
+	}
+
 	private void sendRequests(FcpListener listener, FcpConnection connection) {
 		listener.receivedPersistentGet(connection, new PersistentGet(new FcpMessage("PersistentGet").put("Identifier", "get1").put("Global", "false")));
 		listener.receivedPersistentPut(connection, new PersistentPut(new FcpMessage("PersistentPut").put("Identifier", "put1").put("Global", "false")));