From: David ‘Bombe’ Roden <bombe@freenetproject.org>
Date: Fri, 3 Jan 2025 21:36:08 +0000 (+0100)
Subject: 🗑️ Deprecate ReloadPlugin constructor without plugin name
X-Git-Url: https://git.pterodactylus.net/?a=commitdiff_plain;h=98674ba5829cf0dd016fd2cc75f6e545c1dd4063;p=jFCPlib.git

🗑️ Deprecate ReloadPlugin constructor without plugin name
---

diff --git a/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java b/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java
index 6aedeaa..d3d2f67 100644
--- a/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java
+++ b/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java
@@ -24,11 +24,31 @@ package net.pterodactylus.fcp;
  */
 public class ReloadPlugin extends FcpMessage {
 
+	/**
+	 * @deprecated Use {@link #ReloadPlugin(String, String)} instead
+	 */
+	@Deprecated
 	public ReloadPlugin(String identifier) {
 		super("ReloadPlugin");
 		setField("Identifier", identifier);
 	}
 
+	/**
+	 * Creates a new “ReloadPlugin” message.
+	 *
+	 * @param identifier The identifier of the message
+	 * @param pluginName The name of the plugin to reload
+	 */
+	public ReloadPlugin(String identifier, String pluginName) {
+		super("ReloadPlugin");
+		setField("Identifier", identifier);
+		setField("PluginName", pluginName);
+	}
+
+	/**
+	 * @deprecated Use {@link #ReloadPlugin(String, String)} instead
+	 */
+	@Deprecated
 	public void setPluginName(String pluginName) {
 		setField("PluginName", pluginName);
 	}
diff --git a/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java b/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java
index 16b6765..b9c5627 100644
--- a/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java
+++ b/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java
@@ -10,7 +10,13 @@ import static org.hamcrest.Matchers.equalTo;
 public class ReloadPluginTest {
 
 	@Test
-	public void reloadPluginMessageHasCorrectName() {
+	public void reloadPluginMessageWithIdentifierHasCorrectName() {
+		ReloadPlugin reloadPlugin = new ReloadPlugin("identifier");
+		assertThat(reloadPlugin.getName(), equalTo("ReloadPlugin"));
+	}
+
+	@Test
+	public void reloadPluginMessageWithIdentifierAndPluginNameHasCorrectName() {
 		assertThat(reloadPlugin.getName(), equalTo("ReloadPlugin"));
 	}
 
@@ -20,8 +26,13 @@ public class ReloadPluginTest {
 	}
 
 	@Test
+	public void reloadPluginSetsPluginName() {
+		assertThat(reloadPlugin.getField("PluginName"), equalTo("test.Plugin"));
+	}
+
+	@Test
 	public void settingThePluginNameSetsTheFieldCorrectly() {
-		verifyFieldValueAfterSettingProperty(reloadPlugin, ReloadPlugin::setPluginName, "PluginName", "test.Plugin");
+		verifyFieldValueAfterSettingProperty(reloadPlugin, ReloadPlugin::setPluginName, "PluginName", "test.other.Plugin");
 	}
 
 	@Test
@@ -49,6 +60,6 @@ public class ReloadPluginTest {
 		verifyFieldValueAfterSettingFlag(reloadPlugin, ReloadPlugin::setStore, "Store", true);
 	}
 
-	private final ReloadPlugin reloadPlugin = new ReloadPlugin("identifier");
+	private final ReloadPlugin reloadPlugin = new ReloadPlugin("identifier", "test.Plugin");
 
 }