From: dooglus <dooglus@1f10aa63-cdf2-0310-b900-c93c546f37ac>
Date: Fri, 25 Jan 2008 14:03:59 +0000 (+0000)
Subject: Stop a warning from g++ 4.3, but add a 'todo' note that the code needs checking.... 
X-Git-Url: https://git.pterodactylus.net/?a=commitdiff_plain;h=fb2d9bbd722ff979bc7f21b85c1e5a85cf03bf89;p=synfig.git

Stop a warning from g++ 4.3, but add a 'todo' note that the code needs checking.  It doesn't look right to me.


git-svn-id: http://svn.voria.com/code@1471 1f10aa63-cdf2-0310-b900-c93c546f37ac
---

diff --git a/synfig-core/trunk/src/synfig/savecanvas.cpp b/synfig-core/trunk/src/synfig/savecanvas.cpp
index c56986e..299472b 100644
--- a/synfig-core/trunk/src/synfig/savecanvas.cpp
+++ b/synfig-core/trunk/src/synfig/savecanvas.cpp
@@ -705,7 +705,8 @@ xmlpp::Element* encode_canvas(xmlpp::Element* root,Canvas::ConstHandle canvas)
 	}
 
 	// Output the <defs> section
-	if(!canvas->is_inline() && !canvas->value_node_list().empty() || !canvas->children().empty())
+	//! \todo check where the parentheses should really go - around the && or the ||?
+	if((!canvas->is_inline() && !canvas->value_node_list().empty()) || !canvas->children().empty())
 	{
 		xmlpp::Element *node=root->add_child("defs");
 		const ValueNodeList &value_node_list(canvas->value_node_list());