From 34fbc64ae1330cfce8e4dbfbba1bc6742421dd0d Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Sun, 6 Apr 2025 08:15:12 +0200 Subject: [PATCH] =?utf8?q?=F0=9F=94=A5=20Remove=20event=20that=20was=20nev?= =?utf8?q?er=20used?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- .../sone/core/PreferenceChangedEvent.kt | 3 --- .../net/pterodactylus/sone/core/Preferences.kt | 2 -- .../net/pterodactylus/sone/core/PreferencesTest.kt | 21 --------------------- 3 files changed, 26 deletions(-) delete mode 100644 src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt diff --git a/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt b/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt deleted file mode 100644 index 2ebb62d..0000000 --- a/src/main/kotlin/net/pterodactylus/sone/core/PreferenceChangedEvent.kt +++ /dev/null @@ -1,3 +0,0 @@ -package net.pterodactylus.sone.core - -data class PreferenceChangedEvent(val preferenceName: String, val newValue: Any) diff --git a/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt b/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt index e573185..314d66a 100644 --- a/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt +++ b/src/main/kotlin/net/pterodactylus/sone/core/Preferences.kt @@ -44,7 +44,6 @@ class DefaultPreferences(private val eventBus: EventBus) { set(value) { _insertionDelay.set(value) eventBus.post(InsertionDelayChangedEvent(insertionDelay)) - eventBus.post(PreferenceChangedEvent("InsertionDelay", insertionDelay)) } private val _postsPerPage = DefaultOption(10) { it in 1..MAX_VALUE } @@ -53,7 +52,6 @@ class DefaultPreferences(private val eventBus: EventBus) { get() = unsupported set(value) { _postsPerPage.set(value) - eventBus.post(PreferenceChangedEvent("PostsPerPage", postsPerPage)) } private val _imagesPerPage = DefaultOption(9) { it in 1..MAX_VALUE } diff --git a/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt b/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt index 62c5990..37a845a 100644 --- a/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/core/PreferencesTest.kt @@ -285,16 +285,6 @@ class DefaultPreferencesTest { } @Test - fun `setting insertion delay to valid value sends change event`() { - testPreferencesChangedEvent("InsertionDelay", { preferences.newInsertionDelay = it }, 30) - } - - @Test - fun `setting posts per page to valid value sends change event`() { - testPreferencesChangedEvent("PostsPerPage", { preferences.newPostsPerPage = it }, 31) - } - - @Test fun `default strict filtering is false`() { assertThat(preferences.strictFiltering, equalTo(false)) } @@ -357,15 +347,4 @@ class DefaultPreferencesTest { assertThat(getter(configuration), matcher) } - private fun testPreferencesChangedEvent(name: String, setter: (T) -> Unit, value: T) { - val events = mutableListOf() - eventBus.register(object { - @Subscribe - fun preferenceChanged(event: PreferenceChangedEvent) = - events.add(event) - }) - setter(value) - assertThat(events, hasItem(PreferenceChangedEvent(name, value))) - } - } -- 2.7.4