From 98674ba5829cf0dd016fd2cc75f6e545c1dd4063 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Fri, 3 Jan 2025 22:36:08 +0100 Subject: [PATCH] =?utf8?q?=F0=9F=97=91=EF=B8=8F=20Deprecate=20ReloadPlugin?= =?utf8?q?=20constructor=20without=20plugin=20name?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- .../java/net/pterodactylus/fcp/ReloadPlugin.java | 20 ++++++++++++++++++++ .../java/net/pterodactylus/fcp/ReloadPluginTest.java | 17 ++++++++++++++--- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java b/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java index 6aedeaa..d3d2f67 100644 --- a/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java +++ b/src/main/java/net/pterodactylus/fcp/ReloadPlugin.java @@ -24,11 +24,31 @@ package net.pterodactylus.fcp; */ public class ReloadPlugin extends FcpMessage { + /** + * @deprecated Use {@link #ReloadPlugin(String, String)} instead + */ + @Deprecated public ReloadPlugin(String identifier) { super("ReloadPlugin"); setField("Identifier", identifier); } + /** + * Creates a new “ReloadPlugin” message. + * + * @param identifier The identifier of the message + * @param pluginName The name of the plugin to reload + */ + public ReloadPlugin(String identifier, String pluginName) { + super("ReloadPlugin"); + setField("Identifier", identifier); + setField("PluginName", pluginName); + } + + /** + * @deprecated Use {@link #ReloadPlugin(String, String)} instead + */ + @Deprecated public void setPluginName(String pluginName) { setField("PluginName", pluginName); } diff --git a/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java b/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java index 16b6765..b9c5627 100644 --- a/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java +++ b/src/test/java/net/pterodactylus/fcp/ReloadPluginTest.java @@ -10,7 +10,13 @@ import static org.hamcrest.Matchers.equalTo; public class ReloadPluginTest { @Test - public void reloadPluginMessageHasCorrectName() { + public void reloadPluginMessageWithIdentifierHasCorrectName() { + ReloadPlugin reloadPlugin = new ReloadPlugin("identifier"); + assertThat(reloadPlugin.getName(), equalTo("ReloadPlugin")); + } + + @Test + public void reloadPluginMessageWithIdentifierAndPluginNameHasCorrectName() { assertThat(reloadPlugin.getName(), equalTo("ReloadPlugin")); } @@ -20,8 +26,13 @@ public class ReloadPluginTest { } @Test + public void reloadPluginSetsPluginName() { + assertThat(reloadPlugin.getField("PluginName"), equalTo("test.Plugin")); + } + + @Test public void settingThePluginNameSetsTheFieldCorrectly() { - verifyFieldValueAfterSettingProperty(reloadPlugin, ReloadPlugin::setPluginName, "PluginName", "test.Plugin"); + verifyFieldValueAfterSettingProperty(reloadPlugin, ReloadPlugin::setPluginName, "PluginName", "test.other.Plugin"); } @Test @@ -49,6 +60,6 @@ public class ReloadPluginTest { verifyFieldValueAfterSettingFlag(reloadPlugin, ReloadPlugin::setStore, "Store", true); } - private final ReloadPlugin reloadPlugin = new ReloadPlugin("identifier"); + private final ReloadPlugin reloadPlugin = new ReloadPlugin("identifier", "test.Plugin"); } -- 2.7.4