From cd2ec98ba1ec7c66342dbb50ad2876572d953591 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Wed, 30 May 2012 11:25:30 +0200 Subject: [PATCH] Turn post into an interface, add default implementation. --- .../java/net/pterodactylus/sone/core/Core.java | 5 +- .../java/net/pterodactylus/sone/data/Post.java | 159 ++------------ .../net/pterodactylus/sone/data/impl/PostImpl.java | 237 +++++++++++++++++++++ 3 files changed, 252 insertions(+), 149 deletions(-) create mode 100644 src/main/java/net/pterodactylus/sone/data/impl/PostImpl.java diff --git a/src/main/java/net/pterodactylus/sone/core/Core.java b/src/main/java/net/pterodactylus/sone/core/Core.java index 66dd23f..89867f4 100644 --- a/src/main/java/net/pterodactylus/sone/core/Core.java +++ b/src/main/java/net/pterodactylus/sone/core/Core.java @@ -46,6 +46,7 @@ import net.pterodactylus.sone.data.Sone; import net.pterodactylus.sone.data.Sone.ShowCustomAvatars; import net.pterodactylus.sone.data.Sone.SoneStatus; import net.pterodactylus.sone.data.TemporaryImage; +import net.pterodactylus.sone.data.impl.PostImpl; import net.pterodactylus.sone.fcp.FcpInterface; import net.pterodactylus.sone.fcp.FcpInterface.FullAccessRequired; import net.pterodactylus.sone.freenet.wot.Identity; @@ -561,7 +562,7 @@ public class Core extends AbstractService implements IdentityListener, UpdateLis synchronized (posts) { Post post = posts.get(postId); if ((post == null) && create) { - post = new Post(postId); + post = new PostImpl(postId); posts.put(postId, post); } return post; @@ -1599,7 +1600,7 @@ public class Core extends AbstractService implements IdentityListener, UpdateLis logger.log(Level.FINE, String.format("Tried to create post for non-local Sone: %s", sone)); return null; } - final Post post = new Post(sone, time, text); + final Post post = new PostImpl(sone, time, text); if (recipient != null) { post.setRecipient(recipient); } diff --git a/src/main/java/net/pterodactylus/sone/data/Post.java b/src/main/java/net/pterodactylus/sone/data/Post.java index 334a944..f171475 100644 --- a/src/main/java/net/pterodactylus/sone/data/Post.java +++ b/src/main/java/net/pterodactylus/sone/data/Post.java @@ -18,7 +18,6 @@ package net.pterodactylus.sone.data; import java.util.Comparator; -import java.util.UUID; import net.pterodactylus.util.collection.filter.Filter; @@ -28,7 +27,7 @@ import net.pterodactylus.util.collection.filter.Filter; * * @author David ‘Bombe’ Roden */ -public class Post { +public interface Post { /** Comparator for posts, sorts descending by time. */ public static final Comparator TIME_COMPARATOR = new Comparator() { @@ -50,79 +49,6 @@ public class Post { }; - /** The GUID of the post. */ - private final UUID id; - - /** The Sone this post belongs to. */ - private volatile Sone sone; - - /** The Sone of the recipient. */ - private volatile Sone recipient; - - /** The time of the post (in milliseconds since Jan 1, 1970 UTC). */ - private volatile long time; - - /** The text of the post. */ - private volatile String text; - - /** Whether the post is known. */ - private volatile boolean known; - - /** - * Creates a new post. - * - * @param id - * The ID of the post - */ - public Post(String id) { - this(id, null, 0, null); - } - - /** - * Creates a new post. - * - * @param sone - * The Sone this post belongs to - * @param text - * The text of the post - */ - public Post(Sone sone, String text) { - this(sone, System.currentTimeMillis(), text); - } - - /** - * Creates a new post. - * - * @param sone - * The Sone this post belongs to - * @param time - * The time of the post (in milliseconds since Jan 1, 1970 UTC) - * @param text - * The text of the post - */ - public Post(Sone sone, long time, String text) { - this(UUID.randomUUID().toString(), sone, time, text); - } - - /** - * Creates a new post. - * - * @param id - * The ID of the post - * @param sone - * The Sone this post belongs to - * @param time - * The time of the post (in milliseconds since Jan 1, 1970 UTC) - * @param text - * The text of the post - */ - public Post(String id, Sone sone, long time, String text) { - this.id = UUID.fromString(id); - this.sone = sone; - this.time = time; - this.text = text; - } - // // ACCESSORS // @@ -132,18 +58,14 @@ public class Post { * * @return The ID of the post */ - public String getId() { - return id.toString(); - } + public String getId(); /** * Returns the Sone this post belongs to. * * @return The Sone of this post */ - public Sone getSone() { - return sone; - } + public Sone getSone(); /** * Sets the Sone of this post. @@ -152,19 +74,14 @@ public class Post { * The Sone of this post * @return This post (for method chaining) */ - public Post setSone(Sone sone) { - this.sone = sone; - return this; - } + public Post setSone(Sone sone); /** * Returns the recipient of this post, if any. * * @return The recipient of this post, or {@code null} */ - public Sone getRecipient() { - return recipient; - } + public Sone getRecipient(); /** * Sets the recipient of this post. @@ -173,21 +90,14 @@ public class Post { * The recipient of this post, or {@code null} * @return This post (for method chaining) */ - public Post setRecipient(Sone recipient) { - if (!sone.equals(recipient)) { - this.recipient = recipient; - } - return this; - } + public Post setRecipient(Sone recipient); /** * Returns the time of the post. * * @return The time of the post (in milliseconds since Jan 1, 1970 UTC) */ - public long getTime() { - return time; - } + public long getTime(); /** * Sets the time of this post. @@ -196,19 +106,14 @@ public class Post { * The time of this post (in milliseconds since Jan 1, 1970 UTC) * @return This post (for method chaining) */ - public Post setTime(long time) { - this.time = time; - return this; - } + public Post setTime(long time); /** * Returns the text of the post. * * @return The text of the post */ - public String getText() { - return text; - } + public String getText(); /** * Sets the text of this post. @@ -217,19 +122,14 @@ public class Post { * The text of this post * @return This post (for method chaining) */ - public Post setText(String text) { - this.text = text; - return this; - } + public Post setText(String text); /** * Returns whether this post is known. * * @return {@code true} if this post is known, {@code false} otherwise */ - public boolean isKnown() { - return known; - } + public boolean isKnown(); /** * Sets whether this post is known. @@ -238,41 +138,6 @@ public class Post { * {@code true} if this post is known, {@code false} otherwise * @return This post */ - public Post setKnown(boolean known) { - this.known = known; - return this; - } - - // - // OBJECT METHODS - // - - /** - * {@inheritDoc} - */ - @Override - public int hashCode() { - return id.hashCode(); - } - - /** - * {@inheritDoc} - */ - @Override - public boolean equals(Object object) { - if (!(object instanceof Post)) { - return false; - } - Post post = (Post) object; - return post.id.equals(id); - } - - /** - * {@inheritDoc} - */ - @Override - public String toString() { - return getClass().getName() + "[id=" + id + ",sone=" + sone + ",time=" + time + ",text=" + text + "]"; - } + public Post setKnown(boolean known); } diff --git a/src/main/java/net/pterodactylus/sone/data/impl/PostImpl.java b/src/main/java/net/pterodactylus/sone/data/impl/PostImpl.java new file mode 100644 index 0000000..2269738 --- /dev/null +++ b/src/main/java/net/pterodactylus/sone/data/impl/PostImpl.java @@ -0,0 +1,237 @@ +/* + * Sone - PostImpl.java - Copyright © 2010–2012 David Roden + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +package net.pterodactylus.sone.data.impl; + +import java.util.UUID; + +import net.pterodactylus.sone.data.Post; +import net.pterodactylus.sone.data.Sone; + +/** + * A post is a short message that a user writes in his Sone to let other users + * know what is going on. + * + * @author David ‘Bombe’ Roden + */ +public class PostImpl implements Post { + + /** The GUID of the post. */ + private final UUID id; + + /** The Sone this post belongs to. */ + private volatile Sone sone; + + /** The Sone of the recipient. */ + private volatile Sone recipient; + + /** The time of the post (in milliseconds since Jan 1, 1970 UTC). */ + private volatile long time; + + /** The text of the post. */ + private volatile String text; + + /** Whether the post is known. */ + private volatile boolean known; + + /** + * Creates a new post. + * + * @param id + * The ID of the post + */ + public PostImpl(String id) { + this(id, null, 0, null); + } + + /** + * Creates a new post. + * + * @param sone + * The Sone this post belongs to + * @param text + * The text of the post + */ + public PostImpl(Sone sone, String text) { + this(sone, System.currentTimeMillis(), text); + } + + /** + * Creates a new post. + * + * @param sone + * The Sone this post belongs to + * @param time + * The time of the post (in milliseconds since Jan 1, 1970 UTC) + * @param text + * The text of the post + */ + public PostImpl(Sone sone, long time, String text) { + this(UUID.randomUUID().toString(), sone, time, text); + } + + /** + * Creates a new post. + * + * @param id + * The ID of the post + * @param sone + * The Sone this post belongs to + * @param time + * The time of the post (in milliseconds since Jan 1, 1970 UTC) + * @param text + * The text of the post + */ + public PostImpl(String id, Sone sone, long time, String text) { + this.id = UUID.fromString(id); + this.sone = sone; + this.time = time; + this.text = text; + } + + // + // ACCESSORS + // + + /** + * {@inheritDoc} + */ + @Override + public String getId() { + return id.toString(); + } + + /** + * {@inheritDoc} + */ + @Override + public Sone getSone() { + return sone; + } + + /** + * {@inheritDoc} + */ + @Override + public PostImpl setSone(Sone sone) { + this.sone = sone; + return this; + } + + /** + * {@inheritDoc} + */ + @Override + public Sone getRecipient() { + return recipient; + } + + /** + * {@inheritDoc} + */ + @Override + public PostImpl setRecipient(Sone recipient) { + if (!sone.equals(recipient)) { + this.recipient = recipient; + } + return this; + } + + /** + * {@inheritDoc} + */ + @Override + public long getTime() { + return time; + } + + /** + * {@inheritDoc} + */ + @Override + public PostImpl setTime(long time) { + this.time = time; + return this; + } + + /** + * {@inheritDoc} + */ + @Override + public String getText() { + return text; + } + + /** + * {@inheritDoc} + */ + @Override + public PostImpl setText(String text) { + this.text = text; + return this; + } + + /** + * {@inheritDoc} + */ + @Override + public boolean isKnown() { + return known; + } + + /** + * {@inheritDoc} + */ + @Override + public PostImpl setKnown(boolean known) { + this.known = known; + return this; + } + + // + // OBJECT METHODS + // + + /** + * {@inheritDoc} + */ + @Override + public int hashCode() { + return id.hashCode(); + } + + /** + * {@inheritDoc} + */ + @Override + public boolean equals(Object object) { + if (!(object instanceof PostImpl)) { + return false; + } + PostImpl post = (PostImpl) object; + return post.id.equals(id); + } + + /** + * {@inheritDoc} + */ + @Override + public String toString() { + return getClass().getName() + "[id=" + id + ",sone=" + sone + ",time=" + time + ",text=" + text + "]"; + } + +} -- 2.7.4