Add test for storing IDs on known post replies
[Sone.git] / src / test / java / net / pterodactylus / sone / database / memory / MemoryDatabaseTest.java
index db18cd2..60c8c53 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Sone - MemoryDatabaseTest.java - Copyright © 2013 David Roden
+ * Sone - MemoryDatabaseTest.java - Copyright © 2013–2019 David Roden
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
 package net.pterodactylus.sone.database.memory;
 
 import static com.google.common.base.Optional.of;
+import static java.util.Arrays.asList;
 import static java.util.UUID.randomUUID;
+import static net.pterodactylus.sone.test.Matchers.isAlbum;
+import static net.pterodactylus.sone.test.Matchers.isImage;
+import static net.pterodactylus.sone.test.Matchers.isPost;
+import static net.pterodactylus.sone.test.Matchers.isPostReply;
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.empty;
+import static org.hamcrest.Matchers.emptyIterable;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.lessThan;
+import static org.hamcrest.Matchers.nullValue;
+import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
 import net.pterodactylus.sone.data.Album;
-import net.pterodactylus.sone.data.AlbumImpl;
+import net.pterodactylus.sone.data.Image;
 import net.pterodactylus.sone.data.Post;
 import net.pterodactylus.sone.data.PostReply;
 import net.pterodactylus.sone.data.Sone;
+import net.pterodactylus.sone.data.impl.AlbumImpl;
+import net.pterodactylus.sone.test.TestAlbumBuilder;
+import net.pterodactylus.sone.test.TestImageBuilder;
+import net.pterodactylus.sone.test.TestPostBuilder;
+import net.pterodactylus.sone.test.TestPostReplyBuilder;
+import net.pterodactylus.sone.test.TestValue;
+import net.pterodactylus.util.config.Configuration;
+import net.pterodactylus.util.config.ConfigurationException;
+import net.pterodactylus.util.config.Value;
 
 import com.google.common.base.Optional;
+import org.hamcrest.CoreMatchers;
 import org.junit.Before;
 import org.junit.Test;
+import org.mockito.invocation.InvocationOnMock;
+import org.mockito.stubbing.Answer;
 
 /**
  * Tests for {@link MemoryDatabase}.
- *
- * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
  */
 public class MemoryDatabaseTest {
 
        private static final String SONE_ID = "sone";
        private static final String RECIPIENT_ID = "recipient";
-       private final MemoryDatabase memoryDatabase = new MemoryDatabase(null, null);
+       private final Configuration configuration = mock(Configuration.class);
+       private final MemoryDatabase memoryDatabase = new MemoryDatabase(configuration);
        private final Sone sone = mock(Sone.class);
 
        @Before
@@ -53,6 +85,141 @@ public class MemoryDatabaseTest {
        }
 
        @Test
+       public void storedSoneIsMadeAvailable() {
+               Post firstPost = new TestPostBuilder().withId("post1")
+                               .from(SONE_ID)
+                               .withTime(1000L)
+                               .withText("post1")
+                               .build();
+               Post secondPost = new TestPostBuilder().withId("post2")
+                               .from(SONE_ID)
+                               .withTime(2000L)
+                               .withText("post2")
+                               .to(RECIPIENT_ID)
+                               .build();
+               List<Post> posts = asList(firstPost, secondPost);
+               when(sone.getPosts()).thenReturn(posts);
+               PostReply firstPostFirstReply =
+                               new TestPostReplyBuilder().withId("reply1")
+                                               .from(SONE_ID)
+                                               .to(firstPost.getId())
+                                               .withTime(3000L)
+                                               .withText("reply1")
+                                               .build();
+               PostReply firstPostSecondReply =
+                               new TestPostReplyBuilder().withId("reply3")
+                                               .from(RECIPIENT_ID)
+                                               .to(firstPost.getId())
+                                               .withTime(5000L)
+                                               .withText("reply3")
+                                               .build();
+               PostReply secondPostReply =
+                               new TestPostReplyBuilder().withId("reply2")
+                                               .from(SONE_ID)
+                                               .to(secondPost.getId())
+                                               .withTime(4000L)
+                                               .withText("reply2")
+                                               .build();
+               Set<PostReply> postReplies = new HashSet<>(
+                               asList(firstPostFirstReply, firstPostSecondReply,
+                                               secondPostReply));
+               when(sone.getReplies()).thenReturn(postReplies);
+               Album firstAlbum = new TestAlbumBuilder().withId("album1")
+                               .by(sone)
+                               .build()
+                               .modify()
+                               .setTitle("album1")
+                               .setDescription("album-description1")
+                               .update();
+               Album secondAlbum = new TestAlbumBuilder().withId("album2").by(
+                               sone).build().modify().setTitle("album2").setDescription(
+                               "album-description2").update();
+               Album thirdAlbum = new TestAlbumBuilder().withId("album3").by(
+                               sone).build().modify().setTitle("album3").setDescription(
+                               "album-description3").update();
+               firstAlbum.addAlbum(thirdAlbum);
+               Album rootAlbum = mock(Album.class);
+               when(rootAlbum.getId()).thenReturn("root");
+               when(rootAlbum.getAlbums()).thenReturn(
+                               asList(firstAlbum, secondAlbum));
+               when(sone.getRootAlbum()).thenReturn(rootAlbum);
+               Image firstImage = new TestImageBuilder().withId("image1")
+                               .build()
+                               .modify()
+                               .setSone(sone)
+                               .setCreationTime(1000L)
+                               .setKey("KSK@image1")
+                               .setTitle("image1")
+                               .setDescription("image-description1")
+                               .setWidth(16)
+                               .setHeight(9)
+                               .update();
+               Image secondImage = new TestImageBuilder().withId("image2")
+                               .build()
+                               .modify()
+                               .setSone(sone)
+                               .setCreationTime(2000L)
+                               .setKey("KSK@image2")
+                               .setTitle("image2")
+                               .setDescription("image-description2")
+                               .setWidth(32)
+                               .setHeight(18)
+                               .update();
+               Image thirdImage = new TestImageBuilder().withId("image3")
+                               .build()
+                               .modify()
+                               .setSone(sone)
+                               .setCreationTime(3000L)
+                               .setKey("KSK@image3")
+                               .setTitle("image3")
+                               .setDescription("image-description3")
+                               .setWidth(48)
+                               .setHeight(27)
+                               .update();
+               firstAlbum.addImage(firstImage);
+               firstAlbum.addImage(thirdImage);
+               secondAlbum.addImage(secondImage);
+               memoryDatabase.storeSone(sone);
+               assertThat(memoryDatabase.getPost("post1"),
+                               isPost(firstPost.getId(), 1000L, "post1",
+                                               Optional.<String>absent()));
+               assertThat(memoryDatabase.getPost("post2"),
+                               isPost(secondPost.getId(), 2000L, "post2", of(RECIPIENT_ID)));
+               assertThat(memoryDatabase.getPost("post3"), nullValue());
+               assertThat(memoryDatabase.getPostReply("reply1"),
+                               isPostReply("reply1", "post1", 3000L, "reply1"));
+               assertThat(memoryDatabase.getPostReply("reply2"),
+                               isPostReply("reply2", "post2", 4000L, "reply2"));
+               assertThat(memoryDatabase.getPostReply("reply3"),
+                               isPostReply("reply3", "post1", 5000L, "reply3"));
+               assertThat(memoryDatabase.getPostReply("reply4"), nullValue());
+               assertThat(memoryDatabase.getAlbum("album1"),
+                               isAlbum("album1", null, "album1", "album-description1"));
+               assertThat(memoryDatabase.getAlbum("album2"),
+                               isAlbum("album2", null, "album2", "album-description2"));
+               assertThat(memoryDatabase.getAlbum("album3"),
+                               isAlbum("album3", "album1", "album3", "album-description3"));
+               assertThat(memoryDatabase.getAlbum("album4"), nullValue());
+               assertThat(memoryDatabase.getImage("image1"),
+                               isImage("image1", 1000L, "KSK@image1", "image1",
+                                               "image-description1", 16, 9));
+               assertThat(memoryDatabase.getImage("image2"),
+                               isImage("image2", 2000L, "KSK@image2", "image2",
+                                               "image-description2", 32, 18));
+               assertThat(memoryDatabase.getImage("image3"),
+                               isImage("image3", 3000L, "KSK@image3", "image3",
+                                               "image-description3", 48, 27));
+               assertThat(memoryDatabase.getImage("image4"), nullValue());
+       }
+
+       @Test
+       public void storedAndRemovedSoneIsNotAvailable() {
+               storedSoneIsMadeAvailable();
+               memoryDatabase.removeSone(sone);
+               assertThat(memoryDatabase.getSones(), empty());
+       }
+
+       @Test
        public void postRecipientsAreDetectedCorrectly() {
                Post postWithRecipient = createPost(of(RECIPIENT_ID));
                memoryDatabase.storePost(postWithRecipient);
@@ -101,11 +268,212 @@ public class MemoryDatabaseTest {
        @Test
        public void testBasicAlbumFunctionality() {
                Album newAlbum = new AlbumImpl(mock(Sone.class));
-               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), is(Optional.<Album>absent()));
+               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), nullValue());
                memoryDatabase.storeAlbum(newAlbum);
-               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), is(of(newAlbum)));
+               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), is(newAlbum));
                memoryDatabase.removeAlbum(newAlbum);
-               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), is(Optional.<Album>absent()));
+               assertThat(memoryDatabase.getAlbum(newAlbum.getId()), nullValue());
+       }
+
+       private void initializeFriends() {
+               when(configuration.getStringValue("Sone/" + SONE_ID + "/Friends/0/ID")).thenReturn(
+                               TestValue.from("Friend1"));
+               when(configuration.getStringValue("Sone/" + SONE_ID + "/Friends/1/ID")).thenReturn(
+                               TestValue.from("Friend2"));
+               when(configuration.getStringValue("Sone/" + SONE_ID + "/Friends/2/ID")).thenReturn(
+                               TestValue.<String>from(null));
+       }
+
+       @Test
+       public void friendsAreReturnedCorrectly() {
+               initializeFriends();
+               when(sone.isLocal()).thenReturn(true);
+               Collection<String> friends = memoryDatabase.getFriends(sone);
+               assertThat(friends, containsInAnyOrder("Friend1", "Friend2"));
+       }
+
+       @Test
+       public void friendsAreOnlyLoadedOnceFromConfiguration() {
+               friendsAreReturnedCorrectly();
+               memoryDatabase.getFriends(sone);
+               verify(configuration).getStringValue("Sone/" + SONE_ID + "/Friends/0/ID");
+       }
+
+       @Test
+       public void friendsAreOnlyReturnedForLocalSones() {
+               Collection<String> friends = memoryDatabase.getFriends(sone);
+               assertThat(friends, emptyIterable());
+               verify(configuration, never()).getStringValue("Sone/" + SONE_ID + "/Friends/0/ID");
+       }
+
+       @Test
+       public void checkingForAFriendReturnsTrue() {
+               initializeFriends();
+               when(sone.isLocal()).thenReturn(true);
+               assertThat(memoryDatabase.isFriend(sone, "Friend1"), is(true));
+       }
+
+       @Test
+       public void checkingForAFriendThatIsNotAFriendReturnsFalse() {
+               initializeFriends();
+               when(sone.isLocal()).thenReturn(true);
+               assertThat(memoryDatabase.isFriend(sone, "FriendX"), is(false));
+       }
+
+       @Test
+       public void checkingForAFriendOfRemoteSoneReturnsFalse() {
+               initializeFriends();
+               assertThat(memoryDatabase.isFriend(sone, "Friend1"), is(false));
+       }
+
+       private Map<String, Value<?>> prepareConfigurationValues() {
+               final Map<String, Value<?>> configurationValues = new HashMap<>();
+               when(configuration.getStringValue(anyString())).thenAnswer(new Answer<Value<String>>() {
+                       @Override
+                       public Value<String> answer(InvocationOnMock invocation) throws Throwable {
+                               Value<?> value = configurationValues.get(invocation.<String>getArgument(0));
+                               if (value == null) {
+                                       value = TestValue.from(null);
+                                       configurationValues.put(invocation.<String>getArgument(0), value);
+                               }
+                               return (Value<String>) value;
+                       }
+               });
+               when(configuration.getLongValue(anyString())).thenAnswer(new Answer<Value<Long>>() {
+                       @Override
+                       public Value<Long> answer(InvocationOnMock invocation) throws Throwable {
+                               Value<?> value = configurationValues.get(invocation.<String>getArgument(0));
+                               if (value == null) {
+                                       value = TestValue.from(null);
+                                       configurationValues.put(invocation.<String>getArgument(0), value);
+                               }
+                               return (Value<Long>) value;
+                       }
+               });
+               return configurationValues;
+       }
+
+       @Test
+       public void friendIsAddedCorrectlyToLocalSone() {
+               Map<String, Value<?>> configurationValues = prepareConfigurationValues();
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.addFriend(sone, "Friend1");
+               assertThat(configurationValues.get("Sone/" + SONE_ID + "/Friends/0/ID"),
+                               CoreMatchers.<Value<?>>is(TestValue.from("Friend1")));
+               assertThat(configurationValues.get("Sone/" + SONE_ID + "/Friends/1/ID"),
+                               CoreMatchers.<Value<?>>is(TestValue.<String>from(null)));
+       }
+
+       @Test
+       public void friendIsNotAddedToRemoteSone() {
+               memoryDatabase.addFriend(sone, "Friend1");
+               verify(configuration, never()).getStringValue(anyString());
+       }
+
+       @Test
+       public void friendIsRemovedCorrectlyFromLocalSone() {
+               Map<String, Value<?>> configurationValues = prepareConfigurationValues();
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.addFriend(sone, "Friend1");
+               memoryDatabase.removeFriend(sone, "Friend1");
+               assertThat(configurationValues.get("Sone/" + SONE_ID + "/Friends/0/ID"),
+                               CoreMatchers.<Value<?>>is(TestValue.<String>from(null)));
+               assertThat(configurationValues.get("Sone/" + SONE_ID + "/Friends/1/ID"),
+                               CoreMatchers.<Value<?>>is(TestValue.<String>from(null)));
+       }
+
+       @Test
+       public void configurationIsNotWrittenWhenANonFriendIsRemoved() {
+               prepareConfigurationValues();
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.removeFriend(sone, "Friend1");
+               verify(configuration).getStringValue(anyString());
+       }
+
+       @Test
+       public void soneFollowingTimeIsReturnedCorrectly() throws ConfigurationException {
+               prepareConfigurationValues();
+               configuration.getStringValue("SoneFollowingTimes/0/Sone").setValue("sone");
+               configuration.getLongValue("SoneFollowingTimes/0/Time").setValue(1000L);
+               assertThat(memoryDatabase.getFollowingTime("sone"), equalTo(1000L));
+       }
+
+       @Test
+       public void nullisReturnedWhenSoneIsNotFollowed() throws ConfigurationException {
+               prepareConfigurationValues();
+               configuration.getStringValue("SoneFollowingTimes/0/Sone").setValue("otherSone");
+               configuration.getLongValue("SoneFollowingTimes/0/Time").setValue(1000L);
+               assertThat(memoryDatabase.getFollowingTime("sone"), nullValue());
+       }
+
+       @Test
+       public void timeIsStoredInConfigurationWhenASoneIsFollowed() throws ConfigurationException {
+               prepareConfigurationValues();
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.addFriend(sone, "Friend");
+               assertThat(configuration.getStringValue("SoneFollowingTimes/0/Sone").getValue(), equalTo("Friend"));
+               assertThat(System.currentTimeMillis() - configuration.getLongValue("SoneFollowingTimes/0/Time").getValue(), lessThan(1000L));
+               assertThat(configuration.getStringValue("SoneFollowingTimes/1/Sone").getValue(), nullValue());
+       }
+
+       @Test
+       public void existingTimeIsNotOverwrittenWhenASoneIsFollowed() throws ConfigurationException {
+               prepareConfigurationValues();
+               configuration.getStringValue("SoneFollowingTimes/0/Sone").setValue("Friend");
+               configuration.getLongValue("SoneFollowingTimes/0/Time").setValue(1000L);
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.addFriend(sone, "Friend");
+               assertThat(configuration.getStringValue("SoneFollowingTimes/0/Sone").getValue(), equalTo("Friend"));
+               assertThat(configuration.getLongValue("SoneFollowingTimes/0/Time").getValue(), equalTo(1000L));
+               assertThat(configuration.getStringValue("SoneFollowingTimes/1/Sone").getValue(), nullValue());
+       }
+
+       @Test
+       public void unfollowingASoneRemovesTheFollowingTime() throws ConfigurationException {
+               prepareConfigurationValues();
+               configuration.getStringValue("Sone/sone/Friends/0/ID").setValue("Friend");
+               configuration.getStringValue("SoneFollowingTimes/0/Sone").setValue("Friend");
+               configuration.getLongValue("SoneFollowingTimes/0/Time").setValue(1000L);
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.removeFriend(sone, "Friend");
+               assertThat(configuration.getStringValue("SoneFollowingTimes/0/Sone").getValue(), nullValue());
+       }
+
+       @Test
+       public void unfollowingASoneDoesNotRemoveTheFollowingTimeIfAnotherLocalSoneFollowsIt() throws ConfigurationException {
+               prepareConfigurationValues();
+               configuration.getStringValue("Sone/sone/Friends/0/ID").setValue("Friend");
+               configuration.getStringValue("Sone/other-sone/Friends/0/ID").setValue("Friend");
+               configuration.getStringValue("SoneFollowingTimes/0/Sone").setValue("Friend");
+               configuration.getLongValue("SoneFollowingTimes/0/Time").setValue(1000L);
+               Sone otherSone = mock(Sone.class);
+               when(otherSone.isLocal()).thenReturn(true);
+               when(otherSone.getId()).thenReturn("other-sone");
+               memoryDatabase.getFriends(otherSone);
+               when(sone.isLocal()).thenReturn(true);
+               memoryDatabase.removeFriend(sone, "Friend");
+               assertThat(configuration.getStringValue("SoneFollowingTimes/0/Sone").getValue(), equalTo("Friend"));
+               assertThat(configuration.getLongValue("SoneFollowingTimes/0/Time").getValue(), equalTo(1000L));
+       }
+
+       @Test
+       public void markingAPostAsKnownSavesConfiguration() throws ConfigurationException {
+               prepareConfigurationValues();
+               Post post = mock(Post.class);
+               when(post.getId()).thenReturn("post-id");
+               memoryDatabase.setPostKnown(post, true);
+               assertThat(configuration.getStringValue("KnownPosts/0/ID").getValue(), equalTo("post-id"));
+               assertThat(configuration.getStringValue("KnownPosts/1/ID").getValue(), equalTo(null));
+       }
+
+       @Test
+       public void markingAPostReplyAsKnownSavesConfiguration() throws ConfigurationException {
+               prepareConfigurationValues();
+               PostReply postReply = mock(PostReply.class);
+               when(postReply.getId()).thenReturn("post-reply-id");
+               memoryDatabase.setPostReplyKnown(postReply, true);
+               assertThat(configuration.getStringValue("KnownReplies/0/ID").getValue(), equalTo("post-reply-id"));
+               assertThat(configuration.getStringValue("KnownReplies/1/ID").getValue(), equalTo(null));
        }
 
 }