✨ Use @TemplatePath annotations on most pages

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / pages / EditProfilePageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt
index 282dbc2..be34861 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt
@@ -2,11 +2,11 @@ package net.pterodactylus.sone.web.pages
 
 import net.pterodactylus.sone.data.Image
 import net.pterodactylus.sone.data.Profile
+import net.pterodactylus.sone.test.getInstance
 import net.pterodactylus.sone.test.mock
 import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.sone.web.pages.EditProfilePage
-import net.pterodactylus.sone.web.pages.WebPageTest
-import net.pterodactylus.util.web.Method.GET
+import net.pterodactylus.sone.web.baseInjector
+import net.pterodactylus.sone.web.page.*
 import net.pterodactylus.util.web.Method.POST
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.contains
@@ -20,16 +20,12 @@ import org.mockito.Mockito.verify
 /**
  * Unit test for [EditProfilePage].
  */
-class EditProfilePageTest : WebPageTest() {
-
-       private val page = EditProfilePage(template, webInterface)
+class EditProfilePageTest: WebPageTest(::EditProfilePage) {
 
        private val profile = Profile(currentSone)
        private val firstField = profile.addField("First Field")
        private val secondField = profile.addField("Second Field")
 
-       override fun getPage() = page
-
        @Before
        fun setupProfile() {
                val avatar = mock<Image>()
@@ -58,12 +54,11 @@ class EditProfilePageTest : WebPageTest() {
        @Test
        fun `page returns correct title`() {
            whenever(l10n.getString("Page.EditProfile.Title")).thenReturn("edit profile page title")
-               assertThat(page.getPageTitle(freenetRequest), equalTo("edit profile page title"))
+               assertThat(page.getPageTitle(soneRequest), equalTo("edit profile page title"))
        }
 
        @Test
        fun `get request stores fields of current sone’s profile in template context`() {
-               request("", GET)
                page.processTemplate(freenetRequest, templateContext)
                assertThat(templateContext["firstName"], equalTo<Any>("First"))
                assertThat(templateContext["middleName"], equalTo<Any>("Middle"))
@@ -77,7 +72,7 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `post request without any command stores fields of current sone’s profile in template context`() {
-               request("", POST)
+               setMethod(POST)
                page.processTemplate(freenetRequest, templateContext)
                assertThat(templateContext["firstName"], equalTo<Any>("First"))
                assertThat(templateContext["middleName"], equalTo<Any>("Middle"))
@@ -90,10 +85,11 @@ class EditProfilePageTest : WebPageTest() {
        }
 
        private fun <T> verifySingleFieldCanBeChanged(fieldName: String, newValue: T, expectedValue: T = newValue, fieldAccessor: () -> T) {
-               request("", POST)
-               addHttpRequestParameter("save-profile", "true")
-               addHttpRequestParameter(fieldName, newValue.toString())
+               setMethod(POST)
+               addHttpRequestPart("save-profile", "true")
+               addHttpRequestPart(fieldName, newValue.toString())
                verifyRedirect("editProfile.html") {
+                       verify(currentSone).profile = profile
                        verify(core).touchConfiguration()
                        assertThat(fieldAccessor(), equalTo(expectedValue))
                }
@@ -155,10 +151,10 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `adding a field with a duplicate name sets error in template context`() {
-               request("", POST)
+               setMethod(POST)
                profile.addField("new-field")
-               addHttpRequestParameter("add-field", "true")
-               addHttpRequestParameter("field-name", "new-field")
+               addHttpRequestPart("add-field", "true")
+               addHttpRequestPart("field-name", "new-field")
                page.processTemplate(freenetRequest, templateContext)
                assertThat(templateContext["fieldName"], equalTo<Any>("new-field"))
                assertThat(templateContext["duplicateFieldName"], equalTo<Any>(true))
@@ -167,9 +163,9 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `adding a field with a new name sets adds field to profile and redirects to profile edit page`() {
-               request("", POST)
-               addHttpRequestParameter("add-field", "true")
-               addHttpRequestParameter("field-name", "new-field")
+               setMethod(POST)
+               addHttpRequestPart("add-field", "true")
+               addHttpRequestPart("field-name", "new-field")
                verifyRedirect("editProfile.html#profile-fields") {
                        assertThat(profile.getFieldByName("new-field"), notNullValue())
                        verify(currentSone).profile = profile
@@ -179,15 +175,15 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `deleting a field redirects to delete field page`() {
-               request("", POST)
-               addHttpRequestParameter("delete-field-${firstField.id}", "true")
+               setMethod(POST)
+               addHttpRequestPart("delete-field-${firstField.id}", "true")
                verifyRedirect("deleteProfileField.html?field=${firstField.id}")
        }
 
        @Test
        fun `moving a field up moves the field up and redirects to the edit profile page`() {
-               request("", POST)
-               addHttpRequestParameter("move-up-field-${secondField.id}", "true")
+               setMethod(POST)
+               addHttpRequestPart("move-up-field-${secondField.id}", "true")
                verifyRedirect("editProfile.html#profile-fields") {
                        assertThat(profile.fields, contains(secondField, firstField))
                        verify(currentSone).profile = profile
@@ -196,15 +192,15 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `moving an invalid field up does not redirect`() {
-               request("", POST)
-               addHttpRequestParameter("move-up-field-foo", "true")
+               setMethod(POST)
+               addHttpRequestPart("move-up-field-foo", "true")
                page.processTemplate(freenetRequest, templateContext)
        }
 
        @Test
        fun `moving a field down moves the field down and redirects to the edit profile page`() {
-               request("", POST)
-               addHttpRequestParameter("move-down-field-${firstField.id}", "true")
+               setMethod(POST)
+               addHttpRequestPart("move-down-field-${firstField.id}", "true")
                verifyRedirect("editProfile.html#profile-fields") {
                        assertThat(profile.fields, contains(secondField, firstField))
                        verify(currentSone).profile = profile
@@ -213,16 +209,31 @@ class EditProfilePageTest : WebPageTest() {
 
        @Test
        fun `moving an invalid field down does not redirect`() {
-               request("", POST)
-               addHttpRequestParameter("move-down-field-foo", "true")
+               setMethod(POST)
+               addHttpRequestPart("move-down-field-foo", "true")
                page.processTemplate(freenetRequest, templateContext)
        }
 
        @Test
        fun `editing a field redirects to the edit profile page`() {
-               request("", POST)
-               addHttpRequestParameter("edit-field-${firstField.id}", "true")
+               setMethod(POST)
+               addHttpRequestPart("edit-field-${firstField.id}", "true")
                verifyRedirect("editProfileField.html?field=${firstField.id}")
        }
 
+       @Test
+       fun `page can be created by dependency injection`() {
+           assertThat(baseInjector.getInstance<EditProfilePage>(), notNullValue())
+       }
+
+       @Test
+       fun `page is annotated with correct menuname`() {
+           assertThat(page.menuName, equalTo("EditProfile"))
+       }
+
+       @Test
+       fun `page is annotated with correct template path`() {
+           assertThat(page.templatePath, equalTo("/templates/editProfile.html"))
+       }
+
 }