Remove unnecessary type parameters

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / pages / UploadImagePageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
index 38c5fe1..fe76737 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
@@ -5,13 +5,15 @@ import net.pterodactylus.sone.data.Image
 import net.pterodactylus.sone.data.Image.Modifier
 import net.pterodactylus.sone.data.Sone
 import net.pterodactylus.sone.data.TemporaryImage
+import net.pterodactylus.sone.test.getInstance
 import net.pterodactylus.sone.test.mock
 import net.pterodactylus.sone.test.mockBuilder
 import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.sone.web.pages.UploadImagePage
+import net.pterodactylus.sone.web.baseInjector
 import net.pterodactylus.util.web.Method.POST
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.equalTo
+import org.hamcrest.Matchers.notNullValue
 import org.junit.Test
 import org.mockito.Mockito.any
 import org.mockito.Mockito.eq
@@ -21,40 +23,55 @@ import org.mockito.Mockito.verify
 /**
  * Unit test for [UploadImagePage].
  */
-class UploadImagePageTest : WebPageTest() {
+class UploadImagePageTest: WebPageTest(::UploadImagePage) {
 
        private val parentAlbum = mock<Album>().apply {
                whenever(id).thenReturn("parent-id")
                whenever(sone).thenReturn(currentSone)
        }
 
-       override fun getPage() = UploadImagePage(template, webInterface)
+       @Test
+       fun `page returns correct path`() {
+           assertThat(page.path, equalTo("uploadImage.html"))
+       }
+
+       @Test
+       fun `page requires login`() {
+           assertThat(page.requiresLogin(), equalTo(true))
+       }
+
+       @Test
+       fun `page returns correct title`() {
+           addTranslation("Page.UploadImage.Title", "upload image page title")
+               assertThat(page.getPageTitle(freenetRequest), equalTo("upload image page title"))
+       }
 
        @Test
        fun `get request does not redirect or upload anything`() {
-               page.handleRequest(freenetRequest, templateContext)
-               verify(core, never()).createTemporaryImage(any(), any())
-               verify(core, never()).createImage(any(), any(), any())
+               verifyNoRedirect {
+                       verify(core, never()).createTemporaryImage(any(), any())
+                       verify(core, never()).createImage(any(), any(), any())
+               }
        }
 
        @Test
        fun `post request without parent results in no permission error page`() {
-               request("", POST)
+               setMethod(POST)
                verifyRedirect("noPermission.html")
        }
 
        @Test
        fun `post request with parent that is not the current sone results in no permission error page`() {
-               request("", POST)
+               setMethod(POST)
                addHttpRequestPart("parent", "parent-id")
-               whenever(parentAlbum.sone).thenReturn(mock<Sone>())
+               whenever(parentAlbum.sone).thenReturn(mock())
                addAlbum("parent-id", parentAlbum)
                verifyRedirect("noPermission.html")
        }
 
        @Test
        fun `post request with empty name redirects to error page`() {
-               request("", POST)
+               setMethod(POST)
                addAlbum("parent-id", parentAlbum)
                addHttpRequestPart("parent", "parent-id")
                addHttpRequestPart("title", " ")
@@ -63,24 +80,27 @@ class UploadImagePageTest : WebPageTest() {
 
        @Test
        fun `uploading an invalid image results in no redirect and message set in template context`() {
-               request("", POST)
+               setMethod(POST)
                addAlbum("parent-id", parentAlbum)
                addHttpRequestPart("parent", "parent-id")
                addHttpRequestPart("title", "title")
-               addUploadedFile("image", "image.png", "image/png", "no-image.png")
-               page.handleRequest(freenetRequest, templateContext)
-               verify(core, never()).createTemporaryImage(any(), any())
-               assertThat(templateContext["messages"] as String?, equalTo<String>("Page.UploadImage.Error.InvalidImage"))
+               addUploadedFile("image", "image.png", "image/png", "upload-image-invalid-image.png")
+               addTranslation("Page.UploadImage.Error.InvalidImage", "upload error - invalid image")
+               verifyNoRedirect {
+                       verify(core, never()).createTemporaryImage(any(), any())
+                       assertThat(templateContext["messages"] as String, equalTo("upload error - invalid image"))
+               }
        }
 
        @Test
        fun `uploading a valid image uploads image and redirects to album browser`() {
-               request("", POST)
+               setMethod(POST)
                addAlbum("parent-id", parentAlbum)
                addHttpRequestPart("parent", "parent-id")
                addHttpRequestPart("title", "Title")
-               addHttpRequestPart("description", "Description")
-               addUploadedFile("image", "image.png", "image/png", "image.png")
+               addHttpRequestPart("description", "Description @ http://localhost:8888/KSK@foo")
+               addHttpRequestHeader("Host", "localhost:8888")
+               addUploadedFile("image", "upload-image-value-image.png", "image/png", "upload-image-value-image.png")
                val temporaryImage = TemporaryImage("temp-image")
                val imageModifier = mockBuilder<Modifier>()
                val image = mock<Image>().apply {
@@ -93,9 +113,14 @@ class UploadImagePageTest : WebPageTest() {
                        verify(imageModifier).setWidth(2)
                        verify(imageModifier).setHeight(1)
                        verify(imageModifier).setTitle("Title")
-                       verify(imageModifier).setDescription("Description")
+                       verify(imageModifier).setDescription("Description @ KSK@foo")
                        verify(imageModifier).update()
                }
        }
 
+       @Test
+       fun `page can be created by dependency injection`() {
+           assertThat(baseInjector.getInstance<UploadImagePage>(), notNullValue())
+       }
+
 }