X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Fsone%2Ftemplate%2FProfileAccessor.java;h=366e071fde61c4143452351574b918035957638e;hp=8c7d1e4b8bd25e0502d501d2a4badd527bc42a8a;hb=577c7b884783c1c055a4da3663d1f55a2109b442;hpb=87b2b8dc5a94c2af3cee7a91c122a7240044cddf diff --git a/src/main/java/net/pterodactylus/sone/template/ProfileAccessor.java b/src/main/java/net/pterodactylus/sone/template/ProfileAccessor.java index 8c7d1e4..366e071 100644 --- a/src/main/java/net/pterodactylus/sone/template/ProfileAccessor.java +++ b/src/main/java/net/pterodactylus/sone/template/ProfileAccessor.java @@ -61,11 +61,12 @@ public class ProfileAccessor extends ReflectionAccessor { return null; } String avatarId = profile.getAvatar(); - if (avatarId != null) { - if (core.getImage(avatarId, false) == null) { - /* avatar ID but no matching image? show nothing. */ - return null; - } + if (avatarId == null) { + return null; + } + if (core.getImage(avatarId, false) == null) { + /* avatar ID but no matching image? show nothing. */ + return null; } Sone remoteSone = profile.getSone(); if (core.isLocalSone(remoteSone)) { @@ -76,11 +77,11 @@ public class ProfileAccessor extends ReflectionAccessor { if (showCustomAvatars == ShowCustomAvatars.NEVER) { return null; } - if ((showCustomAvatars == ShowCustomAvatars.ALWAYS) || (avatarId == null)) { + if (showCustomAvatars == ShowCustomAvatars.ALWAYS) { return avatarId; } - if ((showCustomAvatars == ShowCustomAvatars.FOLLOWED) && currentSone.hasFriend(remoteSone.getId())) { - return avatarId; + if (showCustomAvatars == ShowCustomAvatars.FOLLOWED) { + return currentSone.hasFriend(remoteSone.getId()) ? avatarId : null; } Trust trust = core.getTrust(currentSone, remoteSone); if (trust == null) { @@ -89,7 +90,7 @@ public class ProfileAccessor extends ReflectionAccessor { if ((showCustomAvatars == ShowCustomAvatars.MANUALLY_TRUSTED) && (trust.getExplicit() != null) && (trust.getExplicit() > 0)) { return avatarId; } - if ((showCustomAvatars == ShowCustomAvatars.TRUSTED) && ((trust.getExplicit() != null) && (trust.getExplicit() > 0)) || ((trust.getImplicit() != null) && (trust.getImplicit() > 0))) { + if ((showCustomAvatars == ShowCustomAvatars.TRUSTED) && (((trust.getExplicit() != null) && (trust.getExplicit() > 0)) || ((trust.getImplicit() != null) && (trust.getImplicit() > 0)))) { return avatarId; } return null;