X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Fmain%2Fjava%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpage%2FFreenetTemplatePage.java;h=a9710ee9379b19b366c316a1871cb3d63a0a76d5;hp=cd15cbf99812d3db8af8544be84b7622f1ee43e5;hb=62573c314957b1851f4fbe693b8746686caa940a;hpb=c9e306ac8e3ada846e87a0cc256a20fc148f381c

diff --git a/src/main/java/net/pterodactylus/sone/web/page/FreenetTemplatePage.java b/src/main/java/net/pterodactylus/sone/web/page/FreenetTemplatePage.java
index cd15cbf..a9710ee 100644
--- a/src/main/java/net/pterodactylus/sone/web/page/FreenetTemplatePage.java
+++ b/src/main/java/net/pterodactylus/sone/web/page/FreenetTemplatePage.java
@@ -1,5 +1,5 @@
 /*
- * Sone - FreenetTemplatePage.java - Copyright © 2010 David Roden
+ * Sone - FreenetTemplatePage.java - Copyright © 2010–2016 David Roden
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,6 +17,9 @@
 
 package net.pterodactylus.sone.web.page;
 
+import static java.lang.String.format;
+import static java.util.logging.Logger.getLogger;
+
 import java.io.IOException;
 import java.io.StringWriter;
 import java.net.URI;
@@ -28,7 +31,6 @@ import java.util.Map.Entry;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import net.pterodactylus.util.logging.Logging;
 import net.pterodactylus.util.template.Template;
 import net.pterodactylus.util.template.TemplateContext;
 import net.pterodactylus.util.template.TemplateContextFactory;
@@ -45,13 +47,11 @@ import freenet.support.HTMLNode;
 /**
  * Base class for all {@link Page}s that are rendered with {@link Template}s and
  * fit into Freenet’s web interface.
- *
- * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
  */
 public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 
 	/** The logger. */
-	private static final Logger logger = Logging.getLogger(FreenetTemplatePage.class);
+	private static final Logger logger = getLogger(FreenetTemplatePage.class.getName());
 
 	/** The path of the page. */
 	private final String path;
@@ -100,6 +100,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 *            The request to serve
 	 * @return The title of the page
 	 */
+	@SuppressWarnings("static-method")
 	protected String getPageTitle(FreenetRequest request) {
 		return null;
 	}
@@ -116,7 +117,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 * {@inheritDoc}
 	 */
 	@Override
-	public Response handleRequest(FreenetRequest request, Response response) throws IOException {
+	public final Response handleRequest(FreenetRequest request, Response response) throws IOException {
 		String redirectTarget = getRedirectTarget(request);
 		if (redirectTarget != null) {
 			return new RedirectResponse(redirectTarget);
@@ -155,7 +156,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 			long start = System.nanoTime();
 			processTemplate(request, templateContext);
 			long finish = System.nanoTime();
-			logger.log(Level.FINEST, "Template was rendered in %dms.", ((finish - start) / 1000) / 1000.0);
+			logger.log(Level.FINEST, format("Template was rendered in %.2fms.", (finish - start) / 1000000.0));
 		} catch (RedirectException re1) {
 			return new RedirectResponse(re1.getTarget());
 		}
@@ -175,6 +176,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 *
 	 * @return Additional style sheets to load
 	 */
+	@SuppressWarnings("static-method")
 	protected Collection<String> getStyleSheets() {
 		return Collections.emptySet();
 	}
@@ -184,6 +186,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 *
 	 * @return The URL of the shortcut icon, or {@code null} for no icon
 	 */
+	@SuppressWarnings("static-method")
 	protected String getShortcutIcon() {
 		return null;
 	}
@@ -227,6 +230,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 *            The request that is processed
 	 * @return The URL to redirect to, or {@code null} to not redirect
 	 */
+	@SuppressWarnings("static-method")
 	protected String getRedirectTarget(FreenetRequest request) {
 		return null;
 	}
@@ -238,6 +242,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 *            The request for which to return the link nodes
 	 * @return All link nodes that should be added to the HTML head
 	 */
+	@SuppressWarnings("static-method")
 	protected List<Map<String, String>> getAdditionalLinkNodes(FreenetRequest request) {
 		return Collections.emptyList();
 	}
@@ -249,6 +254,7 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 * @return {@code true} if this page should only be allowed for hosts with
 	 *         full access, {@code false} to allow this page for any host
 	 */
+	@SuppressWarnings("static-method")
 	protected boolean isFullAccessOnly() {
 		return false;
 	}
@@ -278,8 +284,6 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 	 * wants to redirect the user during the
 	 * {@link FreenetTemplatePage#processTemplate(FreenetRequest, TemplateContext)}
 	 * method call.
-	 *
-	 * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
 	 */
 	public static class RedirectException extends Exception {
 
@@ -305,6 +309,11 @@ public class FreenetTemplatePage implements FreenetPage, LinkEnabledCallback {
 			return target;
 		}
 
+		@Override
+		public String toString() {
+			return format("RedirectException{target='%s'}", target);
+		}
+
 	}
 
 }