X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Fmain%2Fresources%2Fstatic%2Fjavascript%2Fsone.js;h=efd72a50d57cbc6f64894bcbe4dd605738f12e17;hp=a003780e14f85e7c1a0123162f3d4caea6807789;hb=0e3bd6583c5e987027e3a50a61547dd23ee3ea30;hpb=972ca0e1490124c9da45a12ee9a079d91d62d6dc diff --git a/src/main/resources/static/javascript/sone.js b/src/main/resources/static/javascript/sone.js index a003780..efd72a5 100644 --- a/src/main/resources/static/javascript/sone.js +++ b/src/main/resources/static/javascript/sone.js @@ -2,13 +2,13 @@ function ajaxGet(url, data, successCallback, errorCallback) { (function(url, data, successCallback, errorCallback) { - $.ajax({"cache": false, "type": "GET", "url": url, "data": data, "dataType": "json", "success": function(data, textStatus, xmlHttpRequest) { + $.ajax({"cache": false, "type": "GET", "url": url, "data": data, "dataType": "json", "success": function(data, textStatus) { ajaxSuccess(); if (typeof successCallback != "undefined") { successCallback(data, textStatus); } - }, "error": function(xmlHttpRequest, textStatus, errorThrown) { - if (xmlHttpRequest.status == 403) { + }, "error": function(xmlHttpRequest) { + if (xmlHttpRequest.status === 403) { notLoggedIn = true; } if (typeof errorCallback != "undefined") { @@ -23,7 +23,7 @@ function ajaxGet(url, data, successCallback, errorCallback) { function registerInputTextareaSwap(inputElement, defaultText, inputFieldName, optional, dontUseTextarea) { $(inputElement).each(function() { var textarea = $(dontUseTextarea ? "" : "").blur(function() { - if ($(this).val() == "") { + if ($(this).val() === "") { $(this).hide(); var inputField = $(this).data("inputField"); inputField.show().removeAttr("disabled").addClass("default"); @@ -33,20 +33,20 @@ function registerInputTextareaSwap(inputElement, defaultText, inputFieldName, op $(this).data("textarea", textarea).after(textarea); (function(inputField, textarea) { inputField.focus(function() { - $(this).hide().attr("disabled", "disabled"); + $(this).hide().prop("disabled", "disabled"); /* no, show(), “display: block” is not what I need. */ - textarea.attr("style", "display: inline").focus(); + textarea.prop("style", "display: inline").focus(); }); - if (inputField.val() == "") { + if (inputField.val() === "") { inputField.addClass("default"); inputField.val(defaultText); } else { - inputField.hide().attr("disabled", "disabled"); + inputField.hide().prop("disabled", "disabled"); textarea.show(); } $(inputField.get(0).form).submit(function() { - inputField.attr("disabled", "disabled"); - if (!optional && (textarea.val() == "")) { + inputField.prop("disabled", "disabled"); + if (!optional && (textarea.val() === "")) { inputField.removeAttr("disabled").focus(); return false; } @@ -64,7 +64,7 @@ function registerInputTextareaSwap(inputElement, defaultText, inputFieldName, op * The element to add a “comment” link to */ function addCommentLink(postId, author, element, insertAfterThisElement) { - if (($(element).find(".show-reply-form").length > 0) || (getPostElement(element).find(".create-reply").length == 0)) { + if (($(element).find(".show-reply-form").length > 0) || (getPostElement(element).find(".create-reply").length === 0)) { return; } (function(postId, author, insertAfterThisElement) { @@ -84,7 +84,7 @@ function addCommentLink(postId, author, element, insertAfterThisElement) { }); })(replyElement); var textArea = replyElement.find(":input.reply-input").focus().data("textarea"); - if (author != getCurrentSoneId()) { + if (author !== getCurrentSoneId()) { textArea.val(textArea.val() + "@sone://" + author + " "); } }); @@ -110,7 +110,7 @@ function getTranslation(key, callback) { callback(translations[key]); return; } - ajaxGet("getTranslation.ajax", {"key": key}, function(data, textStatus) { + ajaxGet("getTranslation.ajax", {"key": key}, function(data) { if ((data != null) && data.success) { translations[key] = data.value; callback(data.value); @@ -146,15 +146,15 @@ function filterSoneId(soneId) { */ function updateSoneStatus(soneId, name, status, modified, locked, lastUpdated, lastUpdatedText) { var updateSone = sone.find(".sone." + filterSoneId(soneId)); - updateSone.toggleClass("unknown", status == "unknown"). - toggleClass("idle", status == "idle"). - toggleClass("inserting", status == "inserting"). - toggleClass("downloading", status == "downloading"). + updateSone.toggleClass("unknown", status === "unknown"). + toggleClass("idle", status === "idle"). + toggleClass("inserting", status === "inserting"). + toggleClass("downloading", status === "downloading"). toggleClass("modified", modified); updateSone.find(".lock").toggleClass("hidden", locked); updateSone.find(".unlock").toggleClass("hidden", !locked); if (lastUpdated != null) { - updateSone.find(".last-update span.time").attr("title", lastUpdated).text(lastUpdatedText); + updateSone.find(".last-update span.time").prop("title", lastUpdated).text(lastUpdatedText); } else { getTranslation("View.Sone.Text.UnknownDate", function(unknown) { updateSone.find(".last-update span.time").text(unknown); @@ -185,7 +185,7 @@ function enhanceDeleteButton(button, text, deleteCallback) { button.fadeOut("slow", function() { newButton.fadeIn("slow"); $(document).one("click", function() { - if (this != newButton.get(0)) { + if (this !== newButton.get(0)) { newButton.fadeOut(function() { button.fadeIn(); }); @@ -210,21 +210,21 @@ function enhanceDeleteButton(button, text, deleteCallback) { */ function enhanceDeletePostButton(button, postId, text) { enhanceDeleteButton(button, text, function() { - ajaxGet("deletePost.ajax", { "post": postId, "formPassword": getFormPassword() }, function(data, textStatus) { + ajaxGet("deletePost.ajax", { "post": postId, "formPassword": getFormPassword() }, function(data) { if (data == null) { return; } if (data.success) { sone.find(".post#post-" + postId).slideUp(); - } else if (data.error == "invalid-post-id") { + } else if (data.error === "invalid-post-id") { /* pretend the post is already gone. */ getPost(postId).slideUp(); - } else if (data.error == "auth-required") { + } else if (data.error === "auth-required") { alert("You need to be logged in."); - } else if (data.error == "not-authorized") { + } else if (data.error === "not-authorized") { alert("You are not allowed to delete this post."); } - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); }); @@ -242,21 +242,21 @@ function enhanceDeletePostButton(button, postId, text) { */ function enhanceDeleteReplyButton(button, replyId, text) { enhanceDeleteButton(button, text, function() { - ajaxGet("deleteReply.ajax", { "reply": replyId, "formPassword": sone.find("#formPassword").text() }, function(data, textStatus) { + ajaxGet("deleteReply.ajax", { "reply": replyId, "formPassword": sone.find("#formPassword").text() }, function(data) { if (data == null) { return; } if (data.success) { sone.find(".reply#reply-" + replyId).slideUp(); - } else if (data.error == "invalid-reply-id") { + } else if (data.error === "invalid-reply-id") { /* pretend the reply is already gone. */ getReply(replyId).slideUp(); - } else if (data.error == "auth-required") { + } else if (data.error === "auth-required") { alert("You need to be logged in."); - } else if (data.error == "not-authorized") { + } else if (data.error === "not-authorized") { alert("You are not allowed to delete this reply."); } - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); }); @@ -274,8 +274,8 @@ function getFormPassword() { * @returns All Sone elements with the given ID */ function getSone(soneId) { - return sone.find(".sone").filter(function(index) { - return $(".id", this).text() == soneId; + return sone.find(".sone").filter(function() { + return $(".id", this).text() === soneId; }); } @@ -297,21 +297,14 @@ function getMenuSone(element) { /** * Generates a list of Sones by concatening the names of the given sones with a - * new line character (“\n”). + * comma. * * @param sones * The sones to format * @returns {String} The created string */ function generateSoneList(sones) { - var soneList = ""; - $.each(sones, function() { - if (soneList != "") { - soneList += ", "; - } - soneList += this.name; - }); - return soneList; + return sones.reduce((soneList, sone) => soneList + ", " + sone.name, "").substring(2) } /** @@ -341,7 +334,7 @@ function getPostElement(element) { } function getPostId(element) { - return getPostElement(element).attr("id").substr(5); + return getPostElement(element).prop("id").substr(5); } function getPostTime(element) { @@ -375,7 +368,7 @@ function getReplyElement(element) { } function getReplyId(element) { - return getReplyElement(element).attr("id").substr(6); + return getReplyElement(element).prop("id").substr(6); } function getReplyTime(element) { @@ -423,7 +416,7 @@ function getNotificationElement(element) { * @returns The ID of the notification */ function getNotificationId(notificationElement) { - return $(notificationElement).attr("id"); + return $(notificationElement).prop("id"); } /** @@ -434,69 +427,69 @@ function getNotificationId(notificationElement) { * @returns The last update time of the notification */ function getNotificationLastUpdatedTime(notificationElement) { - return $(notificationElement).attr("lastUpdatedTime"); + return $(notificationElement).prop("lastUpdatedTime"); } function likePost(postId) { - ajaxGet("like.ajax", { "type": "post", "post" : postId, "formPassword": getFormPassword() }, function(data, textStatus) { + ajaxGet("like.ajax", { "type": "post", "post" : postId, "formPassword": getFormPassword() }, function(data) { if ((data == null) || !data.success) { return; } sone.find(".post#post-" + postId + " > .inner-part > .status-line .like").addClass("hidden"); sone.find(".post#post-" + postId + " > .inner-part > .status-line .unlike").removeClass("hidden"); updatePostLikes(postId); - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } function unlikePost(postId) { - ajaxGet("unlike.ajax", { "type": "post", "post" : postId, "formPassword": getFormPassword() }, function(data, textStatus) { + ajaxGet("unlike.ajax", { "type": "post", "post" : postId, "formPassword": getFormPassword() }, function(data) { if ((data == null) || !data.success) { return; } sone.find(".post#post-" + postId + " > .inner-part > .status-line .unlike").addClass("hidden"); sone.find(".post#post-" + postId + " > .inner-part > .status-line .like").removeClass("hidden"); updatePostLikes(postId); - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } function updatePostLikes(postId) { - ajaxGet("getLikes.ajax", { "type": "post", "post": postId }, function(data, textStatus) { + ajaxGet("getLikes.ajax", { "type": "post", "post": postId }, function(data) { if ((data != null) && data.success) { - sone.find(".post#post-" + postId + " > .inner-part > .status-line .likes").toggleClass("hidden", data.likes == 0); + sone.find(".post#post-" + postId + " > .inner-part > .status-line .likes").toggleClass("hidden", data.likes === 0); sone.find(".post#post-" + postId + " > .inner-part > .status-line .likes span.like-count").text(data.likes); - sone.find(".post#post-" + postId + " > .inner-part > .status-line .likes > span").attr("title", generateSoneList(data.sones)); + sone.find(".post#post-" + postId + " > .inner-part > .status-line .likes > span").prop("title", generateSoneList(data.sones)); } - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } function likeReply(replyId) { - ajaxGet("like.ajax", { "type": "reply", "reply" : replyId, "formPassword": getFormPassword() }, function(data, textStatus) { + ajaxGet("like.ajax", { "type": "reply", "reply" : replyId, "formPassword": getFormPassword() }, function(data) { if ((data == null) || !data.success) { return; } sone.find(".reply#reply-" + replyId + " .status-line .like").addClass("hidden"); sone.find(".reply#reply-" + replyId + " .status-line .unlike").removeClass("hidden"); updateReplyLikes(replyId); - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } function unlikeReply(replyId) { - ajaxGet("unlike.ajax", { "type": "reply", "reply" : replyId, "formPassword": getFormPassword() }, function(data, textStatus) { + ajaxGet("unlike.ajax", { "type": "reply", "reply" : replyId, "formPassword": getFormPassword() }, function(data) { if ((data == null) || !data.success) { return; } sone.find(".reply#reply-" + replyId + " .status-line .unlike").addClass("hidden"); sone.find(".reply#reply-" + replyId + " .status-line .like").removeClass("hidden"); updateReplyLikes(replyId); - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } @@ -508,7 +501,7 @@ function unlikeReply(replyId) { * The ID of the Sone to trust */ function trustSone(soneId) { - ajaxGet("trustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data, textStatus) { + ajaxGet("trustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data) { if ((data != null) && data.success) { updateTrustControls(soneId, data.trustValue); } @@ -522,7 +515,7 @@ function trustSone(soneId) { * The ID of the Sone to distrust */ function distrustSone(soneId) { - ajaxGet("distrustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data, textStatus) { + ajaxGet("distrustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data) { if ((data != null) && data.success) { updateTrustControls(soneId, data.trustValue); } @@ -536,7 +529,7 @@ function distrustSone(soneId) { * The ID of the Sone to untrust */ function untrustSone(soneId) { - ajaxGet("untrustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data, textStatus) { + ajaxGet("untrustSone.ajax", { "formPassword" : getFormPassword(), "sone" : soneId }, function(data) { if ((data != null) && data.success) { updateTrustControls(soneId, data.trustValue); } @@ -554,14 +547,14 @@ function untrustSone(soneId) { */ function updateTrustControls(soneId, trustValue) { sone.find(".post").each(function() { - if (getPostAuthor(this) == soneId) { + if (getPostAuthor(this) === soneId) { getPostElement(this).find(".post-trust").toggleClass("hidden", trustValue != null); getPostElement(this).find(".post-distrust").toggleClass("hidden", trustValue != null); getPostElement(this).find(".post-untrust").toggleClass("hidden", trustValue == null); } }); sone.find(".reply").each(function() { - if (getReplyAuthor(this) == soneId) { + if (getReplyAuthor(this) === soneId) { getReplyElement(this).find(".reply-trust").toggleClass("hidden", trustValue != null); getReplyElement(this).find(".reply-distrust").toggleClass("hidden", trustValue != null); getReplyElement(this).find(".reply-untrust").toggleClass("hidden", trustValue == null); @@ -577,7 +570,7 @@ function updateTrustControls(soneId, trustValue) { */ function bookmarkPost(postId) { (function(postId) { - ajaxGet("bookmark.ajax", {"formPassword": getFormPassword(), "type": "post", "post": postId}, function(data, textStatus) { + ajaxGet("bookmark.ajax", {"formPassword": getFormPassword(), "type": "post", "post": postId}, function(data) { if ((data != null) && data.success) { getPost(postId).find(".bookmark").toggleClass("hidden", true); getPost(postId).find(".unbookmark").toggleClass("hidden", false); @@ -593,7 +586,7 @@ function bookmarkPost(postId) { * The ID of the post to unbookmark */ function unbookmarkPost(postId) { - ajaxGet("unbookmark.ajax", {"formPassword": getFormPassword(), "type": "post", "post": postId}, function(data, textStatus) { + ajaxGet("unbookmark.ajax", {"formPassword": getFormPassword(), "type": "post", "post": postId}, function(data) { if ((data != null) && data.success) { getPost(postId).find(".bookmark").toggleClass("hidden", false); getPost(postId).find(".unbookmark").toggleClass("hidden", true); @@ -602,13 +595,13 @@ function unbookmarkPost(postId) { } function updateReplyLikes(replyId) { - ajaxGet("getLikes.ajax", { "type": "reply", "reply": replyId }, function(data, textStatus) { + ajaxGet("getLikes.ajax", { "type": "reply", "reply": replyId }, function(data) { if ((data != null) && data.success) { - sone.find(".reply#reply-" + replyId + " .status-line .likes").toggleClass("hidden", data.likes == 0); + sone.find(".reply#reply-" + replyId + " .status-line .likes").toggleClass("hidden", data.likes === 0); sone.find(".reply#reply-" + replyId + " .status-line .likes span.like-count").text(data.likes); - sone.find(".reply#reply-" + replyId + " .status-line .likes > span").attr("title", generateSoneList(data.sones)); + sone.find(".reply#reply-" + replyId + " .status-line .likes > span").prop("title", generateSoneList(data.sones)); } - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } @@ -627,7 +620,7 @@ function updateReplyLikes(replyId) { * parameters: success, error, replyId) */ function postReply(sender, postId, text, callbackFunction) { - ajaxGet("createReply.ajax", { "formPassword" : getFormPassword(), "sender": sender, "post" : postId, "text": text }, function(data, textStatus) { + ajaxGet("createReply.ajax", { "formPassword" : getFormPassword(), "sender": sender, "post" : postId, "text": text }, function(data) { if (data == null) { /* TODO - show error */ return; @@ -637,7 +630,7 @@ function postReply(sender, postId, text, callbackFunction) { } else { callbackFunction(false, data.error); } - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); } @@ -704,7 +697,7 @@ function ajaxifyPost(postElement) { }); $(postElement).find(".create-reply button:submit").click(function() { var button = $(this); - button.attr("disabled", "disabled"); + button.prop("disabled", "disabled"); var sender = $(this.form).find(":input[name=sender]").val(); var inputField = $(this.form).find(":input[name=text]:enabled").get(0); var postId = getPostId(this); @@ -815,7 +808,7 @@ function ajaxifyPost(postElement) { $(".post-status-line .permalink a", postElement).click(function() { if (!$(".create-reply", postElement).hasClass("hidden")) { var textArea = $(":input.reply-input", postElement).focus().data("textarea"); - $(textArea).replaceSelection($(this).attr("href")); + $(textArea).replaceSelection($(this).prop("href")); } return false; }); @@ -862,7 +855,7 @@ function ajaxifyPost(postElement) { /* show Sone menu when hovering over the avatar. */ $(postElement).find(".post-avatar").mouseover(function() { - if (typeof currentSoneMenuTimeoutHandler != undefined) { + if (typeof currentSoneMenuTimeoutHandler !== undefined) { clearTimeout(currentSoneMenuTimeoutHandler); } currentSoneMenuId = getPostId(this); @@ -873,7 +866,7 @@ function ajaxifyPost(postElement) { }).fadeIn(); }, 1000); }).mouseleave(function() { - if (currentSoneMenuId == getPostId(this)) { + if (currentSoneMenuId === getPostId(this)) { clearTimeout(currentSoneMenuTimeoutHandler); } }); @@ -885,7 +878,7 @@ function ajaxifyPost(postElement) { $(followElement).addClass("hidden"); $(followElement).parent().find(".unfollow").removeClass("hidden"); sone.find(".sone-menu").each(function() { - if (getMenuSone(this) == soneId) { + if (getMenuSone(this) === soneId) { $(".follow", this).toggleClass("hidden", true); $(".unfollow", this).toggleClass("hidden", false); } @@ -899,7 +892,7 @@ function ajaxifyPost(postElement) { $(unfollowElement).addClass("hidden"); $(unfollowElement).parent().find(".follow").removeClass("hidden"); sone.find(".sone-menu").each(function() { - if (getMenuSone(this) == soneId) { + if (getMenuSone(this) === soneId) { $(".follow", this).toggleClass("hidden", false); $(".unfollow", this).toggleClass("hidden", true); } @@ -937,7 +930,7 @@ function ajaxifyReply(replyElement) { $(".reply-status-line .permalink a", replyElement).click(function() { if (!$(".create-reply", getPostElement(replyElement)).hasClass("hidden")) { var textArea = $(":input.reply-input", getPostElement(replyElement)).focus().data("textarea"); - $(textArea).replaceSelection($(this).attr("href")); + $(textArea).replaceSelection($(this).prop("href")); } return false; }); @@ -1001,7 +994,7 @@ function ajaxifyReply(replyElement) { /* show Sone menu when hovering over the avatar. */ $(replyElement).find(".reply-avatar").mouseover(function() { - if (typeof currentSoneMenuTimeoutHandler != undefined) { + if (typeof currentSoneMenuTimeoutHandler !== undefined) { clearTimeout(currentSoneMenuTimeoutHandler); } currentSoneMenuId = getPostId(this) + "-" + getReplyId(this); @@ -1012,7 +1005,7 @@ function ajaxifyReply(replyElement) { }).fadeIn(); }, 1000); }).mouseleave(function() { - if (currentSoneMenuId == getPostId(this) + "-" + getReplyId(this)) { + if (currentSoneMenuId === getPostId(this) + "-" + getReplyId(this)) { clearTimeout(currentSoneMenuTimeoutHandler); } }); @@ -1024,7 +1017,7 @@ function ajaxifyReply(replyElement) { $(followElement).addClass("hidden"); $(followElement).parent().find(".unfollow").removeClass("hidden"); sone.find(".sone-menu").each(function() { - if (getMenuSone(this) == soneId) { + if (getMenuSone(this) === soneId) { $(".follow", this).toggleClass("hidden", true); $(".unfollow", this).toggleClass("hidden", false); } @@ -1038,7 +1031,7 @@ function ajaxifyReply(replyElement) { $(unfollowElement).addClass("hidden"); $(unfollowElement).parent().find(".follow").removeClass("hidden"); sone.find(".sone-menu").each(function() { - if (getMenuSone(this) == soneId) { + if (getMenuSone(this) === soneId) { $(".follow", this).toggleClass("hidden", false); $(".unfollow", this).toggleClass("hidden", true); } @@ -1074,17 +1067,17 @@ function ajaxifyNotification(notification) { notification.find("a[class^='link-']").each(function() { var linkElement = $(this); if (linkElement.is("[href^='viewPost']")) { - var id = linkElement.attr("class").substr(5); + var id = linkElement.prop("class").substr(5); if (hasPost(id)) { - linkElement.attr("href", "#post-" + id).addClass("in-page-link"); + linkElement.prop("href", "#post-" + id).addClass("in-page-link"); } } }); notification.find("form.dismiss button").click(function() { - ajaxGet("dismissNotification.ajax", { "formPassword" : getFormPassword(), "notification" : notification.attr("id") }, function(data, textStatus) { + ajaxGet("dismissNotification.ajax", { "formPassword" : getFormPassword(), "notification" : notification.prop("id") }, function() { /* dismiss in case of error, too. */ notification.slideUp(); - }, function(xmlHttpRequest, textStatus, error) { + }, function() { /* ignore error. */ }); }); @@ -1136,13 +1129,13 @@ function getElementIds(notification, selector) { * The new notification element */ function checkForRemovedSones(oldNotification, newNotification) { - if (getNotificationId(oldNotification) != "new-sone-notification") { + if (getNotificationId(oldNotification) !== "new-sone-notification") { return; } var oldIds = getElementIds(oldNotification, ".new-sone-id"); var newIds = getElementIds(newNotification, ".new-sone-id"); $.each(oldIds, function(index, value) { - if ($.inArray(value, newIds) == -1) { + if ($.inArray(value, newIds) === -1) { markSoneAsKnown(getSone(value), true); } }); @@ -1158,13 +1151,13 @@ function checkForRemovedSones(oldNotification, newNotification) { * The new notification element */ function checkForRemovedPosts(oldNotification, newNotification) { - if (getNotificationId(oldNotification) != "new-post-notification") { + if (getNotificationId(oldNotification) !== "new-post-notification") { return; } var oldIds = getElementIds(oldNotification, ".post-id"); var newIds = getElementIds(newNotification, ".post-id"); $.each(oldIds, function(index, value) { - if ($.inArray(value, newIds) == -1) { + if ($.inArray(value, newIds) === -1) { markPostAsKnown(getPost(value), true); } }); @@ -1181,13 +1174,13 @@ function checkForRemovedPosts(oldNotification, newNotification) { * The new notification element */ function checkForRemovedReplies(oldNotification, newNotification) { - if (getNotificationId(oldNotification) != "new-reply-notification") { + if (getNotificationId(oldNotification) !== "new-reply-notification") { return; } var oldIds = getElementIds(oldNotification, ".reply-id"); var newIds = getElementIds(newNotification, ".reply-id"); $.each(oldIds, function(index, value) { - if ($.inArray(value, newIds) == -1) { + if ($.inArray(value, newIds) === -1) { markReplyAsKnown(getReply(value), true); } }); @@ -1197,10 +1190,10 @@ function getStatus() { var parameters = isViewSonePage() ? {"soneIds": getShownSoneId() } : isKnownSonesPage() ? {"soneIds": getShownSoneIds() } : {}; $.extend(parameters, { "elements": JSON.stringify($(".linked-element.not-loaded").map(function () { - return $(this).attr("title"); + return $(this).prop("title"); }).toArray()) }); - ajaxGet("getStatus.ajax", parameters, function(data, textStatus) { + ajaxGet("getStatus.ajax", parameters, function(data) { if ((data != null) && data.success) { /* process Sone information. */ $.each(data.sones, function(index, value) { @@ -1210,7 +1203,7 @@ function getStatus() { if (!notLoggedIn) { showOfflineMarker(!online); } - if (data.notificationHash != getNotificationHash()) { + if (data.notificationHash !== getNotificationHash()) { console.log("Old hash: ", getNotificationHash(), ", new hash: ", data.notificationHash); requestNotifications(); /* process new posts. */ @@ -1219,7 +1212,7 @@ function getStatus() { }); /* process new replies. */ $.each(data.newReplies, function(index, value) { - loadNewReply(value.id, value.sone, value.post, value.postSone); + loadNewReply(value.id, value.sone, value.post); }); } if (data.linkedElements) { @@ -1238,31 +1231,31 @@ function getStatus() { } function requestNotifications() { - ajaxGet("getNotifications.ajax", {}, function(data, textStatus) { + ajaxGet("getNotifications.ajax", {}, function(data) { if (data && data.success) { /* search for removed notifications. */ sone.find("#notification-area .notification").each(function() { - var notificationId = $(this).attr("id"); + var notificationId = $(this).prop("id"); var foundNotification = false; $.each(data.notifications, function(index, value) { - if (value.id == notificationId) { + if (value.id === notificationId) { foundNotification = true; return false; } }); if (!foundNotification) { - if (notificationId == "new-sone-notification" && (data.options["ShowNotification/NewSones"] == true)) { - $(".new-sone-id", this).each(function(index, element) { + if (notificationId === "new-sone-notification" && (data.options["ShowNotification/NewSones"] === true)) { + $(".new-sone-id", this).each(function() { var soneId = $(this).text(); markSoneAsKnown(getSone(soneId), true); }); - } else if (notificationId == "new-post-notification" && (data.options["ShowNotification/NewPosts"] == true)) { - $(".post-id", this).each(function(index, element) { + } else if (notificationId === "new-post-notification" && (data.options["ShowNotification/NewPosts"] === true)) { + $(".post-id", this).each(function() { var postId = $(this).text(); markPostAsKnown(getPost(postId), true); }); - } else if (notificationId == "new-reply-notification" && (data.options["ShowNotification/NewReplies"] == true)) { - $(".reply-id", this).each(function(index, element) { + } else if (notificationId === "new-reply-notification" && (data.options["ShowNotification/NewReplies"] === true)) { + $(".reply-id", this).each(function() { var replyId = $(this).text(); markReplyAsKnown(getReply(replyId), true); }); @@ -1270,7 +1263,7 @@ function requestNotifications() { $(this).slideUp("normal", function() { $(this).remove(); /* remove activity when no notifications are visible. */ - if (sone.find("#notification-area .notification").length == 0) { + if (sone.find("#notification-area .notification").length === 0) { resetActivity(); } }); @@ -1280,7 +1273,7 @@ function requestNotifications() { $.each(data.notifications, function(index, value) { var oldNotification = getNotification(value.id); var notification = ajaxifyNotification(createNotification(value.id, value.lastUpdatedTime, value.text, value.dismissable)).hide(); - if (oldNotification.length != 0) { + if (oldNotification.length !== 0) { if ((oldNotification.find(".short-text").length > 0) && (notification.find(".short-text").length > 0)) { var opened = oldNotification.is(":visible") && oldNotification.find(".short-text").hasClass("hidden"); notification.find(".short-text").toggleClass("hidden", opened); @@ -1292,7 +1285,7 @@ function requestNotifications() { oldNotification.replaceWith(notification.show()); } else { sone.find("#notification-area").append(notification); - if (value.id.substring(0, 5) != "local") { + if (value.id.substring(0, 5) !== "local") { notification.slideDown(); setActivity(); } @@ -1329,7 +1322,7 @@ function getPageId() { * false otherwise */ function isIndexPage() { - return getPageId() == "index"; + return getPageId() === "index"; } /** @@ -1355,7 +1348,7 @@ function getPage(paginationSelector) { * page, false otherwise */ function isViewSonePage() { - return getPageId() == "view-sone"; + return getPageId() === "view-sone"; } /** @@ -1389,7 +1382,7 @@ function getShownSoneIds() { * page, false otherwise */ function isViewPostPage() { - return getPageId() == "view-post"; + return getPageId() === "view-post"; } /** @@ -1409,7 +1402,7 @@ function getShownPostId() { * Sones” page, false otherwise */ function isKnownSonesPage() { - return getPageId() == "known-sones"; + return getPageId() === "known-sones"; } /** @@ -1441,8 +1434,8 @@ function loadNewPost(postId, soneId, recipientId, time) { return; } if (!isIndexPage() || (getPage(".pagination-index") > 1)) { - if (!isViewPostPage() || (getShownPostId() != postId)) { - if (!isViewSonePage() || ((getShownSoneId() != soneId) && (getShownSoneId() != recipientId)) || (getPage(".post-navigation") > 1)) { + if (!isViewPostPage() || (getShownPostId() !== postId)) { + if (!isViewSonePage() || ((getShownSoneId() !== soneId) && (getShownSoneId() !== recipientId)) || (getPage(".post-navigation") > 1)) { return; } } @@ -1450,12 +1443,12 @@ function loadNewPost(postId, soneId, recipientId, time) { if (getPostTime(sone.find(".post").last()) > time) { return; } - ajaxGet("getPost.ajax", { "post" : postId }, function(data, textStatus) { + ajaxGet("getPost.ajax", { "post" : postId }, function(data) { if ((data != null) && data.success) { if (hasPost(data.post.id)) { return; } - if ((!isIndexPage() || (getPage(".pagination-index") > 1)) && !(isViewSonePage() && ((getShownSoneId() == data.post.sone) || (getShownSoneId() == data.post.recipient) || (getPage(".post-navigation") > 1)))) { + if ((!isIndexPage() || (getPage(".pagination-index") > 1)) && !(isViewSonePage() && ((getShownSoneId() === data.post.sone) || (getShownSoneId() === data.post.recipient) || (getPage(".post-navigation") > 1)))) { return; } var firstOlderPost = null; @@ -1466,7 +1459,7 @@ function loadNewPost(postId, soneId, recipientId, time) { } }); var newPost = $(data.post.html).addClass("hidden"); - if ($(".post-author-local", newPost).text() == "true") { + if ($(".post-author-local", newPost).text() === "true") { newPost.removeClass("new"); } if (firstOlderPost != null) { @@ -1480,14 +1473,14 @@ function loadNewPost(postId, soneId, recipientId, time) { }); } -function loadNewReply(replyId, soneId, postId, postSoneId) { +function loadNewReply(replyId, soneId, postId) { if (hasReply(replyId)) { return; } if (!hasPost(postId)) { return; } - ajaxGet("getReply.ajax", { "reply": replyId }, function(data, textStatus) { + ajaxGet("getReply.ajax", { "reply": replyId }, function(data) { /* find post. */ if ((data != null) && data.success) { if (hasReply(data.reply.id)) { @@ -1502,7 +1495,7 @@ function loadNewReply(replyId, soneId, postId, postSoneId) { } }); var newReply = $(data.reply.html).addClass("hidden"); - if ($(".reply-author-local", newReply).text() == "true") { + if ($(".reply-author-local", newReply).text() === "true") { newReply.removeClass("new"); (function(newReply) { setTimeout(function() { @@ -1535,7 +1528,9 @@ function loadLinkedElements(links) { }); if (failedElements.length > 0) { failedElements.forEach(function(element) { - $(getLinkedElement(element.link)).remove() + getLinkedElements(element.link).each(function() { + $(this).remove() + }); }); } var loadedElements = links.filter(function(element) { @@ -1546,18 +1541,20 @@ function loadLinkedElements(links) { "elements": JSON.stringify(loadedElements.map(function(element) { return element.link; })) - }, function (data, textStatus) { + }, function (data) { if ((data != null) && (data.success)) { data.linkedElements.forEach(function (linkedElement) { - $(getLinkedElement(linkedElement.link)).replaceWith(linkedElement.html); + getLinkedElements(linkedElement.link).each(function() { + $(this).replaceWith(linkedElement.html); + }); }); } }); } } -function getLinkedElement(link) { - return $(".linked-element[title='" + link + "']")[0] +function getLinkedElements(link) { + return $(".linked-element[title='" + link + "']") } /** @@ -1627,7 +1624,7 @@ function updatePostTime(postId, timeText, refreshTime, tooltip) { if (!getPost(postId).is(":visible")) { return; } - getPost(postId).find(".post-status-line > .time a").html(timeText).attr("title", tooltip); + getPost(postId).find(".post-status-line > .time a").html(timeText).prop("title", tooltip); (function(postId, refreshTime) { setTimeout(function() { updatePostTimes(postId); @@ -1642,13 +1639,15 @@ function updatePostTime(postId, timeText, refreshTime, tooltip) { * Comma-separated post IDs */ function updatePostTimes(postIds) { - ajaxGet("getTimes.ajax", { "posts" : postIds }, function(data, textStatus) { - if ((data != null) && data.success) { - $.each(data.postTimes, function(index, value) { - updatePostTime(index, value.timeText, value.refreshTime, value.tooltip); - }); - } - }); + if (postIds !== "") { + ajaxGet("getTimes.ajax", {"posts": postIds}, function (data) { + if ((data != null) && data.success) { + $.each(data.postTimes, function (index, value) { + updatePostTime(index, value.timeText, value.refreshTime, value.tooltip); + }); + } + }); + } } /** @@ -1664,7 +1663,7 @@ function updatePostTimes(postIds) { * The tooltip to show */ function updateReplyTime(replyId, timeText, refreshTime, tooltip) { - getReply(replyId).find(".reply-status-line > .time").html(timeText).attr("title", tooltip); + getReply(replyId).find(".reply-status-line > .time").html(timeText).prop("title", tooltip); (function(replyId, refreshTime) { setTimeout(function() { updateReplyTimes(replyId); @@ -1679,18 +1678,20 @@ function updateReplyTime(replyId, timeText, refreshTime, tooltip) { * Comma-separated post IDs */ function updateReplyTimes(replyIds) { - ajaxGet("getTimes.ajax", { "replies" : replyIds }, function(data, textStatus) { - if ((data != null) && data.success) { - $.each(data.replyTimes, function(index, value) { - updateReplyTime(index, value.timeText, value.refreshTime, value.tooltip); - }); - } - }); + if (replyIds !== "") { + ajaxGet("getTimes.ajax", {"replies": replyIds}, function (data) { + if ((data != null) && data.success) { + $.each(data.replyTimes, function (index, value) { + updateReplyTime(index, value.timeText, value.refreshTime, value.tooltip); + }); + } + }); + } } function resetActivity() { var title = document.title; - if (title.indexOf('(') == 0) { + if (title.indexOf('(') === 0) { setTitle(title.substr(title.indexOf(' ') + 1)); } iconBlinking = false; @@ -1699,7 +1700,7 @@ function resetActivity() { function setActivity() { if (!focus) { var title = document.title; - if (title.indexOf('(') != 0) { + if (title.indexOf('(') !== 0) { setTitle("(!) " + title); } if (!iconBlinking) { @@ -1753,7 +1754,7 @@ function toggleIcon() { */ function changeIcon(iconUrl) { $("link[rel=icon]").remove(); - $("head").append($("").attr("rel", "icon").attr("type", "image/png").attr("href", iconUrl)); + $("head").append($("").prop("rel", "icon").prop("type", "image/png").prop("href", iconUrl)); $("iframe[id=icon-update]")[0].src += ""; } @@ -1769,7 +1770,7 @@ function changeIcon(iconUrl) { * user */ function createNotification(id, lastUpdatedTime, text, dismissable) { - var notification = $("
").addClass("notification").attr("id", id).attr("lastUpdatedTime", lastUpdatedTime); + var notification = $("
").addClass("notification").prop("id", id).prop("lastUpdatedTime", lastUpdatedTime); if (dismissable) { var dismissForm = sone.find("#notification-area #notification-dismiss-template").clone().removeClass("hidden").removeAttr("id"); dismissForm.find("input[name=notification]").val(id); @@ -1797,7 +1798,7 @@ function showNotificationDetails(notificationId) { * The ID of the field to delete */ function deleteProfileField(fieldId) { - ajaxGet("deleteProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId}, function(data, textStatus) { + ajaxGet("deleteProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId}, function(data) { if (data && data.success) { sone.find(".profile-field#" + data.field.id).slideUp(); } @@ -1815,7 +1816,7 @@ function deleteProfileField(fieldId) { * Called when the renaming was successful */ function editProfileField(fieldId, newName, successFunction) { - ajaxGet("editProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId, "name": newName}, function(data, textStatus) { + ajaxGet("editProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId, "name": newName}, function(data) { if (data && data.success) { successFunction(); } @@ -1833,7 +1834,7 @@ function editProfileField(fieldId, newName, successFunction) { * Function to call on success */ function moveProfileField(fieldId, direction, successFunction) { - ajaxGet("moveProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId, "direction": direction}, function(data, textStatus) { + ajaxGet("moveProfileField.ajax", {"formPassword": getFormPassword(), "field": fieldId, "direction": direction}, function(data) { if (data && data.success) { successFunction(); } @@ -1910,7 +1911,7 @@ function showOfflineMarker(visible) { var sone = $("#sone"); var focus = true; var online = true; -var initiallyLoggedIn = sone.find("#loggedIn").text() == "true"; +var initiallyLoggedIn = sone.find("#loggedIn").text() === "true"; var notLoggedIn = !initiallyLoggedIn; /** ID of the next-to-show Sone context menu. */ @@ -1925,7 +1926,7 @@ $(document).ready(function() { sone.find(".rip-out").each(function() { var oldElement = $(this); var newElement = $(""); - newElement.attr("class", oldElement.attr("class")).attr("name", oldElement.attr("name")); + newElement.prop("class", oldElement.prop("class")).prop("name", oldElement.prop("name")); oldElement.before(newElement).remove(); }); @@ -1941,13 +1942,13 @@ $(document).ready(function() { }); sone.find("#update-status").submit(function() { var button = $("button:submit", this); - button.attr("disabled", "disabled"); + button.prop("disabled", "disabled"); if ($(this).find(":input.default:enabled").length > 0) { return false; } var sender = $(this).find(":input[name=sender]").val(); var text = $(this).find(":input[name=text]:enabled").val(); - ajaxGet("createPost.ajax", { "formPassword": getFormPassword(), "sender": sender, "text": text }, function(data, textStatus) { + ajaxGet("createPost.ajax", { "formPassword": getFormPassword(), "sender": sender, "text": text }, function() { button.removeAttr("disabled"); }); $(this).find(":input[name=sender]").val(getCurrentSoneId());