X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fjava%2Fnet%2Fpterodactylus%2Fsone%2Fcore%2FFreenetInterfaceTest.java;h=812d41f4cebc4e57231baa89cd226dd91e10511a;hp=c753740791c0c593a9b949f5760ed2d8ba8b878b;hb=35deb522de06ba7d97160445683375cf87529e8d;hpb=bf767ac0b8e02d82ca0253741f1c83ea10faef12 diff --git a/src/test/java/net/pterodactylus/sone/core/FreenetInterfaceTest.java b/src/test/java/net/pterodactylus/sone/core/FreenetInterfaceTest.java index c753740..812d41f 100644 --- a/src/test/java/net/pterodactylus/sone/core/FreenetInterfaceTest.java +++ b/src/test/java/net/pterodactylus/sone/core/FreenetInterfaceTest.java @@ -1,26 +1,27 @@ package net.pterodactylus.sone.core; -import static freenet.client.InsertException.CANCELLED; -import static freenet.client.InsertException.INTERNAL_ERROR; +import static freenet.client.FetchException.FetchExceptionMode.ALL_DATA_NOT_FOUND; import static freenet.keys.InsertableClientSSK.createRandom; import static freenet.node.RequestStarter.INTERACTIVE_PRIORITY_CLASS; import static freenet.node.RequestStarter.PREFETCH_PRIORITY_CLASS; -import static net.pterodactylus.sone.Matchers.delivers; -import static net.pterodactylus.sone.TestUtil.setFinalField; +import static net.pterodactylus.sone.test.Matchers.delivers; +import static net.pterodactylus.sone.test.TestUtil.setFinalField; import static org.hamcrest.MatcherAssert.assertThat; import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.notNullValue; import static org.hamcrest.Matchers.nullValue; import static org.mockito.ArgumentCaptor.forClass; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.anyBoolean; -import static org.mockito.Matchers.anyShort; -import static org.mockito.Matchers.eq; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyBoolean; +import static org.mockito.ArgumentMatchers.anyLong; +import static org.mockito.ArgumentMatchers.anyShort; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.doNothing; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.never; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.when; import static org.mockito.Mockito.withSettings; @@ -28,9 +29,8 @@ import java.io.IOException; import java.net.MalformedURLException; import java.util.HashMap; -import net.pterodactylus.sone.TestUtil; +import net.pterodactylus.sone.core.FreenetInterface.BackgroundFetchCallback; import net.pterodactylus.sone.core.FreenetInterface.Callback; -import net.pterodactylus.sone.core.FreenetInterface.Fetched; import net.pterodactylus.sone.core.FreenetInterface.InsertToken; import net.pterodactylus.sone.core.FreenetInterface.InsertTokenSupplier; import net.pterodactylus.sone.core.event.ImageInsertAbortedEvent; @@ -38,19 +38,27 @@ import net.pterodactylus.sone.core.event.ImageInsertFailedEvent; import net.pterodactylus.sone.core.event.ImageInsertFinishedEvent; import net.pterodactylus.sone.core.event.ImageInsertStartedEvent; import net.pterodactylus.sone.data.Image; -import net.pterodactylus.sone.data.impl.ImageImpl; import net.pterodactylus.sone.data.Sone; import net.pterodactylus.sone.data.TemporaryImage; -import net.pterodactylus.sone.freenet.StringBucket; +import net.pterodactylus.sone.data.impl.ImageImpl; +import net.pterodactylus.sone.test.TestUtil; import freenet.client.ClientMetadata; +import freenet.client.FetchContext; import freenet.client.FetchException; +import freenet.client.FetchException.FetchExceptionMode; import freenet.client.FetchResult; import freenet.client.HighLevelSimpleClient; import freenet.client.InsertBlock; import freenet.client.InsertContext; import freenet.client.InsertException; +import freenet.client.InsertException.InsertExceptionMode; +import freenet.client.Metadata; +import freenet.client.async.ClientContext; +import freenet.client.async.ClientGetCallback; +import freenet.client.async.ClientGetter; import freenet.client.async.ClientPutter; +import freenet.client.async.SnoopMetadata; import freenet.client.async.USKCallback; import freenet.client.async.USKManager; import freenet.crypt.DummyRandomSource; @@ -63,11 +71,14 @@ import freenet.node.NodeClientCore; import freenet.node.RequestClient; import freenet.support.Base64; import freenet.support.api.Bucket; +import freenet.support.io.ArrayBucket; +import freenet.support.io.ResumeFailedException; import com.google.common.eventbus.EventBus; import org.junit.Before; import org.junit.Test; import org.mockito.ArgumentCaptor; +import org.mockito.ArgumentMatchers; /** * Unit test for {@link FreenetInterface}. @@ -87,6 +98,21 @@ public class FreenetInterfaceTest { private final ArgumentCaptor callbackCaptor = forClass(USKCallback.class); private final Image image = mock(Image.class); private InsertToken insertToken; + private final Bucket bucket = mock(Bucket.class); + private final ArgumentCaptor clientGetCallback = forClass(ClientGetCallback.class); + private final FreenetURI uri = new FreenetURI("KSK@pgl.png"); + private final FetchResult fetchResult = mock(FetchResult.class); + private final BackgroundFetchCallback backgroundFetchCallback = mock(BackgroundFetchCallback.class); + private final ClientGetter clientGetter = mock(ClientGetter.class); + + public FreenetInterfaceTest() throws MalformedURLException { + } + + @Before + public void setupHighLevelSimpleClient() throws Exception { + when(highLevelSimpleClient.getFetchContext()).thenReturn(mock(FetchContext.class)); + when(highLevelSimpleClient.fetch(eq(uri), anyLong(), any(ClientGetCallback.class), any(FetchContext.class), anyShort())).thenReturn( clientGetter); + } @Before public void setupFreenetInterface() { @@ -94,8 +120,10 @@ public class FreenetInterfaceTest { setFinalField(node, "clientCore", nodeClientCore); setFinalField(node, "random", randomSource); setFinalField(nodeClientCore, "uskManager", uskManager); + setFinalField(nodeClientCore, "clientContext", mock(ClientContext.class)); freenetInterface = new FreenetInterface(eventBus, node); insertToken = freenetInterface.new InsertToken(image); + insertToken.setBucket(bucket); } @Before @@ -126,7 +154,7 @@ public class FreenetInterfaceTest { FreenetURI freenetUri = new FreenetURI("KSK@GPLv2.txt"); FreenetURI newFreenetUri = new FreenetURI("KSK@GPLv3.txt"); FetchResult fetchResult = createFetchResult(); - FetchException fetchException = new FetchException(FetchException.PERMANENT_REDIRECT, newFreenetUri); + FetchException fetchException = new FetchException(FetchExceptionMode.PERMANENT_REDIRECT, newFreenetUri); when(highLevelSimpleClient.fetch(freenetUri)).thenThrow(fetchException); when(highLevelSimpleClient.fetch(newFreenetUri)).thenReturn(fetchResult); Fetched fetched = freenetInterface.fetchUri(freenetUri); @@ -137,7 +165,7 @@ public class FreenetInterfaceTest { @Test public void fetchReturnsNullOnFetchExceptions() throws MalformedURLException, FetchException { FreenetURI freenetUri = new FreenetURI("KSK@GPLv2.txt"); - FetchException fetchException = new FetchException(FetchException.ALL_DATA_NOT_FOUND); + FetchException fetchException = new FetchException(ALL_DATA_NOT_FOUND); when(highLevelSimpleClient.fetch(freenetUri)).thenThrow(fetchException); Fetched fetched = freenetInterface.fetchUri(freenetUri); assertThat(fetched, nullValue()); @@ -145,7 +173,7 @@ public class FreenetInterfaceTest { private FetchResult createFetchResult() { ClientMetadata clientMetadata = new ClientMetadata("text/plain"); - Bucket bucket = new StringBucket("Some Data."); + Bucket bucket = new ArrayBucket("Some Data.".getBytes()); return new FetchResult(clientMetadata, bucket); } @@ -161,7 +189,7 @@ public class FreenetInterfaceTest { when(highLevelSimpleClient.getInsertContext(anyBoolean())).thenReturn(insertContext); ClientPutter clientPutter = mock(ClientPutter.class); ArgumentCaptor insertBlockCaptor = forClass(InsertBlock.class); - when(highLevelSimpleClient.insert(insertBlockCaptor.capture(), eq(false), eq((String) null), eq(false), eq(insertContext), eq(insertToken), anyShort())).thenReturn(clientPutter); + when(highLevelSimpleClient.insert(insertBlockCaptor.capture(), eq((String) null), eq(false), eq(insertContext), eq(insertToken), anyShort())).thenReturn(clientPutter); freenetInterface.insertImage(temporaryImage, image, insertToken); assertThat(insertBlockCaptor.getValue().getData().getInputStream(), delivers(new byte[] { 1, 2, 3, 4 })); assertThat(TestUtil.getPrivateField(insertToken, "clientPutter"), is(clientPutter)); @@ -179,7 +207,7 @@ public class FreenetInterfaceTest { InsertContext insertContext = mock(InsertContext.class); when(highLevelSimpleClient.getInsertContext(anyBoolean())).thenReturn(insertContext); ArgumentCaptor insertBlockCaptor = forClass(InsertBlock.class); - when(highLevelSimpleClient.insert(insertBlockCaptor.capture(), eq(false), eq((String) null), eq(false), eq(insertContext), eq(insertToken), anyShort())).thenThrow(InsertException.class); + when(highLevelSimpleClient.insert(insertBlockCaptor.capture(), eq((String) null), eq(false), eq(insertContext), eq(insertToken), anyShort())).thenThrow(InsertException.class); freenetInterface.insertImage(temporaryImage, image, insertToken); } @@ -195,7 +223,7 @@ public class FreenetInterfaceTest { @Test(expected = SoneException.class) public void insertExceptionIsForwardedAsSoneException() throws InsertException, SoneException { - when(highLevelSimpleClient.insertManifest(any(FreenetURI.class), any(HashMap.class), any(String.class))).thenThrow(InsertException.class); + when(highLevelSimpleClient.insertManifest(ArgumentMatchers.any(), ArgumentMatchers.>any(), ArgumentMatchers.any())).thenThrow(InsertException.class); freenetInterface.insertDirectory(null, null, null); } @@ -242,7 +270,7 @@ public class FreenetInterfaceTest { public void registeringAnActiveNonUskWillNotSubscribeToAUsk() throws MalformedURLException { FreenetURI freenetUri = createRandom(randomSource, "test-0").getURI(); - freenetInterface.registerActiveUsk(freenetUri, null); + freenetInterface.registerActiveUsk(freenetUri, null); verify(uskManager, never()).subscribe(any(USK.class), any(USKCallback.class), anyBoolean(), eq((RequestClient) highLevelSimpleClient)); @@ -252,7 +280,7 @@ public class FreenetInterfaceTest { public void registeringAnInactiveNonUskWillNotSubscribeToAUsk() throws MalformedURLException { FreenetURI freenetUri = createRandom(randomSource, "test-0").getURI(); - freenetInterface.registerPassiveUsk(freenetUri, null); + freenetInterface.registerPassiveUsk(freenetUri, null); verify(uskManager, never()).subscribe(any(USK.class), any(USKCallback.class), anyBoolean(), eq((RequestClient) highLevelSimpleClient)); @@ -312,7 +340,7 @@ public class FreenetInterfaceTest { freenetInterface.registerUsk(uri, callback); USK key = mock(USK.class); when(key.getURI()).thenReturn(uri); - callbackCaptor.getValue().onFoundEdition(3, key, null, null, false, (short) 0, null, true, true); + callbackCaptor.getValue().onFoundEdition(3, key, null, false, (short) 0, null, true, true); verify(callback).editionFound(eq(uri), eq(3L), eq(true), eq(true)); } @@ -335,59 +363,151 @@ public class FreenetInterfaceTest { insertToken.cancel(); ArgumentCaptor imageInsertAbortedEvent = forClass(ImageInsertAbortedEvent.class); verify(eventBus, times(2)).post(imageInsertAbortedEvent.capture()); + verify(bucket).free(); assertThat(imageInsertAbortedEvent.getValue().image(), is(image)); } @Test public void failureWithoutExceptionSendsFailedEvent() { - insertToken.onFailure(null, null, null); + insertToken.onFailure(null, null); ArgumentCaptor imageInsertFailedEvent = forClass(ImageInsertFailedEvent.class); verify(eventBus).post(imageInsertFailedEvent.capture()); + verify(bucket).free(); assertThat(imageInsertFailedEvent.getValue().image(), is(image)); assertThat(imageInsertFailedEvent.getValue().cause(), nullValue()); } @Test public void failureSendsFailedEventWithException() { - InsertException insertException = new InsertException(INTERNAL_ERROR, "Internal error", null); - insertToken.onFailure(insertException, null, null); + InsertException insertException = new InsertException(InsertExceptionMode.INTERNAL_ERROR, "Internal error", null); + insertToken.onFailure(insertException, null); ArgumentCaptor imageInsertFailedEvent = forClass(ImageInsertFailedEvent.class); verify(eventBus).post(imageInsertFailedEvent.capture()); + verify(bucket).free(); assertThat(imageInsertFailedEvent.getValue().image(), is(image)); assertThat(imageInsertFailedEvent.getValue().cause(), is((Throwable) insertException)); } @Test public void failureBecauseCancelledByUserSendsAbortedEvent() { - InsertException insertException = new InsertException(CANCELLED, null); - insertToken.onFailure(insertException, null, null); + InsertException insertException = new InsertException(InsertExceptionMode.CANCELLED, null); + insertToken.onFailure(insertException, null); ArgumentCaptor imageInsertAbortedEvent = forClass(ImageInsertAbortedEvent.class); verify(eventBus).post(imageInsertAbortedEvent.capture()); + verify(bucket).free(); assertThat(imageInsertAbortedEvent.getValue().image(), is(image)); } @Test - public void ignoredMethodsDoNotThrowExceptions() { - insertToken.onMajorProgress(null); - insertToken.onFetchable(null, null); - insertToken.onGeneratedMetadata(null, null, null); + public void ignoredMethodsDoNotThrowExceptions() throws ResumeFailedException { + insertToken.onResume(null); + insertToken.onFetchable(null); + insertToken.onGeneratedMetadata(null, null); } @Test public void generatedUriIsPostedOnSuccess() { FreenetURI generatedUri = mock(FreenetURI.class); - insertToken.onGeneratedURI(generatedUri, null, null); - insertToken.onSuccess(null, null); + insertToken.onGeneratedURI(generatedUri, null); + insertToken.onSuccess(null); ArgumentCaptor imageInsertFinishedEvent = forClass(ImageInsertFinishedEvent.class); verify(eventBus).post(imageInsertFinishedEvent.capture()); + verify(bucket).free(); assertThat(imageInsertFinishedEvent.getValue().image(), is(image)); assertThat(imageInsertFinishedEvent.getValue().resultingUri(), is(generatedUri)); } @Test public void insertTokenSupplierSuppliesInsertTokens() { - InsertTokenSupplier insertTokenSupplier = freenetInterface.new InsertTokenSupplier(); + InsertTokenSupplier insertTokenSupplier = new InsertTokenSupplier(freenetInterface); assertThat(insertTokenSupplier.apply(image), notNullValue()); } + @Test + public void backgroundFetchCanBeStarted() throws Exception { + freenetInterface.startFetch(uri, backgroundFetchCallback); + verify(highLevelSimpleClient).fetch(eq(uri), anyLong(), any(ClientGetCallback.class), any(FetchContext.class), anyShort()); + } + + @Test + public void backgroundFetchRegistersSnoopAndRestartsTheRequest() throws Exception { + freenetInterface.startFetch(uri, backgroundFetchCallback); + verify(clientGetter).setMetaSnoop(any(SnoopMetadata.class)); + verify(clientGetter).restart(eq(uri), anyBoolean(), any(ClientContext.class)); + } + + @Test + public void requestIsNotCancelledForImageMimeType() { + verifySnoopCancelsRequestForMimeType("image/png", false); + verify(backgroundFetchCallback, never()).failed(uri); + } + + @Test + public void requestIsCancelledForNullMimeType() { + verifySnoopCancelsRequestForMimeType(null, true); + verify(backgroundFetchCallback, never()).shouldCancel(eq(uri), ArgumentMatchers.any(), anyLong()); + verify(backgroundFetchCallback).failed(uri); + } + + @Test + public void requestIsCancelledForVideoMimeType() { + verifySnoopCancelsRequestForMimeType("video/mkv", true); + verify(backgroundFetchCallback).failed(uri); + } + + @Test + public void requestIsCancelledForAudioMimeType() { + verifySnoopCancelsRequestForMimeType("audio/mpeg", true); + verify(backgroundFetchCallback).failed(uri); + } + + @Test + public void requestIsCancelledForTextMimeType() { + verifySnoopCancelsRequestForMimeType("text/plain", true); + verify(backgroundFetchCallback).failed(uri); + } + + private void verifySnoopCancelsRequestForMimeType(String mimeType, boolean cancel) { + when(backgroundFetchCallback.shouldCancel(eq(uri), eq(mimeType), anyLong())).thenReturn(cancel); + freenetInterface.startFetch(uri, backgroundFetchCallback); + ArgumentCaptor snoopMetadata = forClass(SnoopMetadata.class); + verify(clientGetter).setMetaSnoop(snoopMetadata.capture()); + Metadata metadata = mock(Metadata.class); + when(metadata.getMIMEType()).thenReturn(mimeType); + assertThat(snoopMetadata.getValue().snoopMetadata(metadata, mock(ClientContext.class)), is(cancel)); + } + + @Test + public void callbackOfBackgroundFetchIsNotifiedOnSuccess() throws Exception { + freenetInterface.startFetch(uri, backgroundFetchCallback); + verify(highLevelSimpleClient).fetch(eq(uri), anyLong(), clientGetCallback.capture(), any(FetchContext.class), anyShort()); + when(fetchResult.getMimeType()).thenReturn("image/png"); + when(fetchResult.asByteArray()).thenReturn(new byte[] { 1, 2, 3, 4, 5 }); + clientGetCallback.getValue().onSuccess(fetchResult, mock(ClientGetter.class)); + verify(backgroundFetchCallback).loaded(uri, "image/png", new byte[] { 1, 2, 3, 4, 5 }); + verifyNoMoreInteractions(backgroundFetchCallback); + } + + @Test + public void callbackOfBackgroundFetchIsNotifiedOnFailure() throws Exception { + freenetInterface.startFetch(uri, backgroundFetchCallback); + verify(highLevelSimpleClient).fetch(eq(uri), anyLong(), clientGetCallback.capture(), any(FetchContext.class), anyShort()); + when(fetchResult.getMimeType()).thenReturn("image/png"); + when(fetchResult.asByteArray()).thenReturn(new byte[] { 1, 2, 3, 4, 5 }); + clientGetCallback.getValue().onFailure(new FetchException(ALL_DATA_NOT_FOUND), mock(ClientGetter.class)); + verify(backgroundFetchCallback).failed(uri); + verifyNoMoreInteractions(backgroundFetchCallback); + } + + @Test + public void callbackOfBackgroundFetchIsNotifiedAsFailureIfBucketCanNotBeLoaded() throws Exception { + freenetInterface.startFetch(uri, backgroundFetchCallback); + verify(highLevelSimpleClient).fetch(eq(uri), anyLong(), clientGetCallback.capture(), any(FetchContext.class), anyShort()); + when(fetchResult.getMimeType()).thenReturn("image/png"); + when(fetchResult.asByteArray()).thenThrow(IOException.class); + clientGetCallback.getValue().onSuccess(fetchResult, mock(ClientGetter.class)); + verify(backgroundFetchCallback).failed(uri); + verifyNoMoreInteractions(backgroundFetchCallback); + } + }