X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Ftext%2FSoneMentionDetectorTest.kt;h=552b7eef541b057f4f3a1cfe439ea894f735ce70;hp=2003988d756addea14ff7fb52cfaa109b094aa91;hb=438378deab1514f0f608d975ef65f5b7aea44ccb;hpb=acdc9746bb0c853bfd36f1c982c95017158166c2

diff --git a/src/test/kotlin/net/pterodactylus/sone/text/SoneMentionDetectorTest.kt b/src/test/kotlin/net/pterodactylus/sone/text/SoneMentionDetectorTest.kt
index 2003988..552b7ee 100644
--- a/src/test/kotlin/net/pterodactylus/sone/text/SoneMentionDetectorTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/text/SoneMentionDetectorTest.kt
@@ -1,5 +1,5 @@
 /**
- * Sone - SoneMentionDetectorTest.kt - Copyright © 2019 David ‘Bombe’ Roden
+ * Sone - SoneMentionDetectorTest.kt - Copyright © 2019–2020 David ‘Bombe’ Roden
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,8 +17,6 @@
 
 package net.pterodactylus.sone.text
 
-import com.google.common.base.*
-import com.google.common.base.Optional.*
 import com.google.common.eventbus.*
 import net.pterodactylus.sone.core.event.*
 import net.pterodactylus.sone.data.*
@@ -31,20 +29,29 @@ import kotlin.test.*
 /**
  * Unit test for [SoneMentionDetector].
  */
+@Suppress("UnstableApiUsage")
 class SoneMentionDetectorTest {
 
-	private val eventBus = EventBus()
+	private val caughtExceptions = mutableListOf<Throwable>()
+	private val eventBus = EventBus { exception, _ -> caughtExceptions += exception }
 	private val soneProvider = TestSoneProvider()
 	private val postProvider = TestPostProvider()
 	private val soneTextParser = SoneTextParser(soneProvider, postProvider)
-	private val capturedEvents = mutableListOf<LocalSoneMentionedInPostEvent>()
+	private val capturedFoundEvents = mutableListOf<MentionOfLocalSoneFoundEvent>()
+	private val capturedRemovedEvents = mutableListOf<MentionOfLocalSoneRemovedEvent>()
+	private val postReplyProvider = TestPostReplyProvider()
 
 	init {
-		eventBus.register(SoneMentionDetector(eventBus, soneTextParser))
+		eventBus.register(SoneMentionDetector(eventBus, soneTextParser, postReplyProvider))
 		eventBus.register(object : Any() {
 			@Subscribe
-			fun captureEvent(localSoneMentionedInPostEvent: LocalSoneMentionedInPostEvent) {
-				capturedEvents += localSoneMentionedInPostEvent
+			fun captureFoundEvent(mentionOfLocalSoneFoundEvent: MentionOfLocalSoneFoundEvent) {
+				capturedFoundEvents += mentionOfLocalSoneFoundEvent
+			}
+
+			@Subscribe
+			fun captureRemovedEvent(event: MentionOfLocalSoneRemovedEvent) {
+				capturedRemovedEvents += event
 			}
 		})
 	}
@@ -53,56 +60,56 @@ class SoneMentionDetectorTest {
 	fun `detector does not emit event on post that does not contain any sones`() {
 		val post = createPost()
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
 	@Test
 	fun `detector does not emit event on post that does contain two remote sones`() {
 		val post = createPost("text mentions sone://${remoteSone1.id} and sone://${remoteSone2.id}.")
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
 	@Test
 	fun `detector emits event on post that contains links to a remote and a local sone`() {
 		val post = createPost("text mentions sone://${localSone1.id} and sone://${remoteSone2.id}.")
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
 	fun `detector emits one event on post that contains two links to the same local sone`() {
 		val post = createPost("text mentions sone://${localSone1.id} and sone://${localSone1.id}.")
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
 	fun `detector emits one event on post that contains links to two local sones`() {
 		val post = createPost("text mentions sone://${localSone1.id} and sone://${localSone2.id}.")
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
 	fun `detector does not emit event for post by local sone`() {
 		val post = createPost("text mentions sone://${localSone1.id} and sone://${localSone2.id}.", localSone1)
 		eventBus.post(NewPostFoundEvent(post))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
 	@Test
 	fun `detector does not emit event for reply that contains no sones`() {
 		val reply = emptyPostReply()
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
 	@Test
 	fun `detector does not emit event for reply that contains two links to remote sones`() {
 		val reply = emptyPostReply("text mentions sone://${remoteSone1.id} and sone://${remoteSone2.id}.")
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
 	@Test
@@ -110,7 +117,7 @@ class SoneMentionDetectorTest {
 		val post = createPost()
 		val reply = emptyPostReply("text mentions sone://${remoteSone1.id} and sone://${localSone1.id}.", post)
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
@@ -118,7 +125,7 @@ class SoneMentionDetectorTest {
 		val post = createPost()
 		val reply = emptyPostReply("text mentions sone://${localSone1.id} and sone://${localSone1.id}.", post)
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
@@ -126,29 +133,104 @@ class SoneMentionDetectorTest {
 		val post = createPost()
 		val reply = emptyPostReply("text mentions sone://${localSone1.id} and sone://${localSone2.id}.", post)
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, contains(LocalSoneMentionedInPostEvent(post)))
+		assertThat(capturedFoundEvents, contains(MentionOfLocalSoneFoundEvent(post)))
 	}
 
 	@Test
 	fun `detector does not emit event for reply by local sone`() {
 		val reply = emptyPostReply("text mentions sone://${localSone1.id} and sone://${localSone2.id}.", sone = localSone1)
 		eventBus.post(NewPostReplyFoundEvent(reply))
-		assertThat(capturedEvents, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
 	}
 
-}
+	@Test
+	fun `detector does not emit event for reply without post`() {
+		val reply = emptyPostReply("text mentions sone://${localSone1.id} and sone://${localSone2.id}.", post = null)
+		eventBus.post(NewPostReplyFoundEvent(reply))
+		assertThat(caughtExceptions, emptyIterable())
+		assertThat(capturedFoundEvents, emptyIterable())
+	}
+
+	@Test
+	fun `detector does not emit removed event when a post without mention is removed`() {
+		val post = createPost()
+		eventBus.post(PostRemovedEvent(post))
+		assertThat(capturedRemovedEvents, emptyIterable())
+	}
+
+	@Test
+	fun `detector does emit removed event when post with mention is removed`() {
+		val post = createPost("sone://${localSone1.id}")
+		eventBus.post(NewPostFoundEvent(post))
+		eventBus.post(PostRemovedEvent(post))
+		assertThat(capturedRemovedEvents, contains(MentionOfLocalSoneRemovedEvent(post)))
+	}
+
+	@Test
+	fun `detector does not emit removed event when a post without mention is marked as known`() {
+		val post = createPost()
+		eventBus.post(MarkPostKnownEvent(post))
+		assertThat(capturedRemovedEvents, emptyIterable())
+	}
+
+	@Test
+	fun `detector does emit removed event when post with mention is marked as known`() {
+		val post = createPost("sone://${localSone1.id}")
+		eventBus.post(NewPostFoundEvent(post))
+		eventBus.post(MarkPostKnownEvent(post))
+		assertThat(capturedRemovedEvents, contains(MentionOfLocalSoneRemovedEvent(post)))
+	}
+
+	@Test
+	fun `detector does emit removed event when reply with mention is removed and no more mentions in that post exist`() {
+		val post = createPost()
+		val reply = emptyPostReply("sone://${localSone1.id}", post)
+		postReplyProvider.postReplies[post.id] = listOf(reply)
+		eventBus.post(NewPostReplyFoundEvent(reply))
+		eventBus.post(PostReplyRemovedEvent(reply))
+		assertThat(capturedRemovedEvents, contains(MentionOfLocalSoneRemovedEvent(post)))
+	}
 
-private val remoteSone1 = createRemoteSone()
-private val remoteSone2 = createRemoteSone()
+	@Test
+	fun `detector does not emit removed event when reply with mention is removed and post mentions local sone`() {
+		val post = createPost("sone://${localSone1.id}")
+		val reply = emptyPostReply("sone://${localSone1.id}", post)
+		eventBus.post(NewPostReplyFoundEvent(reply))
+		eventBus.post(PostReplyRemovedEvent(reply))
+		assertThat(capturedRemovedEvents, emptyIterable())
+	}
+
+	@Test
+	fun `detector does emit removed event when reply with mention is removed and post mentions local sone but is known`() {
+		val post = createPost("sone://${localSone1.id}", known = true)
+		val reply = emptyPostReply("sone://${localSone1.id}", post)
+		eventBus.post(NewPostReplyFoundEvent(reply))
+		eventBus.post(PostReplyRemovedEvent(reply))
+		assertThat(capturedRemovedEvents, contains(MentionOfLocalSoneRemovedEvent(post)))
+	}
 
-private val localSone1 = createLocalSone()
-private val localSone2 = createLocalSone()
+	@Test
+	fun `detector does not emit removed event when reply with mention is removed and post has other replies with mentions`() {
+		val post = createPost()
+		val reply1 = emptyPostReply("sone://${localSone1.id}", post)
+		val reply2 = emptyPostReply("sone://${localSone1.id}", post)
+		postReplyProvider.postReplies[post.id] = listOf(reply1, reply2)
+		eventBus.post(NewPostReplyFoundEvent(reply1))
+		eventBus.post(PostReplyRemovedEvent(reply1))
+		assertThat(capturedRemovedEvents, emptyIterable())
+	}
 
-private fun createPost(text: String = "", sone: Sone = remoteSone1): Post.EmptyPost {
-	return object : Post.EmptyPost("post-id") {
-		override fun getSone() = sone
-		override fun getText() = text
+	@Test
+	fun `detector does emit removed event when reply with mention is removed and post has other replies with mentions which are known`() {
+		val post = createPost()
+		val reply1 = emptyPostReply("sone://${localSone1.id}", post)
+		val reply2 = emptyPostReply("sone://${localSone1.id}", post, known = true)
+		postReplyProvider.postReplies[post.id] = listOf(reply1, reply2)
+		eventBus.post(NewPostReplyFoundEvent(reply1))
+		eventBus.post(PostReplyRemovedEvent(reply1))
+		assertThat(capturedRemovedEvents, contains(MentionOfLocalSoneRemovedEvent(post)))
 	}
+
 }
 
 private class TestSoneProvider : SoneProvider {
@@ -170,13 +252,12 @@ private class TestPostProvider : PostProvider {
 
 }
 
-private fun emptyPostReply(text: String = "", post: Post = createPost(), sone: Sone = remoteSone1) = object : PostReply {
-	override val id = "reply-id"
-	override fun getSone() = sone
-	override fun getPostId() = post.id
-	override fun getPost(): Optional<Post> = of(post)
-	override fun getTime() = 1L
-	override fun getText() = text
-	override fun isKnown() = false
-	override fun setKnown(known: Boolean): PostReply = this
+private class TestPostReplyProvider : PostReplyProvider {
+
+	val replies = mutableMapOf<String, PostReply>()
+	val postReplies = mutableMapOf<String, List<PostReply>>()
+
+	override fun getPostReply(id: String) = replies[id]
+	override fun getReplies(postId: String) = postReplies[postId] ?: emptyList()
+
 }