X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fajax%2FCreatePostAjaxPageTest.kt;h=b79e6df2f08c3e9edcfa44829e7bb3df7d1db123;hp=0588b6a5436370d8896190ca378e7123087388c2;hb=04709e23f38e9d447337682ba27201da5dc19bd9;hpb=858eb848396910330160dcce9817c0d3e6d37cce

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/ajax/CreatePostAjaxPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/ajax/CreatePostAjaxPageTest.kt
index 0588b6a..b79e6df 100644
--- a/src/test/kotlin/net/pterodactylus/sone/web/ajax/CreatePostAjaxPageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/ajax/CreatePostAjaxPageTest.kt
@@ -3,69 +3,47 @@ package net.pterodactylus.sone.web.ajax
 import com.google.common.base.Optional
 import net.pterodactylus.sone.data.Post
 import net.pterodactylus.sone.data.Sone
+import net.pterodactylus.sone.test.getInstance
 import net.pterodactylus.sone.test.mock
 import net.pterodactylus.sone.test.whenever
 import net.pterodactylus.sone.utils.asOptional
+import net.pterodactylus.sone.web.baseInjector
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.equalTo
+import org.hamcrest.Matchers.notNullValue
 import org.hamcrest.Matchers.nullValue
 import org.junit.Test
 
 /**
  * Unit test for [CreatePostAjaxPage].
  */
-class CreatePostAjaxPageTest : JsonPageTest(::CreatePostAjaxPage) {
-
-	@Test
-	fun `page returns correct path`() {
-		assertThat(page.path, equalTo("createPost.ajax"))
-	}
-
-	@Test
-	fun `page needs form password`() {
-		assertThat(page.needsFormPassword(), equalTo(true))
-	}
-
-	@Test
-	fun `page requires login`() {
-		assertThat(page.requiresLogin(), equalTo(true))
-	}
-
-	@Test
-	fun `page requires a current sone`() {
-		unsetCurrentSone()
-		assertThat(json.isSuccess, equalTo(false))
-		assertThat(json.error, equalTo("auth-required"))
-	}
+class CreatePostAjaxPageTest : JsonPageTest("createPost.ajax", pageSupplier = ::CreatePostAjaxPage) {
 
 	@Test
 	fun `missing text parameter returns error`() {
-		assertThat(json.isSuccess, equalTo(false))
-		assertThat(json.error, equalTo("text-required"))
+		assertThatJsonFailed("text-required")
 	}
 
 	@Test
 	fun `empty text returns error`() {
 		addRequestParameter("text", "")
-		assertThat(json.isSuccess, equalTo(false))
-		assertThat(json.error, equalTo("text-required"))
+		assertThatJsonFailed("text-required")
 	}
 
 	@Test
 	fun `whitespace-only text returns error`() {
 		addRequestParameter("text", "  ")
-		assertThat(json.isSuccess, equalTo(false))
-		assertThat(json.error, equalTo("text-required"))
+		assertThatJsonFailed("text-required")
 	}
 
 	@Test
 	fun `request with valid data creates post`() {
 		addRequestParameter("text", "test")
 		val post = createPost()
-		whenever(core.createPost(currentSone, Optional.absent(), "test")).thenReturn(post)
-		assertThat(json.isSuccess, equalTo(true))
-		assertThat(json["postId"].asText(), equalTo("id"))
-		assertThat(json["sone"].asText(), equalTo(currentSone.id))
+		whenever(core.createPost(currentSone, null, "test")).thenReturn(post)
+		assertThatJsonIsSuccessful()
+		assertThat(json["postId"]?.asText(), equalTo("id"))
+		assertThat(json["sone"]?.asText(), equalTo(currentSone.id))
 		assertThat(json["recipient"], nullValue())
 	}
 
@@ -74,10 +52,10 @@ class CreatePostAjaxPageTest : JsonPageTest(::CreatePostAjaxPage) {
 		addRequestParameter("text", "test")
 		addRequestParameter("recipient", "invalid")
 		val post = createPost()
-		whenever(core.createPost(currentSone, Optional.absent(), "test")).thenReturn(post)
-		assertThat(json.isSuccess, equalTo(true))
-		assertThat(json["postId"].asText(), equalTo("id"))
-		assertThat(json["sone"].asText(), equalTo(currentSone.id))
+		whenever(core.createPost(currentSone, null, "test")).thenReturn(post)
+		assertThatJsonIsSuccessful()
+		assertThat(json["postId"]?.asText(), equalTo("id"))
+		assertThat(json["sone"]?.asText(), equalTo(currentSone.id))
 		assertThat(json["recipient"], nullValue())
 	}
 
@@ -88,11 +66,11 @@ class CreatePostAjaxPageTest : JsonPageTest(::CreatePostAjaxPage) {
 		val recipient = mock<Sone>().apply { whenever(id).thenReturn("valid") }
 		addSone(recipient)
 		val post = createPost("valid")
-		whenever(core.createPost(currentSone, Optional.of(recipient), "test")).thenReturn(post)
-		assertThat(json.isSuccess, equalTo(true))
-		assertThat(json["postId"].asText(), equalTo("id"))
-		assertThat(json["sone"].asText(), equalTo(currentSone.id))
-		assertThat(json["recipient"].asText(), equalTo("valid"))
+		whenever(core.createPost(currentSone, recipient, "test")).thenReturn(post)
+		assertThatJsonIsSuccessful()
+		assertThat(json["postId"]?.asText(), equalTo("id"))
+		assertThat(json["sone"]?.asText(), equalTo(currentSone.id))
+		assertThat(json["recipient"]?.asText(), equalTo("valid"))
 	}
 
 	@Test
@@ -100,10 +78,10 @@ class CreatePostAjaxPageTest : JsonPageTest(::CreatePostAjaxPage) {
 		addRequestParameter("text", "Link http://freenet.test:8888/KSK@foo is filtered")
 		addRequestHeader("Host", "freenet.test:8888")
 		val post = createPost()
-		whenever(core.createPost(currentSone, Optional.absent(), "Link KSK@foo is filtered")).thenReturn(post)
-		assertThat(json.isSuccess, equalTo(true))
-		assertThat(json["postId"].asText(), equalTo("id"))
-		assertThat(json["sone"].asText(), equalTo(currentSone.id))
+		whenever(core.createPost(currentSone, null, "Link KSK@foo is filtered")).thenReturn(post)
+		assertThatJsonIsSuccessful()
+		assertThat(json["postId"]?.asText(), equalTo("id"))
+		assertThat(json["sone"]?.asText(), equalTo(currentSone.id))
 		assertThat(json["recipient"], nullValue())
 	}
 
@@ -114,4 +92,9 @@ class CreatePostAjaxPageTest : JsonPageTest(::CreatePostAjaxPage) {
 				whenever(this.recipientId).thenReturn(recipientId.asOptional())
 			}
 
+	@Test
+	fun `page can be created by dependency injection`() {
+	    assertThat(baseInjector.getInstance<CreatePostAjaxPage>(), notNullValue())
+	}
+
 }