X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FEditImagePageTest.kt;h=57d1453f096ce5dd43302b348642dec2f9027283;hp=d36dec571d3c7cafdf32733d40c24f574c03f108;hb=cd72add62ab407336b471d4b7cda8e33dd2df5c6;hpb=de7568a82eb4150bf6d2b0553841b7b69f84c968 diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt index d36dec5..57d1453 100644 --- a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditImagePageTest.kt @@ -3,14 +3,18 @@ package net.pterodactylus.sone.web.pages import net.pterodactylus.sone.data.Album import net.pterodactylus.sone.data.Image import net.pterodactylus.sone.data.Image.Modifier +import net.pterodactylus.sone.data.Image.Modifier.ImageTitleMustNotBeEmpty import net.pterodactylus.sone.data.Sone +import net.pterodactylus.sone.test.doThrow +import net.pterodactylus.sone.test.getInstance import net.pterodactylus.sone.test.mock import net.pterodactylus.sone.test.mockBuilder import net.pterodactylus.sone.test.whenever -import net.pterodactylus.sone.web.pages.EditImagePage -import net.pterodactylus.sone.web.pages.WebPageTest -import net.pterodactylus.util.web.Method.GET +import net.pterodactylus.sone.web.baseInjector import net.pterodactylus.util.web.Method.POST +import org.hamcrest.MatcherAssert.assertThat +import org.hamcrest.Matchers.equalTo +import org.hamcrest.Matchers.notNullValue import org.junit.Before import org.junit.Test import org.mockito.Mockito.never @@ -19,17 +23,13 @@ import org.mockito.Mockito.verify /** * Unit test for [EditImagePage]. */ -class EditImagePageTest : WebPageTest() { - - private val page = EditImagePage(template, webInterface) +class EditImagePageTest: WebPageTest(::EditImagePage) { private val image = mock() private val modifier = mockBuilder() private val sone = mock() private val album = mock() - override fun getPage() = page - @Before fun setupImage() { whenever(sone.isLocal).thenReturn(true) @@ -41,33 +41,48 @@ class EditImagePageTest : WebPageTest() { } @Test + fun `page returns correct path`() { + assertThat(page.path, equalTo("editImage.html")) + } + + @Test + fun `page requires login`() { + assertThat(page.requiresLogin(), equalTo(true)) + } + + @Test + fun `page returns correct title`() { + whenever(l10n.getString("Page.EditImage.Title")).thenReturn("edit image page title") + assertThat(page.getPageTitle(soneRequest), equalTo("edit image page title")) + } + + @Test fun `get request does not redirect`() { - request("", GET) - page.handleRequest(freenetRequest, templateContext) + page.processTemplate(freenetRequest, templateContext) } @Test fun `post request with invalid image redirects to invalid page`() { - request("", POST) + setMethod(POST) verifyRedirect("invalid.html") } @Test fun `post request with valid image from non-local sone redirects to no permission page`() { - request("", POST) + setMethod(POST) whenever(sone.isLocal).thenReturn(false) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") + addHttpRequestPart("image", "image-id") verifyRedirect("noPermission.html") } @Test fun `post request with valid image and move left requested moves image left and redirects to return page`() { - request("", POST) + setMethod(POST) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") - addHttpRequestParameter("returnPage", "return.html") - addHttpRequestParameter("moveLeft", "true") + addHttpRequestPart("image", "image-id") + addHttpRequestPart("returnPage", "return.html") + addHttpRequestPart("moveLeft", "true") verifyRedirect("return.html") { verify(album).moveImageUp(image) verify(core).touchConfiguration() @@ -76,11 +91,11 @@ class EditImagePageTest : WebPageTest() { @Test fun `post request with valid image and move right requested moves image right and redirects to return page`() { - request("", POST) + setMethod(POST) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") - addHttpRequestParameter("returnPage", "return.html") - addHttpRequestParameter("moveRight", "true") + addHttpRequestPart("image", "image-id") + addHttpRequestPart("returnPage", "return.html") + addHttpRequestPart("moveRight", "true") verifyRedirect("return.html") { verify(album).moveImageDown(image) verify(core).touchConfiguration() @@ -89,11 +104,12 @@ class EditImagePageTest : WebPageTest() { @Test fun `post request with valid image but only whitespace in the title redirects to empty image title page`() { - request("", POST) + setMethod(POST) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") - addHttpRequestParameter("returnPage", "return.html") - addHttpRequestParameter("title", " ") + addHttpRequestPart("image", "image-id") + addHttpRequestPart("returnPage", "return.html") + addHttpRequestPart("title", " ") + whenever(modifier.update()).doThrow() verifyRedirect("emptyImageTitle.html") { verify(core, never()).touchConfiguration() } @@ -101,12 +117,12 @@ class EditImagePageTest : WebPageTest() { @Test fun `post request with valid image title and description modifies image and redirects to reutrn page`() { - request("", POST) + setMethod(POST) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") - addHttpRequestParameter("returnPage", "return.html") - addHttpRequestParameter("title", "Title") - addHttpRequestParameter("description", "Description") + addHttpRequestPart("image", "image-id") + addHttpRequestPart("returnPage", "return.html") + addHttpRequestPart("title", "Title") + addHttpRequestPart("description", "Description") verifyRedirect("return.html") { verify(modifier).setTitle("Title") verify(modifier).setDescription("Description") @@ -116,14 +132,14 @@ class EditImagePageTest : WebPageTest() { } @Test - fun `post request with image title and description modifies image with filtered description and redirects to reutrn page`() { - request("", POST) + fun `post request with image title and description modifies image with filtered description and redirects to return page`() { + setMethod(POST) addImage("image-id", image) - addHttpRequestParameter("image", "image-id") - addHttpRequestParameter("returnPage", "return.html") - addHttpRequestParameter("title", "Title") + addHttpRequestPart("image", "image-id") + addHttpRequestPart("returnPage", "return.html") + addHttpRequestPart("title", "Title") addHttpRequestHeader("Host", "www.te.st") - addHttpRequestParameter("description", "Get http://www.te.st/KSK@GPL.txt") + addHttpRequestPart("description", "Get http://www.te.st/KSK@GPL.txt") verifyRedirect("return.html") { verify(modifier).setTitle("Title") verify(modifier).setDescription("Get KSK@GPL.txt") @@ -132,4 +148,9 @@ class EditImagePageTest : WebPageTest() { } } + @Test + fun `page can be created by dependency injection`() { + assertThat(baseInjector.getInstance(), notNullValue()) + } + }