X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FEditProfilePageTest.kt;h=74c3851321ce2f39fef3bcbca7b0849cf96d1ac7;hp=c79bbcfb995404a50670b9d557ef1c26250e673f;hb=d5cd41949b7e62fdc40ef7390661dcda8c18a139;hpb=de7568a82eb4150bf6d2b0553841b7b69f84c968 diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt index c79bbcf..74c3851 100644 --- a/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/EditProfilePageTest.kt @@ -1,35 +1,24 @@ package net.pterodactylus.sone.web.pages -import net.pterodactylus.sone.data.Image -import net.pterodactylus.sone.data.Profile -import net.pterodactylus.sone.test.mock -import net.pterodactylus.sone.test.whenever -import net.pterodactylus.sone.web.pages.EditProfilePage -import net.pterodactylus.sone.web.pages.WebPageTest -import net.pterodactylus.util.web.Method.GET -import net.pterodactylus.util.web.Method.POST -import org.hamcrest.MatcherAssert.assertThat -import org.hamcrest.Matchers.contains -import org.hamcrest.Matchers.equalTo -import org.hamcrest.Matchers.notNullValue -import org.junit.Before -import org.junit.Test -import org.mockito.Mockito.never -import org.mockito.Mockito.verify +import net.pterodactylus.sone.data.* +import net.pterodactylus.sone.test.* +import net.pterodactylus.sone.web.* +import net.pterodactylus.sone.web.page.* +import net.pterodactylus.util.web.Method.* +import org.hamcrest.MatcherAssert.* +import org.hamcrest.Matchers.* +import org.junit.* +import org.mockito.Mockito.* /** * Unit test for [EditProfilePage]. */ -class EditProfilePageTest : WebPageTest() { - - private val page = EditProfilePage(template, webInterface) +class EditProfilePageTest : WebPageTest(::EditProfilePage) { private val profile = Profile(currentSone) private val firstField = profile.addField("First Field") private val secondField = profile.addField("Second Field") - override fun getPage() = page - @Before fun setupProfile() { val avatar = mock() @@ -46,9 +35,24 @@ class EditProfilePageTest : WebPageTest() { } @Test + fun `page returns correct path`() { + assertThat(page.path, equalTo("editProfile.html")) + } + + @Test + fun `page requires login`() { + assertThat(page.requiresLogin(), equalTo(true)) + } + + @Test + fun `page returns correct title`() { + addTranslation("Page.EditProfile.Title", "edit profile page title") + assertThat(page.getPageTitle(soneRequest), equalTo("edit profile page title")) + } + + @Test fun `get request stores fields of current sone’s profile in template context`() { - request("", GET) - page.handleRequest(freenetRequest, templateContext) + page.processTemplate(freenetRequest, templateContext) assertThat(templateContext["firstName"], equalTo("First")) assertThat(templateContext["middleName"], equalTo("Middle")) assertThat(templateContext["lastName"], equalTo("Last")) @@ -61,8 +65,8 @@ class EditProfilePageTest : WebPageTest() { @Test fun `post request without any command stores fields of current sone’s profile in template context`() { - request("", POST) - page.handleRequest(freenetRequest, templateContext) + setMethod(POST) + page.processTemplate(freenetRequest, templateContext) assertThat(templateContext["firstName"], equalTo("First")) assertThat(templateContext["middleName"], equalTo("Middle")) assertThat(templateContext["lastName"], equalTo("Last")) @@ -74,10 +78,11 @@ class EditProfilePageTest : WebPageTest() { } private fun verifySingleFieldCanBeChanged(fieldName: String, newValue: T, expectedValue: T = newValue, fieldAccessor: () -> T) { - request("", POST) - addHttpRequestParameter("save-profile", "true") - addHttpRequestParameter(fieldName, newValue.toString()) + setMethod(POST) + addHttpRequestPart("save-profile", "true") + addHttpRequestPart(fieldName, newValue.toString()) verifyRedirect("editProfile.html") { + verify(currentSone).profile = profile verify(core).touchConfiguration() assertThat(fieldAccessor(), equalTo(expectedValue)) } @@ -139,11 +144,11 @@ class EditProfilePageTest : WebPageTest() { @Test fun `adding a field with a duplicate name sets error in template context`() { - request("", POST) + setMethod(POST) profile.addField("new-field") - addHttpRequestParameter("add-field", "true") - addHttpRequestParameter("field-name", "new-field") - page.handleRequest(freenetRequest, templateContext) + addHttpRequestPart("add-field", "true") + addHttpRequestPart("field-name", "new-field") + page.processTemplate(freenetRequest, templateContext) assertThat(templateContext["fieldName"], equalTo("new-field")) assertThat(templateContext["duplicateFieldName"], equalTo(true)) verify(core, never()).touchConfiguration() @@ -151,9 +156,9 @@ class EditProfilePageTest : WebPageTest() { @Test fun `adding a field with a new name sets adds field to profile and redirects to profile edit page`() { - request("", POST) - addHttpRequestParameter("add-field", "true") - addHttpRequestParameter("field-name", "new-field") + setMethod(POST) + addHttpRequestPart("add-field", "true") + addHttpRequestPart("field-name", "new-field") verifyRedirect("editProfile.html#profile-fields") { assertThat(profile.getFieldByName("new-field"), notNullValue()) verify(currentSone).profile = profile @@ -163,15 +168,15 @@ class EditProfilePageTest : WebPageTest() { @Test fun `deleting a field redirects to delete field page`() { - request("", POST) - addHttpRequestParameter("delete-field-${firstField.id}", "true") + setMethod(POST) + addHttpRequestPart("delete-field-${firstField.id}", "true") verifyRedirect("deleteProfileField.html?field=${firstField.id}") } @Test fun `moving a field up moves the field up and redirects to the edit profile page`() { - request("", POST) - addHttpRequestParameter("move-up-field-${secondField.id}", "true") + setMethod(POST) + addHttpRequestPart("move-up-field-${secondField.id}", "true") verifyRedirect("editProfile.html#profile-fields") { assertThat(profile.fields, contains(secondField, firstField)) verify(currentSone).profile = profile @@ -179,16 +184,16 @@ class EditProfilePageTest : WebPageTest() { } @Test - fun `moving an invalid field up redirects to the invalid page`() { - request("", POST) - addHttpRequestParameter("move-up-field-foo", "true") - verifyRedirect("invalid.html") + fun `moving an invalid field up does not redirect`() { + setMethod(POST) + addHttpRequestPart("move-up-field-foo", "true") + page.processTemplate(freenetRequest, templateContext) } @Test fun `moving a field down moves the field down and redirects to the edit profile page`() { - request("", POST) - addHttpRequestParameter("move-down-field-${firstField.id}", "true") + setMethod(POST) + addHttpRequestPart("move-down-field-${firstField.id}", "true") verifyRedirect("editProfile.html#profile-fields") { assertThat(profile.fields, contains(secondField, firstField)) verify(currentSone).profile = profile @@ -196,17 +201,32 @@ class EditProfilePageTest : WebPageTest() { } @Test - fun `moving an invalid field down redirects to the invalid page`() { - request("", POST) - addHttpRequestParameter("move-down-field-foo", "true") - verifyRedirect("invalid.html") + fun `moving an invalid field down does not redirect`() { + setMethod(POST) + addHttpRequestPart("move-down-field-foo", "true") + page.processTemplate(freenetRequest, templateContext) } @Test fun `editing a field redirects to the edit profile page`() { - request("", POST) - addHttpRequestParameter("edit-field-${firstField.id}", "true") + setMethod(POST) + addHttpRequestPart("edit-field-${firstField.id}", "true") verifyRedirect("editProfileField.html?field=${firstField.id}") } + @Test + fun `page can be created by dependency injection`() { + assertThat(baseInjector.getInstance(), notNullValue()) + } + + @Test + fun `page is annotated with correct menuname`() { + assertThat(page.menuName, equalTo("EditProfile")) + } + + @Test + fun `page is annotated with correct template path`() { + assertThat(page.templatePath, equalTo("/templates/editProfile.html")) + } + }