X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FMetricsPageTest.kt;fp=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FMetricsPageTest.kt;h=9e2c4920ee2b7b7f87062d5fe672d5573fa5d397;hp=5a5d5887076f4623c86ee3485ed444b0120b45b6;hb=ab598a7019581eca9981cf1101b315e13a3bcbaa;hpb=d5cd41949b7e62fdc40ef7390661dcda8c18a139 diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt index 5a5d588..9e2c492 100644 --- a/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt @@ -62,46 +62,16 @@ class MetricsPageTest : WebPageTest() { } @Test - fun `metrics page auto-converts histogram name`() { - createHistogram("sone.random.duration") - page.handleRequest(soneRequest, templateContext) - verifyHistogram("soneRandomDuration") - } - - @Test @Suppress("UNCHECKED_CAST") - fun `metrics page stores histogram keys in template`() { + fun `metrics page stores histograms in template context`() { createHistogram("sone.random.duration2") createHistogram("sone.random.duration1") page.handleRequest(soneRequest, templateContext) - assertThat(templateContext["histogramKeys"] as Iterable, contains("soneRandomDuration1", "soneRandomDuration2")) - } - - @Test - fun `metrics page stores i18n names for histogram keys`() { - createHistogram("sone.random.duration1") - page.handleRequest(soneRequest, templateContext) - assertThat(templateContext["soneRandomDuration1I18n"] as String, equalTo("SoneRandomDuration1")) - } - - @Test - fun `metrics page delivers correct histogram size`() { - val histogram = metricRegistry.histogram("sone.parsing.duration") - (0..4000).forEach(histogram::update) - page.handleRequest(soneRequest, templateContext) - assertThat(templateContext["soneParsingDurationCount"] as Long, equalTo(4001L)) - } - - private fun verifyHistogram(name: String) { - assertThat(templateContext["${name}Count"] as Long, equalTo(5L)) - assertThat(templateContext["${name}Min"] as Long, equalTo(1L)) - assertThat(templateContext["${name}Max"] as Long, equalTo(10L)) - assertThat(templateContext["${name}Median"] as Double, equalTo(8.0)) - assertThat(templateContext["${name}Percentile75"] as Double, equalTo(9.0)) - assertThat(templateContext["${name}Percentile95"] as Double, equalTo(10.0)) - assertThat(templateContext["${name}Percentile98"] as Double, equalTo(10.0)) - assertThat(templateContext["${name}Percentile99"] as Double, equalTo(10.0)) - assertThat(templateContext["${name}Percentile999"] as Double, equalTo(10.0)) + val histograms = templateContext["histograms"] as Map + assertThat(histograms.entries.map { it.key to it.value }, containsInAnyOrder( + "sone.random.duration1" to metricRegistry.histogram("sone.random.duration1"), + "sone.random.duration2" to metricRegistry.histogram("sone.random.duration2") + )) } private fun createHistogram(name: String) = metricRegistry.histogram(name).run {