X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=blobdiff_plain;f=src%2Ftest%2Fkotlin%2Fnet%2Fpterodactylus%2Fsone%2Fweb%2Fpages%2FUploadImagePageTest.kt;h=4c99759e5cb80b8d7fec12497a8520f913f8b5fc;hp=dfb9aca3c0207516ddda5421d206c209d5dd8bfe;hb=HEAD;hpb=4f2dd6da42af253e7545d7cba5d9e5cb2895eb34

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
index dfb9aca..4c99759 100644
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/UploadImagePageTest.kt
@@ -1,33 +1,41 @@
 package net.pterodactylus.sone.web.pages
 
-import net.pterodactylus.sone.data.Album
-import net.pterodactylus.sone.data.Image
-import net.pterodactylus.sone.data.Image.Modifier
-import net.pterodactylus.sone.data.Sone
-import net.pterodactylus.sone.data.TemporaryImage
+import net.pterodactylus.sone.data.*
+import net.pterodactylus.sone.data.impl.*
+import net.pterodactylus.sone.test.getInstance
 import net.pterodactylus.sone.test.mock
-import net.pterodactylus.sone.test.mockBuilder
 import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.util.web.Method.POST
-import org.hamcrest.MatcherAssert.assertThat
-import org.hamcrest.Matchers.equalTo
-import org.junit.Test
-import org.mockito.Mockito.any
+import net.pterodactylus.sone.web.*
+import net.pterodactylus.sone.web.page.*
+import net.pterodactylus.util.web.Method.*
+import org.hamcrest.MatcherAssert.*
+import org.hamcrest.Matchers.*
+import org.junit.*
+import org.mockito.Mockito.*
 import org.mockito.Mockito.eq
-import org.mockito.Mockito.never
-import org.mockito.Mockito.verify
 
 /**
  * Unit test for [UploadImagePage].
  */
-class UploadImagePageTest : WebPageTest() {
+class UploadImagePageTest : WebPageTest(::UploadImagePage) {
 
-	private val parentAlbum = mock<Album>().apply {
-		whenever(id).thenReturn("parent-id")
-		whenever(sone).thenReturn(currentSone)
+	private val parentAlbum = AlbumImpl(currentSone, "parent-id")
+
+	@Test
+	fun `page returns correct path`() {
+		assertThat(page.path, equalTo("uploadImage.html"))
+	}
+
+	@Test
+	fun `page requires login`() {
+		assertThat(page.requiresLogin(), equalTo(true))
 	}
 
-	override fun getPage() = UploadImagePage(template, webInterface)
+	@Test
+	fun `page returns correct title`() {
+		addTranslation("Page.UploadImage.Title", "upload image page title")
+		assertThat(page.getPageTitle(soneRequest), equalTo("upload image page title"))
+	}
 
 	@Test
 	fun `get request does not redirect or upload anything`() {
@@ -46,9 +54,9 @@ class UploadImagePageTest : WebPageTest() {
 	@Test
 	fun `post request with parent that is not the current sone results in no permission error page`() {
 		setMethod(POST)
+		val remoteAlbum = AlbumImpl(mock(), "parent-id")
+		addAlbum("parent-id", remoteAlbum)
 		addHttpRequestPart("parent", "parent-id")
-		whenever(parentAlbum.sone).thenReturn(mock<Sone>())
-		addAlbum("parent-id", parentAlbum)
 		verifyRedirect("noPermission.html")
 	}
 
@@ -67,10 +75,11 @@ class UploadImagePageTest : WebPageTest() {
 		addAlbum("parent-id", parentAlbum)
 		addHttpRequestPart("parent", "parent-id")
 		addHttpRequestPart("title", "title")
-		addUploadedFile("image", "image.png", "image/png", "no-image.png")
+		addUploadedFile("image", "image.png", "image/png", "upload-image-invalid-image.png")
+		addTranslation("Page.UploadImage.Error.InvalidImage", "upload error - invalid image")
 		verifyNoRedirect {
 			verify(core, never()).createTemporaryImage(any(), any())
-			assertThat(templateContext["messages"] as String?, equalTo<String>("Page.UploadImage.Error.InvalidImage"))
+			assertThat(templateContext["messages"] as String, equalTo("upload error - invalid image"))
 		}
 	}
 
@@ -80,23 +89,29 @@ class UploadImagePageTest : WebPageTest() {
 		addAlbum("parent-id", parentAlbum)
 		addHttpRequestPart("parent", "parent-id")
 		addHttpRequestPart("title", "Title")
-		addHttpRequestPart("description", "Description")
-		addUploadedFile("image", "image.png", "image/png", "image.png")
+		addHttpRequestPart("description", "Description @ http://localhost:8888/KSK@foo")
+		addHttpRequestHeader("Host", "localhost:8888")
+		addUploadedFile("image", "upload-image-value-image.png", "image/png", "upload-image-value-image.png")
 		val temporaryImage = TemporaryImage("temp-image")
-		val imageModifier = mockBuilder<Modifier>()
-		val image = mock<Image>().apply {
-			whenever(modify()).thenReturn(imageModifier)
-		}
+		val image = ImageImpl()
 		whenever(core.createTemporaryImage(eq("image/png"), any())).thenReturn(temporaryImage)
 		whenever(core.createImage(currentSone, parentAlbum, temporaryImage)).thenReturn(image)
 		verifyRedirect("imageBrowser.html?album=parent-id") {
-			verify(image).modify()
-			verify(imageModifier).setWidth(2)
-			verify(imageModifier).setHeight(1)
-			verify(imageModifier).setTitle("Title")
-			verify(imageModifier).setDescription("Description")
-			verify(imageModifier).update()
+			assertThat(image.width, equalTo(2))
+			assertThat(image.height, equalTo(1))
+			assertThat(image.title, equalTo("Title"))
+			assertThat(image.description, equalTo("Description @ KSK@foo"))
 		}
 	}
 
+	@Test
+	fun `page can be created by dependency injection`() {
+		assertThat(baseInjector.getInstance<UploadImagePage>(), notNullValue())
+	}
+
+	@Test
+	fun `page is annotated with correct template path`() {
+		assertThat(page.templatePath, equalTo("/templates/invalid.html"))
+	}
+
 }