Don’t allow null for the post of a PostPart
authorDavid ‘Bombe’ Roden <bombe@pterodactylus.net>
Wed, 5 Oct 2016 19:14:06 +0000 (21:14 +0200)
committerDavid ‘Bombe’ Roden <bombe@pterodactylus.net>
Wed, 5 Oct 2016 19:14:06 +0000 (21:14 +0200)
src/main/java/net/pterodactylus/sone/text/PostPart.java
src/test/java/net/pterodactylus/sone/text/PostPartTest.java

index 68075a5..e70448f 100644 (file)
 
 package net.pterodactylus.sone.text;
 
+import java.util.Objects;
+
+import javax.annotation.Nonnull;
+
 import net.pterodactylus.sone.data.Post;
 
 /**
@@ -26,39 +30,17 @@ import net.pterodactylus.sone.data.Post;
  */
 public class PostPart implements Part {
 
-       /** The post this part refers to. */
        private final Post post;
 
-       /**
-        * Creates a new post part.
-        *
-        * @param post
-        *            The referenced post
-        */
-       public PostPart(Post post) {
-               this.post = post;
+       public PostPart(@Nonnull Post post) {
+               this.post = Objects.requireNonNull(post);
        }
 
-       //
-       // ACCESSORS
-       //
-
-       /**
-        * Returns the post referenced by this part.
-        *
-        * @return The post referenced by this part
-        */
+       @Nonnull
        public Post getPost() {
                return post;
        }
 
-       //
-       // PART METHODS
-       //
-
-       /**
-        * {@inheritDoc}
-        */
        @Override
        public String getText() {
                return post.getText();
index 6666d61..7b4ea19 100644 (file)
@@ -30,4 +30,9 @@ public class PostPartTest {
                assertThat(part.getText(), is("text"));
        }
 
+       @Test(expected = NullPointerException.class)
+       public void nullIsNotAllowedForPost() {
+           new PostPart(null);
+       }
+
 }