Add tests for LockSoneCommand and UnlockSoneCommand, use newer JUnit, add Mockito...

diff --git a/pom.xml b/pom.xml
index 0e2cc60..087d690 100644 (file)
--- a/pom.xml
+++ b/pom.xml
@@ -12,7 +12,13 @@
                <dependency>
                        <groupId>junit</groupId>
                        <artifactId>junit</artifactId>
-                       <version>3.8.2</version>
+                       <version>4.11</version>
+                       <scope>test</scope>
+               </dependency>
+               <dependency>
+                       <groupId>org.mockito</groupId>
+                       <artifactId>mockito-all</artifactId>
+                       <version>1.9.5</version>
                        <scope>test</scope>
                </dependency>
                <dependency>

diff --git a/src/test/java/net/pterodactylus/sone/fcp/LockSoneCommandTest.java b/src/test/java/net/pterodactylus/sone/fcp/LockSoneCommandTest.java
new file mode 100644 (file)
index 0000000..3789d08
--- /dev/null
+++ b/src/test/java/net/pterodactylus/sone/fcp/LockSoneCommandTest.java
@@ -0,0 +1,85 @@
+/*
+ * Sone - LockSoneCommandTest.java - Copyright © 2013 David Roden
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package net.pterodactylus.sone.fcp;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.notNullValue;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Matchers.anyBoolean;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import net.pterodactylus.sone.core.Core;
+import net.pterodactylus.sone.data.Sone;
+import net.pterodactylus.sone.freenet.SimpleFieldSetBuilder;
+import net.pterodactylus.sone.freenet.fcp.Command.Response;
+import net.pterodactylus.sone.freenet.fcp.FcpException;
+
+import freenet.support.SimpleFieldSet;
+
+import org.junit.Test;
+
+/**
+ * Tests for {@link UnlockSoneCommand}.
+ *
+ * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
+ */
+public class LockSoneCommandTest {
+
+       @Test
+       public void testLockingALocalSone() throws FcpException {
+               Sone localSone = mock(Sone.class);
+               when(localSone.getId()).thenReturn("LocalSone");
+               Core core = mock(Core.class);
+               when(core.getSone(eq("LocalSone"), anyBoolean())).thenReturn(localSone);
+               when(core.getLocalSone(eq("LocalSone"), anyBoolean())).thenReturn(localSone);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().put("Sone", "LocalSone").get();
+
+               LockSoneCommand lockSoneCommand = new LockSoneCommand(core);
+               Response response = lockSoneCommand.execute(fields, null, null);
+
+               verify(core).lockSone(eq(localSone));
+               assertThat(response, notNullValue());
+               assertThat(response.getReplyParameters(), notNullValue());
+               assertThat(response.getReplyParameters().get("Message"), is("SoneLocked"));
+               assertThat(response.getReplyParameters().get("Sone"), is("LocalSone"));
+       }
+
+       @Test(expected = FcpException.class)
+       public void testLockingARemoteSone() throws FcpException {
+               Sone removeSone = mock(Sone.class);
+               Core core = mock(Core.class);
+               when(core.getSone(eq("RemoteSone"), anyBoolean())).thenReturn(removeSone);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().put("Sone", "RemoteSone").get();
+
+               LockSoneCommand lockSoneCommand = new LockSoneCommand(core);
+               lockSoneCommand.execute(fields, null, null);
+       }
+
+       @Test(expected = FcpException.class)
+       public void testMissingSone() throws FcpException {
+               Core core = mock(Core.class);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().get();
+
+               LockSoneCommand lockSoneCommand = new LockSoneCommand(core);
+               lockSoneCommand.execute(fields, null, null);
+       }
+
+}

diff --git a/src/test/java/net/pterodactylus/sone/fcp/UnlockSoneCommandTest.java b/src/test/java/net/pterodactylus/sone/fcp/UnlockSoneCommandTest.java
new file mode 100644 (file)
index 0000000..05fc73c
--- /dev/null
+++ b/src/test/java/net/pterodactylus/sone/fcp/UnlockSoneCommandTest.java
@@ -0,0 +1,85 @@
+/*
+ * Sone - LockSoneCommandTest.java - Copyright © 2013 David Roden
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package net.pterodactylus.sone.fcp;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.notNullValue;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.mockito.Matchers.anyBoolean;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import net.pterodactylus.sone.core.Core;
+import net.pterodactylus.sone.data.Sone;
+import net.pterodactylus.sone.freenet.SimpleFieldSetBuilder;
+import net.pterodactylus.sone.freenet.fcp.Command.Response;
+import net.pterodactylus.sone.freenet.fcp.FcpException;
+
+import freenet.support.SimpleFieldSet;
+
+import org.junit.Test;
+
+/**
+ * Tests for {@link LockSoneCommand}.
+ *
+ * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
+ */
+public class UnlockSoneCommandTest {
+
+       @Test
+       public void testUnlockingALocalSone() throws FcpException {
+               Sone localSone = mock(Sone.class);
+               when(localSone.getId()).thenReturn("LocalSone");
+               Core core = mock(Core.class);
+               when(core.getSone(eq("LocalSone"), anyBoolean())).thenReturn(localSone);
+               when(core.getLocalSone(eq("LocalSone"), anyBoolean())).thenReturn(localSone);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().put("Sone", "LocalSone").get();
+
+               UnlockSoneCommand unlockSoneCommand = new UnlockSoneCommand(core);
+               Response response = unlockSoneCommand.execute(fields, null, null);
+
+               verify(core).unlockSone(eq(localSone));
+               assertThat(response, notNullValue());
+               assertThat(response.getReplyParameters(), notNullValue());
+               assertThat(response.getReplyParameters().get("Message"), is("SoneUnlocked"));
+               assertThat(response.getReplyParameters().get("Sone"), is("LocalSone"));
+       }
+
+       @Test(expected = FcpException.class)
+       public void testUnlockingARemoteSone() throws FcpException {
+               Sone removeSone = mock(Sone.class);
+               Core core = mock(Core.class);
+               when(core.getSone(eq("RemoteSone"), anyBoolean())).thenReturn(removeSone);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().put("Sone", "RemoteSone").get();
+
+               UnlockSoneCommand unlockSoneCommand = new UnlockSoneCommand(core);
+               unlockSoneCommand.execute(fields, null, null);
+       }
+
+       @Test(expected = FcpException.class)
+       public void testMissingSone() throws FcpException {
+               Core core = mock(Core.class);
+               SimpleFieldSet fields = new SimpleFieldSetBuilder().get();
+
+               UnlockSoneCommand unlockSoneCommand = new UnlockSoneCommand(core);
+               unlockSoneCommand.execute(fields, null, null);
+       }
+
+}