From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Wed, 11 Dec 2019 13:19:57 +0000 (+0100)
Subject: 🔥 Remove unnecessary not-null checks
X-Git-Tag: v81^2~5^2~57
X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=commitdiff_plain;h=4038d16030a1cb6bb48da2967ee2c9ec9b4aaeb0

🔥 Remove unnecessary not-null checks
---

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/notification/NotificationHandlerModuleTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/notification/NotificationHandlerModuleTest.kt
index 6bb02f4..11e728d 100644
--- a/src/test/kotlin/net/pterodactylus/sone/web/notification/NotificationHandlerModuleTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/notification/NotificationHandlerModuleTest.kt
@@ -52,21 +52,11 @@ class NotificationHandlerModuleTest {
 	)
 
 	@Test
-	fun `module can create notification handler`() {
-		assertThat(injector.getInstance<NotificationHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `notification handler is created as singleton`() {
 		injector.verifySingletonInstance<NotificationHandler>()
 	}
 
 	@Test
-	fun `module can create mark-post-known-during-first-start handler`() {
-		assertThat(injector.getInstance<MarkPostKnownDuringFirstStartHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `mark-post-known-during-first-start handler is created as singleton`() {
 		injector.verifySingletonInstance<MarkPostKnownDuringFirstStartHandler>()
 	}
@@ -83,11 +73,6 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `module can create sone-locked-on-startup handler`() {
-		assertThat(injector.getInstance<SoneLockedOnStartupHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `sone-locked-on-startup handler is created as singleton`() {
 		injector.verifySingletonInstance<SoneLockedOnStartupHandler>()
 	}
@@ -120,11 +105,6 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `new-sone handler can be created`() {
-		assertThat(injector.getInstance<NewSoneHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `new-sone handler is created as singleton`() {
 		injector.verifySingletonInstance<NewSoneHandler>()
 	}
@@ -149,21 +129,11 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `new-remote-post handler can be created`() {
-		assertThat(injector.getInstance<NewRemotePostHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `new-remote-post handler is created as singleton`() {
 		injector.verifySingletonInstance<NewRemotePostHandler>()
 	}
 
 	@Test
-	fun `new-remote-post notification can be created`() {
-		assertThat(injector.getInstance<ListNotification<Post>>(named("newRemotePost")), notNullValue())
-	}
-
-	@Test
 	fun `new-remote-post notification is created as singleton`() {
 		injector.verifySingletonInstance<ListNotification<Post>>(named("newRemotePost"))
 	}
@@ -188,11 +158,6 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `sone-locked notification can be created`() {
-		assertThat(injector.getInstance<ListNotification<Sone>>(named("soneLocked")), notNullValue())
-	}
-
-	@Test
 	fun `sone-locked notification is created as singleton`() {
 		injector.verifySingletonInstance<ListNotification<Sone>>(named("soneLocked"))
 	}
@@ -217,21 +182,11 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `sone-locked handler can be created`() {
-		assertThat(injector.getInstance<SoneLockedHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `sone-locked handler is created as singleton`() {
 		injector.verifySingletonInstance<SoneLockedHandler>()
 	}
 
 	@Test
-	fun `local-post notification can be created`() {
-		assertThat(injector.getInstance<ListNotification<Post>>(named("localPost")), notNullValue())
-	}
-
-	@Test
 	fun `local-post notification is not dismissable`() {
 		assertThat(injector.getInstance<ListNotification<Post>>(named("localPost")).isDismissable, equalTo(false))
 	}
@@ -256,11 +211,6 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `local-post handler can be created`() {
-		assertThat(injector.getInstance<LocalPostHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `local-post handler is created as singleton`() {
 		injector.verifySingletonInstance<LocalPostHandler>()
 	}
@@ -288,11 +238,6 @@ class NotificationHandlerModuleTest {
 	}
 
 	@Test
-	fun `new-version handler can be created`() {
-		assertThat(injector.getInstance<NewVersionHandler>(), notNullValue())
-	}
-
-	@Test
 	fun `new-version handler is created as singleton`() {
 		injector.verifySingletonInstance<NewVersionHandler>()
 	}