From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Wed, 20 Apr 2011 17:01:42 +0000 (+0200)
Subject: Don’t save Sone twice, especially not while synchronizing on the Sone.
X-Git-Tag: 0.6.3^2~19
X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=commitdiff_plain;h=584485247a06f2b2b9d87bc76c46f94968deb4af

Don’t save Sone twice, especially not while synchronizing on the Sone.

This causes deadlocks.
---

diff --git a/src/main/java/net/pterodactylus/sone/core/SoneInserter.java b/src/main/java/net/pterodactylus/sone/core/SoneInserter.java
index 3936975..d24b564 100644
--- a/src/main/java/net/pterodactylus/sone/core/SoneInserter.java
+++ b/src/main/java/net/pterodactylus/sone/core/SoneInserter.java
@@ -229,7 +229,6 @@ public class SoneInserter extends AbstractService {
 					synchronized (sone) {
 						if (lastInsertFingerprint.equals(sone.getFingerprint())) {
 							logger.log(Level.FINE, "Sone “%s” was not modified further, resetting counter…", new Object[] { sone });
-							core.saveSone(sone);
 							lastModificationTime = 0;
 							modified = false;
 						}