From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Tue, 17 Jan 2012 16:03:27 +0000 (+0100)
Subject: Use copy-on-write sets instead of synchronized collections.
X-Git-Tag: 0.8^2~36
X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=commitdiff_plain;h=796d369b021786649dbda6d5b3aed7a5d3b612a8

Use copy-on-write sets instead of synchronized collections.
---

diff --git a/src/main/java/net/pterodactylus/sone/data/Sone.java b/src/main/java/net/pterodactylus/sone/data/Sone.java
index 901d676..b79dad3 100644
--- a/src/main/java/net/pterodactylus/sone/data/Sone.java
+++ b/src/main/java/net/pterodactylus/sone/data/Sone.java
@@ -21,9 +21,10 @@ import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
+import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.concurrent.CopyOnWriteArraySet;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -177,22 +178,22 @@ public class Sone implements Fingerprintable, Comparable<Sone> {
 	private volatile Client client;
 
 	/** All friend Sones. */
-	private final Set<String> friendSones = Collections.synchronizedSet(new HashSet<String>());
+	private final Set<String> friendSones = new CopyOnWriteArraySet<String>();
 
 	/** All posts. */
-	private final Set<Post> posts = Collections.synchronizedSet(new HashSet<Post>());
+	private final Set<Post> posts = new CopyOnWriteArraySet<Post>();
 
 	/** All replies. */
-	private final Set<PostReply> replies = Collections.synchronizedSet(new HashSet<PostReply>());
+	private final Set<PostReply> replies = new CopyOnWriteArraySet<PostReply>();
 
 	/** The IDs of all liked posts. */
-	private final Set<String> likedPostIds = Collections.synchronizedSet(new HashSet<String>());
+	private final Set<String> likedPostIds = new CopyOnWriteArraySet<String>();
 
 	/** The IDs of all liked replies. */
-	private final Set<String> likedReplyIds = Collections.synchronizedSet(new HashSet<String>());
+	private final Set<String> likedReplyIds = new CopyOnWriteArraySet<String>();
 
 	/** The albums of this Sone. */
-	private final List<Album> albums = Collections.synchronizedList(new ArrayList<Album>());
+	private final List<Album> albums = new CopyOnWriteArrayList<Album>();
 
 	/** Sone-specific options. */
 	private final Options options = new Options();