From: David ‘Bombe’ Roden <bombe@pterodactylus.net>
Date: Sun, 5 Dec 2010 16:39:00 +0000 (+0100)
Subject: Don’t use the ID from the closure, it might have changed its value.
X-Git-Tag: 0.3.2-RC5~1
X-Git-Url: https://git.pterodactylus.net/?p=Sone.git;a=commitdiff_plain;h=dd6d3a370a80ab515ec14636a3b2b4cbfa3f0ac1

Don’t use the ID from the closure, it might have changed its value.

Oh, the joys of Javascript. :)
---

diff --git a/src/main/resources/static/javascript/sone.js b/src/main/resources/static/javascript/sone.js
index b44f19e..a042196 100644
--- a/src/main/resources/static/javascript/sone.js
+++ b/src/main/resources/static/javascript/sone.js
@@ -678,11 +678,11 @@ function loadNewPost(postId) {
 		return;
 	}
 	$.getJSON("getPost.ajax", { "post" : postId }, function(data, textStatus) {
-		if (postId in loadedPosts) {
-			return;
-		}
-		loadedPosts[postId] = true;
 		if ((data != null) && data.success) {
+			if (data.post.id in loadedPosts) {
+				return;
+			}
+			loadedPosts[data.post.id] = true;
 			if (!isIndexPage() && !(isViewSonePage() && ((getShownSoneId() == data.post.sone) || (getShownSoneId() == data.post.recipient)))) {
 				return;
 			}
@@ -711,12 +711,12 @@ function loadNewReply(replyId) {
 		return;
 	}
 	$.getJSON("getReply.ajax", { "reply": replyId }, function(data, textStatus) {
-		if (replyId in loadedReplies) {
-			return;
-		}
-		loadedReplies[replyId] = true;
 		/* find post. */
 		if ((data != null) && data.success) {
+			if (data.reply.id in loadedReplies) {
+				return;
+			}
+			loadedReplies[data.reply.id] = true;
 			$("#sone .post#" + data.reply.postId).each(function() {
 				var firstNewerReply = null;
 				$(this).find(".replies .reply").each(function() {