From 64268e8911d9d2052a41125ea5c0893926d1b2f4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Tue, 5 Sep 2017 11:28:27 +0200 Subject: [PATCH] Add test for distrust ajax page --- .../sone/web/ajax/DistrustAjaxPageTest.kt | 47 ++++++++++++++++++++++ .../pterodactylus/sone/web/ajax/JsonPageTest.kt | 9 ++++- 2 files changed, 54 insertions(+), 2 deletions(-) create mode 100644 src/test/kotlin/net/pterodactylus/sone/web/ajax/DistrustAjaxPageTest.kt diff --git a/src/test/kotlin/net/pterodactylus/sone/web/ajax/DistrustAjaxPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/ajax/DistrustAjaxPageTest.kt new file mode 100644 index 0000000..770d068 --- /dev/null +++ b/src/test/kotlin/net/pterodactylus/sone/web/ajax/DistrustAjaxPageTest.kt @@ -0,0 +1,47 @@ +package net.pterodactylus.sone.web.ajax + +import net.pterodactylus.sone.data.Sone +import net.pterodactylus.sone.test.mock +import org.hamcrest.MatcherAssert.assertThat +import org.hamcrest.Matchers.equalTo +import org.junit.Test +import org.mockito.Mockito.verify + +/** + * Unit test for [DistrustAjaxPage]. + */ +class DistrustAjaxPageTest : JsonPageTest("distrustSone.ajax", pageSupplier = ::DistrustAjaxPage) { + + @Test + fun `request with missing sone results in invalid-sone-id`() { + assertThat(json.isSuccess, equalTo(false)) + assertThat(json.error, equalTo("invalid-sone-id")) + } + + @Test + fun `request with invalid sone results in invalid-sone-id`() { + addRequestParameter("sone", "invalid-sone") + assertThat(json.isSuccess, equalTo(false)) + assertThat(json.error, equalTo("invalid-sone-id")) + } + + @Test + fun `request with valid sone results in distrusted sone`() { + val sone = mock() + addSone(sone, "sone-id") + addRequestParameter("sone", "sone-id") + assertThat(json.isSuccess, equalTo(true)) + verify(core).distrustSone(currentSone, sone) + } + + @Test + fun `request with valid sone results in correct trust value being sent back`() { + core.preferences.negativeTrust = -33 + val sone = mock() + addSone(sone, "sone-id") + addRequestParameter("sone", "sone-id") + assertThat(json.isSuccess, equalTo(true)) + assertThat(json["trustValue"].asInt(), equalTo(-33)) + } + +} diff --git a/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt index f3558fa..cb5ee5a 100644 --- a/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt @@ -1,11 +1,13 @@ package net.pterodactylus.sone.web.ajax +import com.google.common.eventbus.EventBus import freenet.clients.http.ToadletContext import freenet.support.SimpleReadOnlyArrayBucket import freenet.support.api.HTTPRequest import net.pterodactylus.sone.core.Core import net.pterodactylus.sone.core.ElementLoader import net.pterodactylus.sone.core.LinkedElement +import net.pterodactylus.sone.core.Preferences import net.pterodactylus.sone.data.Post import net.pterodactylus.sone.data.PostReply import net.pterodactylus.sone.data.Profile @@ -44,6 +46,8 @@ abstract class JsonPageTest( protected val webInterface = mock() protected val core = mock() + protected val eventBus = mock() + protected val preferences = Preferences(eventBus) protected val elementLoader = mock() protected open val page: JsonPage by lazy { pageSupplier(webInterface) } protected val json by lazy { page.createJsonObject(freenetRequest)!! } @@ -80,6 +84,7 @@ abstract class JsonPageTest( @Before fun setupCore() { + whenever(core.preferences).thenReturn(preferences) whenever(core.getSone(anyString())).thenAnswer { (localSones + remoteSones)[it.getArgument(0)].asOptional() } whenever(core.getLocalSone(anyString())).thenAnswer { localSones[it[0]] } whenever(core.getPost(anyString())).thenAnswer { (posts + newPosts)[it[0]].asOptional() } @@ -158,8 +163,8 @@ abstract class JsonPageTest( notifications[notificationId ?: notification.id] = notification } - protected fun addSone(sone: Sone) { - remoteSones += sone.id to sone + protected fun addSone(sone: Sone, soneId: String? = null) { + remoteSones += (soneId ?: sone.id) to sone } protected fun addLocalSone(id: String, sone: Sone) { -- 2.7.4