From 3c93a3f01e3cab17bda2b97354ffee23929cb26a Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Fri, 31 Jul 2015 16:50:05 +0200 Subject: [PATCH] Remove some unnecessary qualifiers, whitespace, and comments --- .../java/net/pterodactylus/sone/data/Reply.java | 31 ++++++++-------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/src/main/java/net/pterodactylus/sone/data/Reply.java b/src/main/java/net/pterodactylus/sone/data/Reply.java index 69769eb..cf50a5c 100644 --- a/src/main/java/net/pterodactylus/sone/data/Reply.java +++ b/src/main/java/net/pterodactylus/sone/data/Reply.java @@ -20,6 +20,7 @@ package net.pterodactylus.sone.data; import java.util.Comparator; import com.google.common.base.Predicate; +import com.google.common.primitives.Longs; /** * Defines methods common for all replies. @@ -31,29 +32,19 @@ import com.google.common.base.Predicate; public interface Reply> extends Identified { /** Comparator that sorts replies ascending by time. */ - public static final Comparator> TIME_COMPARATOR = new Comparator>() { - - /** - * {@inheritDoc} - */ + Comparator> TIME_COMPARATOR = new Comparator>() { @Override public int compare(Reply leftReply, Reply rightReply) { - return (int) Math.max(Integer.MIN_VALUE, Math.min(Integer.MAX_VALUE, leftReply.getTime() - rightReply.getTime())); + return Longs.compare(leftReply.getTime(), rightReply.getTime()); } - }; /** Filter for replies with timestamps from the future. */ - public static final Predicate> FUTURE_REPLY_FILTER = new Predicate>() { - - /** - * {@inheritDoc} - */ + Predicate> FUTURE_REPLY_FILTER = new Predicate>() { @Override public boolean apply(Reply reply) { return (reply != null) && (reply.getTime() <= System.currentTimeMillis()); } - }; /** @@ -61,7 +52,7 @@ public interface Reply> extends Identified { * * @return The ID of the reply */ - public String getId(); + String getId(); String getInternalId(); /** @@ -69,36 +60,36 @@ public interface Reply> extends Identified { * * @return The Sone that posted this reply */ - public Sone getSone(); + Sone getSone(); /** * Returns the time of the reply. * * @return The time of the reply (in milliseconds since Jan 1, 1970 UTC) */ - public long getTime(); + long getTime(); /** * Returns the text of the reply. * * @return The text of the reply */ - public String getText(); + String getText(); /** * Returns whether this reply is known. * * @return {@code true} if this reply is known, {@code false} otherwise */ - public boolean isKnown(); + boolean isKnown(); /** * Sets whether this reply is known. * * @param known - * {@code true} if this reply is known, {@code false} otherwise + * {@code true} if this reply is known, {@code false} otherwise * @return This reply */ - public T setKnown(boolean known); + T setKnown(boolean known); } -- 2.7.4